mbox series

[0/2] weston: fix i.MX support

Message ID 20200619125500.524503-1-gary.bisson@boundarydevices.com
Headers show
Series weston: fix i.MX support | expand

Message

Gary Bisson June 19, 2020, 12:54 p.m. UTC
Hi,

This series aims at fixing the weston support for i.MX processors.

Long time ago, weston-imx was added for i.MX8MQ as part of the weston
package. Then it was split from it as the versions differed.

Since then the weston-imx was broken and updating it seems like a bad
idea as it now requires forking several other components:
- libdrm [1]
- waylands-protocols [2]

This series therefore removes weston-imx and adds vivante support to
the regular weston package.

Drawback here is that the HDR capabilities of the i.MX8MQ or the GPU2D
of the i.MX8M Mini won't be used in Weston. I'd rather have those
limitations and use standard weston than forking everything.

Also, note that this series was tested on Nitrogen8M and Nitrogen8M Mini
platforms, making sure the Vivante 3D examples are properly running.
However in order to compile weston properly with Vivante as egl
provider, one patch sent earlier [3] is needed.

Let me know if you have any questions.

Regards,
Gary

[1] https://source.codeaurora.org/external/imx/meta-imx/tree/meta-bsp/recipes-graphics/drm/libdrm_2.4.99.imx.bb?h=zeus-5.4.3-1.0.0
[2] https://source.codeaurora.org/external/imx/meta-imx/tree/meta-bsp/recipes-graphics/wayland/wayland-protocols_1.18.imx.bb?h=zeus-5.4.3-1.0.0
[3] http://patchwork.ozlabs.org/project/buildroot/patch/20200402130842.918696-3-gary.bisson@boundarydevices.com/

Gary Bisson (2):
  package/weston: add imx-gpu-viv as possible egl provider
  package/weston-imx: remove deprecated package

 Config.in.legacy                   |   6 ++
 package/Config.in                  |   1 -
 package/weston-imx/Config.in       | 114 -----------------------
 package/weston-imx/weston-imx.hash |   3 -
 package/weston-imx/weston-imx.mk   | 144 -----------------------------
 package/weston/Config.in           |   8 +-
 6 files changed, 10 insertions(+), 266 deletions(-)
 delete mode 100644 package/weston-imx/Config.in
 delete mode 100644 package/weston-imx/weston-imx.hash
 delete mode 100644 package/weston-imx/weston-imx.mk

Comments

Gary Bisson July 26, 2020, 7:55 p.m. UTC | #1
Hi,

Gentle ping on this series, do you have any questions?

Note that I got i.MX8M VPU to work using regular GStreamer packages +
gtreamer-imx-v2 plugin but is only useful if Weston if fixed (as i.MX8*
graphics only support Wayland backend).

Regards,
Gary

On Fri, Jun 19, 2020 at 02:54:58PM +0200, Gary Bisson wrote:
> Hi,
> 
> This series aims at fixing the weston support for i.MX processors.
> 
> Long time ago, weston-imx was added for i.MX8MQ as part of the weston
> package. Then it was split from it as the versions differed.
> 
> Since then the weston-imx was broken and updating it seems like a bad
> idea as it now requires forking several other components:
> - libdrm [1]
> - waylands-protocols [2]
> 
> This series therefore removes weston-imx and adds vivante support to
> the regular weston package.
> 
> Drawback here is that the HDR capabilities of the i.MX8MQ or the GPU2D
> of the i.MX8M Mini won't be used in Weston. I'd rather have those
> limitations and use standard weston than forking everything.
> 
> Also, note that this series was tested on Nitrogen8M and Nitrogen8M Mini
> platforms, making sure the Vivante 3D examples are properly running.
> However in order to compile weston properly with Vivante as egl
> provider, one patch sent earlier [3] is needed.
> 
> Let me know if you have any questions.
> 
> Regards,
> Gary
> 
> [1] https://source.codeaurora.org/external/imx/meta-imx/tree/meta-bsp/recipes-graphics/drm/libdrm_2.4.99.imx.bb?h=zeus-5.4.3-1.0.0
> [2] https://source.codeaurora.org/external/imx/meta-imx/tree/meta-bsp/recipes-graphics/wayland/wayland-protocols_1.18.imx.bb?h=zeus-5.4.3-1.0.0
> [3] http://patchwork.ozlabs.org/project/buildroot/patch/20200402130842.918696-3-gary.bisson@boundarydevices.com/
> 
> Gary Bisson (2):
>   package/weston: add imx-gpu-viv as possible egl provider
>   package/weston-imx: remove deprecated package
> 
>  Config.in.legacy                   |   6 ++
>  package/Config.in                  |   1 -
>  package/weston-imx/Config.in       | 114 -----------------------
>  package/weston-imx/weston-imx.hash |   3 -
>  package/weston-imx/weston-imx.mk   | 144 -----------------------------
>  package/weston/Config.in           |   8 +-
>  6 files changed, 10 insertions(+), 266 deletions(-)
>  delete mode 100644 package/weston-imx/Config.in
>  delete mode 100644 package/weston-imx/weston-imx.hash
>  delete mode 100644 package/weston-imx/weston-imx.mk
> 
> -- 
> 2.26.2
>
Thomas Petazzoni Sept. 12, 2020, 12:27 p.m. UTC | #2
Hello,

On Fri, 19 Jun 2020 14:54:58 +0200
Gary Bisson <gary.bisson@boundarydevices.com> wrote:

> Gary Bisson (2):
>   package/weston: add imx-gpu-viv as possible egl provider
>   package/weston-imx: remove deprecated package

Thanks, series applied.

For the first patch, I think we need to add a proper libgbm virtual
package. I had a patch series for that, but it's not trivial as not all
gbm implementations implement the full/recent GBM API. I had some ideas
to address that, but needs some more investigation/time.

Thomas
Gary Bisson Sept. 12, 2020, 4:18 p.m. UTC | #3
Hi Thomas,

On Sat, Sep 12, 2020 at 02:27:13PM +0200, Thomas Petazzoni wrote:
> Hello,
> 
> On Fri, 19 Jun 2020 14:54:58 +0200
> Gary Bisson <gary.bisson@boundarydevices.com> wrote:
> 
> > Gary Bisson (2):
> >   package/weston: add imx-gpu-viv as possible egl provider
> >   package/weston-imx: remove deprecated package
> 
> Thanks, series applied.

Thanks, that is awesome!

> For the first patch, I think we need to add a proper libgbm virtual
> package. I had a patch series for that, but it's not trivial as not all
> gbm implementations implement the full/recent GBM API. I had some ideas
> to address that, but needs some more investigation/time.

Yes that would indeed be a better solution, I've noticed other packages
that have added dependency on Mesa3d for libgbm (kmscube, glmark2
pending patch[1]).

From the cover letter of this series I also mentioned another patch sent
before that is necessary for a proper build of Weston with imx-gpu-viv
[2].
I thought that was that patch that was problematic as, as you pointed
out already, the sed isn't an elegant solution but I still believe it's
the less intrusive one.
Let me know what you think of it.

Regards,
Gary

[1] http://patchwork.ozlabs.org/project/buildroot/patch/20200104193919.91589-2-bernd.kuhls@t-online.de/
[2] http://patchwork.ozlabs.org/project/buildroot/patch/20200402130842.918696-3-gary.bisson@boundarydevices.com/