mbox series

[0/5] Fix fallouts from LINUX_BUILD_CMDS simplification

Message ID 20190422200830.2831-1-thomas.petazzoni@bootlin.com
Headers show
Series Fix fallouts from LINUX_BUILD_CMDS simplification | expand

Message

Thomas Petazzoni April 22, 2019, 8:08 p.m. UTC 
Hello,

In commit ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed, a patch of mine
changed LINUX_BUILD_CMDS to do "make all $(LINUX_TARGET_NAME)" instead
of "make $(LINUX_TARGET_NAME)" and "make modules".

This has caused a number of build issues in our defconfigs:

 - A number of kernel configurations apparently don't build well when
   the "all" target is built concurrently with $(LINUX_TARGET_NAME),
   with weird file not found errors.

   We fix this by doing "make all" and "make $(LINUX_TARGET_NAME)"
   separately (first patch)

 - Due to calling "make all", a little bit more might get built, and
   sometimes this "little bit more" needs mkimage, so we add
   host-uboot-tools to the defconfig. This is enough as linux/linux.mk
   automatically adds host-uboot-tools to its dependency if it's
   enabled. I hesitated with adding an explicit
   BR2_LINUX_KERNEL_NEEDS_HOST_UBOOT_TOOLS option, let me know if this
   sounds better or if the proposed solution in this patch series is
   good enough.

Thanks,

Thomas

Thomas Petazzoni (5):
  linux: split calling "all" and "$(LINUX_TARGET_NAME)" targets
  configs/beaglebone: kernel build needs mkimage
  configs/qemu_nios2_10m50: kernel build needs mkimage
  configs/qemu_ppc_mpc8544ds: kernel build needs mkimage
  configs/qemu_ppc_virtex_ml507: kernel build needs mkimage

 configs/beaglebone_defconfig            | 2 ++
 configs/qemu_nios2_10m50_defconfig      | 3 +++
 configs/qemu_ppc_mpc8544ds_defconfig    | 3 +++
 configs/qemu_ppc_virtex_ml507_defconfig | 3 +++
 linux/linux.mk                          | 3 ++-
 5 files changed, 13 insertions(+), 1 deletion(-)

Comments

Yann E. MORIN April 22, 2019, 8:34 p.m. UTC | #1 
Thomas, All,

On 2019-04-22 22:08 +0200, Thomas Petazzoni spake thusly:
>  - Due to calling "make all", a little bit more might get built, and
>    sometimes this "little bit more" needs mkimage, so we add
>    host-uboot-tools to the defconfig. This is enough as linux/linux.mk
>    automatically adds host-uboot-tools to its dependency if it's
>    enabled. I hesitated with adding an explicit
>    BR2_LINUX_KERNEL_NEEDS_HOST_UBOOT_TOOLS option, let me know if this
>    sounds better or if the proposed solution in this patch series is
>    good enough.

Ithink the NEEDS_FOO options are only interesting when the host package
does not have a kconfig option of its own.

In this case, I think it is correct to do as you did.

If linux did not have a conditional dependency on host-uboot-tools, then
it should be added, rather than add a NEEDS_HOST_UBOOT_TOOLS.

Regards,
Yann E. MORIN.
Thomas Petazzoni April 24, 2019, 8:47 p.m. UTC | #2 
On Mon, 22 Apr 2019 22:08:24 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> Thomas Petazzoni (5):
>   linux: split calling "all" and "$(LINUX_TARGET_NAME)" targets
>   configs/beaglebone: kernel build needs mkimage
>   configs/qemu_nios2_10m50: kernel build needs mkimage
>   configs/qemu_ppc_mpc8544ds: kernel build needs mkimage
>   configs/qemu_ppc_virtex_ml507: kernel build needs mkimage

I've applied the series, after adding a comment in linux.mk in PATCH
1/5, as suggested by Yann.

Thomas