| Message ID | 20181116121701.14359da0@akathisia (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | next/apply_patch Successfully applied |
| snowpatch_ozlabs/build-ppc64le | fail | build failed! |
| snowpatch_ozlabs/build-ppc64be | fail | build failed! |
| snowpatch_ozlabs/build-ppc64e | fail | build failed! |
| snowpatch_ozlabs/build-pmac32 | fail | build failed! |
| snowpatch_ozlabs/checkpatch | warning | total: 0 errors, 0 warnings, 1 checks, 8 lines checked |
Elvira Khabirova <lineprinter@altlinux.org> writes: > Arch code should use tracehook_*() helpers, as documented > in include/linux/tracehook.h. Thanks. It probably also should have a comment explaining why we're ignoring the return value and why that's OK. cheers > Fixes: 5521eb4bca2d ("powerpc/ptrace: Add support for PTRACE_SYSEMU") > Signed-off-by: Elvira Khabirova <lineprinter@altlinux.org> > --- > arch/powerpc/kernel/ptrace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c > index afb819f4ca68..d79d907f9acc 100644 > --- a/arch/powerpc/kernel/ptrace.c > +++ b/arch/powerpc/kernel/ptrace.c > @@ -3266,7 +3266,7 @@ long do_syscall_trace_enter(struct pt_regs *regs) > user_exit(); > > if (test_thread_flag(TIF_SYSCALL_EMU)) { > - ptrace_report_syscall(regs); > + (void) tracehook_report_syscall_entry(regs); > /* > * Returning -1 will skip the syscall execution. We want to > * avoid clobbering any register also, thus, not 'gotoing' > -- > 2.19.1
diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c index afb819f4ca68..d79d907f9acc 100644 --- a/arch/powerpc/kernel/ptrace.c +++ b/arch/powerpc/kernel/ptrace.c @@ -3266,7 +3266,7 @@ long do_syscall_trace_enter(struct pt_regs *regs) user_exit(); if (test_thread_flag(TIF_SYSCALL_EMU)) { - ptrace_report_syscall(regs); + (void) tracehook_report_syscall_entry(regs); /* * Returning -1 will skip the syscall execution. We want to * avoid clobbering any register also, thus, not 'gotoing'
Arch code should use tracehook_*() helpers, as documented in include/linux/tracehook.h. Fixes: 5521eb4bca2d ("powerpc/ptrace: Add support for PTRACE_SYSEMU") Signed-off-by: Elvira Khabirova <lineprinter@altlinux.org> --- arch/powerpc/kernel/ptrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)