| Message ID | 20181115175854.7550-4-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Superseded |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | ACPI: Generate SPCR table | expand |
On 15.11.18 18:58, Andy Shevchenko wrote: > New callback will supply necessary information, for example, > to ACPI SPCR table. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/serial/ns16550.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c > index b51b56de9f..698acbfb51 100644 > --- a/drivers/serial/ns16550.c > +++ b/drivers/serial/ns16550.c > @@ -334,6 +334,19 @@ static int ns16550_serial_setbrg(struct udevice *dev, int baudrate) > return 0; > } > > +static int ns16550_serial_getinfo(struct udevice *dev, struct serial_device_info *info) This line is above 80 characters. Please run checkpatch.pl on your patches. Alex > +{ > + struct NS16550 *const com_port = dev_get_priv(dev); > + struct ns16550_platdata *plat = com_port->plat; > + > + info->addr_space = 0; > + info->reg_width = plat->reg_width * 8; > + info->reg_shift = plat->reg_shift; > + info->reg_offset = plat->reg_offset; > + info->addr = plat->base; > + return 0; > +} > + > int ns16550_serial_probe(struct udevice *dev) > { > struct NS16550 *const com_port = dev_get_priv(dev); > @@ -441,6 +454,7 @@ const struct dm_serial_ops ns16550_serial_ops = { > .pending = ns16550_serial_pending, > .getc = ns16550_serial_getc, > .setbrg = ns16550_serial_setbrg, > + .getinfo = ns16550_serial_getinfo, > }; > > #if CONFIG_IS_ENABLED(OF_CONTROL) && !CONFIG_IS_ENABLED(OF_PLATDATA) >
On Thu, Nov 15, 2018 at 8:30 PM Alexander Graf <agraf@suse.de> wrote: > On 15.11.18 18:58, Andy Shevchenko wrote: > > New callback will supply necessary information, for example, > > to ACPI SPCR table. > > +static int ns16550_serial_getinfo(struct udevice *dev, struct serial_device_info *info) > > This line is above 80 characters. Please run checkpatch.pl on your patches. When you saw last time the terminal for 80 character limit? I really don't give a crap about 80 characters limit when it uglifies the code. Okay, here is 87 characters, so, I tend to split line as you suggested.
HI Andy, On 15 November 2018 at 11:37, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Thu, Nov 15, 2018 at 8:30 PM Alexander Graf <agraf@suse.de> wrote: >> On 15.11.18 18:58, Andy Shevchenko wrote: >> > New callback will supply necessary information, for example, >> > to ACPI SPCR table. > >> > +static int ns16550_serial_getinfo(struct udevice *dev, struct serial_device_info *info) >> >> This line is above 80 characters. Please run checkpatch.pl on your patches. > > When you saw last time the terminal for 80 character limit? > I really don't give a crap about 80 characters limit when it uglifies the code. > > Okay, here is 87 characters, so, I tend to split line as you suggested. If you use patman it will check this for you. I'm going to hold off on reviewing this since I'm not sure about the struct purpose. Regards, Simon
diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index b51b56de9f..698acbfb51 100644 --- a/drivers/serial/ns16550.c +++ b/drivers/serial/ns16550.c @@ -334,6 +334,19 @@ static int ns16550_serial_setbrg(struct udevice *dev, int baudrate) return 0; } +static int ns16550_serial_getinfo(struct udevice *dev, struct serial_device_info *info) +{ + struct NS16550 *const com_port = dev_get_priv(dev); + struct ns16550_platdata *plat = com_port->plat; + + info->addr_space = 0; + info->reg_width = plat->reg_width * 8; + info->reg_shift = plat->reg_shift; + info->reg_offset = plat->reg_offset; + info->addr = plat->base; + return 0; +} + int ns16550_serial_probe(struct udevice *dev) { struct NS16550 *const com_port = dev_get_priv(dev); @@ -441,6 +454,7 @@ const struct dm_serial_ops ns16550_serial_ops = { .pending = ns16550_serial_pending, .getc = ns16550_serial_getc, .setbrg = ns16550_serial_setbrg, + .getinfo = ns16550_serial_getinfo, }; #if CONFIG_IS_ENABLED(OF_CONTROL) && !CONFIG_IS_ENABLED(OF_PLATDATA)
New callback will supply necessary information, for example, to ACPI SPCR table. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/serial/ns16550.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)