| Message ID | 20181114082314.8965-20-hch@lst.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [01/34] powerpc: use mm zones more sensibly | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | next/apply_patch Successfully applied |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 24 lines checked |
ping? On Wed, Nov 14, 2018 at 09:22:59AM +0100, Christoph Hellwig wrote: > The CXL code never even looks at the dma mask, so there is no good > reason for this sanity check. Remove it because it gets in the way > of the dma ops refactoring. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > drivers/misc/cxl/vphb.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/misc/cxl/vphb.c b/drivers/misc/cxl/vphb.c > index 7908633d9204..49da2f744bbf 100644 > --- a/drivers/misc/cxl/vphb.c > +++ b/drivers/misc/cxl/vphb.c > @@ -11,17 +11,6 @@ > #include <misc/cxl.h> > #include "cxl.h" > > -static int cxl_dma_set_mask(struct pci_dev *pdev, u64 dma_mask) > -{ > - if (dma_mask < DMA_BIT_MASK(64)) { > - pr_info("%s only 64bit DMA supported on CXL", __func__); > - return -EIO; > - } > - > - *(pdev->dev.dma_mask) = dma_mask; > - return 0; > -} > - > static int cxl_pci_probe_mode(struct pci_bus *bus) > { > return PCI_PROBE_NORMAL; > @@ -220,7 +209,6 @@ static struct pci_controller_ops cxl_pci_controller_ops = > .reset_secondary_bus = cxl_pci_reset_secondary_bus, > .setup_msi_irqs = cxl_setup_msi_irqs, > .teardown_msi_irqs = cxl_teardown_msi_irqs, > - .dma_set_mask = cxl_dma_set_mask, > }; > > int cxl_pci_vphb_add(struct cxl_afu *afu) > -- > 2.19.1 > > _______________________________________________ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu ---end quoted text---
diff --git a/drivers/misc/cxl/vphb.c b/drivers/misc/cxl/vphb.c index 7908633d9204..49da2f744bbf 100644 --- a/drivers/misc/cxl/vphb.c +++ b/drivers/misc/cxl/vphb.c @@ -11,17 +11,6 @@ #include <misc/cxl.h> #include "cxl.h" -static int cxl_dma_set_mask(struct pci_dev *pdev, u64 dma_mask) -{ - if (dma_mask < DMA_BIT_MASK(64)) { - pr_info("%s only 64bit DMA supported on CXL", __func__); - return -EIO; - } - - *(pdev->dev.dma_mask) = dma_mask; - return 0; -} - static int cxl_pci_probe_mode(struct pci_bus *bus) { return PCI_PROBE_NORMAL; @@ -220,7 +209,6 @@ static struct pci_controller_ops cxl_pci_controller_ops = .reset_secondary_bus = cxl_pci_reset_secondary_bus, .setup_msi_irqs = cxl_setup_msi_irqs, .teardown_msi_irqs = cxl_teardown_msi_irqs, - .dma_set_mask = cxl_dma_set_mask, }; int cxl_pci_vphb_add(struct cxl_afu *afu)
The CXL code never even looks at the dma mask, so there is no good reason for this sanity check. Remove it because it gets in the way of the dma ops refactoring. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/misc/cxl/vphb.c | 12 ------------ 1 file changed, 12 deletions(-)