mbox

[PULL,00/15] Python queue, 2018-10-30

Message ID 20181031003120.26771-1-ehabkost@redhat.com
State New
Headers show

Pull-request

git://github.com/ehabkost/qemu.git tags/python-next-pull-request

Message

Eduardo Habkost Oct. 31, 2018, 12:31 a.m. UTC 
Sorry for submitting this at the last minute.

The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd:

  Merge remote-tracking branch 'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging (2018-10-30 15:49:55 +0000)

are available in the Git repository at:

  git://github.com/ehabkost/qemu.git tags/python-next-pull-request

for you to fetch changes up to e301e65c97142c4d2a2adf35f5a4fa73d65d8a4f:

  scripts/qemu.py: use a more consistent docstring style (2018-10-30 21:13:54 -0300)

----------------------------------------------------------------
Python queue, 2018-10-30

* Makefile rule for running acceptance tests
  (make check-acceptance) (Cleber Rosa)
* Make iotests compatible with Python 3
  (Max Reitz)
* device-crash-test whitelist update (Thomas Huth)
* Misc cleanups (Cleber Rosa)

----------------------------------------------------------------

Cleber Rosa (5):
  Bootstrap Python venv for tests
  Acceptance tests: add make rule for running them
  Travis support for the acceptance tests
  scripts/decodetree.py: fix reference to attributes
  scripts/qemu.py: use a more consistent docstring style

Max Reitz (9):
  iotests: Make nbd-fault-injector flush
  iotests: Flush in iotests.py's QemuIoInteractive
  iotests: Use Python byte strings where appropriate
  iotests: Use // for Python integer division
  iotests: Different iterator behavior in Python 3
  iotests: Explicitly bequeath FDs in Python
  iotests: 'new' module replacement in 169
  iotests: Modify imports for Python 3
  iotests: Unify log outputs between Python 2 and 3

Thomas Huth (1):
  scripts/device-crash-test: Remove devices that are not user_creatable
    anymore

 docs/devel/testing.rst                   |  43 +-
 tests/requirements.txt                   |   4 +
 scripts/decodetree.py                    |   2 +-
 scripts/qemu.py                          |  99 +++--
 scripts/qtest.py                         |   2 +-
 .travis.yml                              |   8 +
 scripts/device-crash-test                |  17 -
 tests/Makefile.include                   |  43 ++
 tests/qemu-iotests/030                   |   2 +-
 tests/qemu-iotests/040                   |   4 +-
 tests/qemu-iotests/041                   |   4 +-
 tests/qemu-iotests/044                   |  24 +-
 tests/qemu-iotests/045                   |   2 +-
 tests/qemu-iotests/056                   |   2 +-
 tests/qemu-iotests/065                   |   4 +-
 tests/qemu-iotests/083.out               |   9 +
 tests/qemu-iotests/093                   |  18 +-
 tests/qemu-iotests/124                   |   4 +-
 tests/qemu-iotests/136                   |   2 +-
 tests/qemu-iotests/139                   |   2 +-
 tests/qemu-iotests/147                   |   2 +-
 tests/qemu-iotests/149                   |  14 +-
 tests/qemu-iotests/151                   |  12 +-
 tests/qemu-iotests/163                   |  13 +-
 tests/qemu-iotests/169                   |   3 +-
 tests/qemu-iotests/194.out               |  22 +-
 tests/qemu-iotests/202.out               |  12 +-
 tests/qemu-iotests/203.out               |  14 +-
 tests/qemu-iotests/206.out               | 218 +++++-----
 tests/qemu-iotests/207                   |   6 +-
 tests/qemu-iotests/207.out               |  72 ++--
 tests/qemu-iotests/208.out               |   8 +-
 tests/qemu-iotests/210.out               |  94 ++--
 tests/qemu-iotests/211.out               | 102 ++---
 tests/qemu-iotests/212.out               | 174 ++++----
 tests/qemu-iotests/213.out               | 182 ++++----
 tests/qemu-iotests/216.out               |   4 +-
 tests/qemu-iotests/218.out               |  20 +-
 tests/qemu-iotests/219.out               | 526 +++++++++++------------
 tests/qemu-iotests/222.out               |  24 +-
 tests/qemu-iotests/iotests.py            |  37 +-
 tests/qemu-iotests/nbd-fault-injector.py |  12 +-
 tests/qemu-iotests/qcow2.py              |  10 +-
 tests/qemu-iotests/qed.py                |   6 +-
 44 files changed, 1014 insertions(+), 868 deletions(-)
 create mode 100644 tests/requirements.txt

Comments

no-reply@patchew.org Nov. 1, 2018, 5:02 a.m. UTC | #1 
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20181031003120.26771-1-ehabkost@redhat.com
Subject: [Qemu-devel] [PULL 00/15] Python queue, 2018-10-30

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
ecdea7d559 scripts/qemu.py: use a more consistent docstring style
6ddc1452f7 scripts/decodetree.py: fix reference to attributes
3ad025e8ee Travis support for the acceptance tests
1d3c9f27c6 Acceptance tests: add make rule for running them
c3960877a7 Bootstrap Python venv for tests
8813f0cf44 iotests: Unify log outputs between Python 2 and 3
fcfed8478f iotests: Modify imports for Python 3
c55c4c4e7f iotests: 'new' module replacement in 169
df208ab7f4 iotests: Explicitly bequeath FDs in Python
f1b456a621 iotests: Different iterator behavior in Python 3
67d5fdbb30 iotests: Use // for Python integer division
4240e24793 iotests: Use Python byte strings where appropriate
c3f2f4635d iotests: Flush in iotests.py's QemuIoInteractive
08dbcfb140 iotests: Make nbd-fault-injector flush
90484ef565 scripts/device-crash-test: Remove devices that are not user_creatable anymore

=== OUTPUT BEGIN ===
Checking PATCH 1/15: scripts/device-crash-test: Remove devices that are not user_creatable anymore...
Checking PATCH 2/15: iotests: Make nbd-fault-injector flush...
Checking PATCH 3/15: iotests: Flush in iotests.py's QemuIoInteractive...
Checking PATCH 4/15: iotests: Use Python byte strings where appropriate...
Checking PATCH 5/15: iotests: Use // for Python integer division...
ERROR: line over 90 characters
#236: FILE: tests/qemu-iotests/qed.py:83:
+        self.table_nelems = self.header['table_size'] * self.header['cluster_size'] // table_elem_size

total: 1 errors, 0 warnings, 179 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/15: iotests: Different iterator behavior in Python 3...
Checking PATCH 7/15: iotests: Explicitly bequeath FDs in Python...
Checking PATCH 8/15: iotests: 'new' module replacement in 169...
Checking PATCH 9/15: iotests: Modify imports for Python 3...
Checking PATCH 10/15: iotests: Unify log outputs between Python 2 and 3...
Checking PATCH 11/15: Bootstrap Python venv for tests...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#80: 
new file mode 100644

total: 0 errors, 1 warnings, 47 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 12/15: Acceptance tests: add make rule for running them...
Checking PATCH 13/15: Travis support for the acceptance tests...
Checking PATCH 14/15: scripts/decodetree.py: fix reference to attributes...
Checking PATCH 15/15: scripts/qemu.py: use a more consistent docstring style...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Peter Maydell Nov. 1, 2018, 1:54 p.m. UTC | #2 
On 31 October 2018 at 00:31, Eduardo Habkost <ehabkost@redhat.com> wrote:
> Sorry for submitting this at the last minute.
>
> The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd:
>
>   Merge remote-tracking branch 'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging (2018-10-30 15:49:55 +0000)
>
> are available in the Git repository at:
>
>   git://github.com/ehabkost/qemu.git tags/python-next-pull-request
>
> for you to fetch changes up to e301e65c97142c4d2a2adf35f5a4fa73d65d8a4f:
>
>   scripts/qemu.py: use a more consistent docstring style (2018-10-30 21:13:54 -0300)
>
> ----------------------------------------------------------------
> Python queue, 2018-10-30
>
> * Makefile rule for running acceptance tests
>   (make check-acceptance) (Cleber Rosa)
> * Make iotests compatible with Python 3
>   (Max Reitz)
> * device-crash-test whitelist update (Thomas Huth)
> * Misc cleanups (Cleber Rosa)
>
> ----------------------------------------------------------------

Applied, thanks.

-- PMM