Message ID | irq-stale-remap-comment@mdm.bga.com (mailing list archive) |
---|---|
State | Accepted, archived |
Commit | 8142f032a90680ed2fb080ca694ffe9509276361 |
Headers | show |
Index: work.git/arch/powerpc/kernel/irq.c =================================================================== --- work.git.orig/arch/powerpc/kernel/irq.c 2011-05-24 20:43:46.350096135 -0500 +++ work.git/arch/powerpc/kernel/irq.c 2011-05-24 21:03:49.520096058 -0500 @@ -727,9 +727,7 @@ unsigned int irq_create_mapping(struct i } pr_debug("irq: -> using host @%p\n", host); - /* Check if mapping already exist, if it does, call - * host->ops->map() to update the flags - */ + /* Check if mapping already exists */ virq = irq_find_mapping(host, hwirq); if (virq != NO_IRQ) { pr_debug("irq: -> existing mapping on virq %d\n", virq);
The comment claims we will call host->ops->map() to update the flags if we find a previously established mapping, but we never did. We used to call remap, but that call was removed in da05198002 (powerpc: Remove irq_host_ops->remap hook). Signed-off-by: Milton Miller <miltonm@bga.com>