[net-next,12/22] net: ovs: fix return type of ndo_start_xmit function
diff mbox series

Message ID 20180920123306.14772-13-yuehaibing@huawei.com
State Not Applicable
Headers show
  • net: fix return type of ndo_start_xmit function
Related show


Context Check Description
snowpatch_ozlabs/checkpatch success Test checkpatch on branch next
snowpatch_ozlabs/apply_patch success next/apply_patch Successfully applied

Commit Message

YueHaibing Sept. 20, 2018, 12:32 p.m. UTC
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.

Found by coccinelle.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
 net/openvswitch/vport-internal_dev.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff mbox series

diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c
index bb95c43..26f71cb 100644
--- a/net/openvswitch/vport-internal_dev.c
+++ b/net/openvswitch/vport-internal_dev.c
@@ -43,7 +43,8 @@  static struct internal_dev *internal_dev_priv(struct net_device *netdev)
 /* Called with rcu_read_lock_bh. */
-static int internal_dev_xmit(struct sk_buff *skb, struct net_device *netdev)
+static netdev_tx_t
+internal_dev_xmit(struct sk_buff *skb, struct net_device *netdev)
 	int len, err;
@@ -62,7 +63,7 @@  static int internal_dev_xmit(struct sk_buff *skb, struct net_device *netdev)
 	} else {
-	return 0;
+	return NETDEV_TX_OK;
 static int internal_dev_open(struct net_device *netdev)