diff mbox series

[04/18] perl-time-parsedate: new package

Message ID 20180820115519.24046-5-chrismcc@gmail.com
State Accepted
Headers show
Series perl modules again | expand

Commit Message

Christopher McCrory Aug. 20, 2018, 11:55 a.m. UTC 
Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
---
 DEVELOPERS                                           |  1 +
 package/Config.in                                    |  1 +
 package/perl-time-parsedate/Config.in                |  6 ++++++
 package/perl-time-parsedate/perl-time-parsedate.hash |  6 ++++++
 package/perl-time-parsedate/perl-time-parsedate.mk   | 13 +++++++++++++
 5 files changed, 27 insertions(+)
 create mode 100644 package/perl-time-parsedate/Config.in
 create mode 100644 package/perl-time-parsedate/perl-time-parsedate.hash
 create mode 100644 package/perl-time-parsedate/perl-time-parsedate.mk

Comments

Thomas Petazzoni Aug. 20, 2018, 11:59 a.m. UTC | #1 
Hello,

On Mon, 20 Aug 2018 04:55:05 -0700, Christopher McCrory wrote:

> +PERL_TIME_PARSEDATE_VERSION = 2015.103
> +PERL_TIME_PARSEDATE_SOURCE = Time-ParseDate-$(PERL_TIME_PARSEDATE_VERSION).tar.gz
> +PERL_TIME_PARSEDATE_SITE = $(BR2_CPAN_MIRROR)/authors/id/M/MU/MUIR/modules
> +PERL_TIME_PARSEDATE_LICENSE_FILES = README
> +PERL_TIME_PARSEDATE_LICENSE = unknown

Could you check with upstream what is the license ? An unknown license
means you're not allow to redistribute it, which would be a bit
annoying, no ?

Here is what Debian says about the license:

  https://metadata.ftp-master.debian.org/changelogs/main/libt/libtime-parsedate-perl/libtime-parsedate-perl_2015.103-2_copyright

I.e:

 License hereby granted for anyone to use, modify or redistribute this module
 at their own risk. Please feed useful changes back to cpan@dave.sharnoff.org.

So, "Time::ParseDate License" ?

Thomas
Christopher McCrory Aug. 20, 2018, 12:12 p.m. UTC | #2 
On Mon, Aug 20, 2018 at 4:59 AM, Thomas Petazzoni <
thomas.petazzoni@bootlin.com> wrote:

> Hello,
>
> On Mon, 20 Aug 2018 04:55:05 -0700, Christopher McCrory wrote:
>
> > +PERL_TIME_PARSEDATE_VERSION = 2015.103
> > +PERL_TIME_PARSEDATE_SOURCE = Time-ParseDate-$(PERL_TIME_
> PARSEDATE_VERSION).tar.gz
> > +PERL_TIME_PARSEDATE_SITE = $(BR2_CPAN_MIRROR)/authors/id/
> M/MU/MUIR/modules
> > +PERL_TIME_PARSEDATE_LICENSE_FILES = README
> > +PERL_TIME_PARSEDATE_LICENSE = unknown
>
> Could you check with upstream what is the license ? An unknown license
> means you're not allow to redistribute it, which would be a bit
> annoying, no ?
>
> Here is what Debian says about the license:
>
>   https://metadata.ftp-master.debian.org/changelogs/main/
> libt/libtime-parsedate-perl/libtime-parsedate-perl_2015.103-2_copyright
>
> I.e:
>
>  License hereby granted for anyone to use, modify or redistribute this
> module
>  at their own risk. Please feed useful changes back to
> cpan@dave.sharnoff.org.
>
> So, "Time::ParseDate License" ?
>
>

It looks like I missed putting this in the cover leter
0013-perl-time-parsedate-add-license.patch has



-PERL_TIME_PARSEDATE_LICENSE = unknown
+# https://fedoraproject.org/wiki/Licensing/TPDL
+PERL_TIME_PARSEDATE_LICENSE = Public Domain

THe URL has:

This is a very short permissive license found in the perl module
Time::ParseDate. The request to "feed useful changes back" is interpreted
as a polite request, not a requirement. It is Free and GPL compatible.

Copyright (C) 1996-2010 David Muir Sharnoff. Copyright (C) 2011 Google, Inc.
License hereby granted for anyone to use, modify or redistribute this module
at their own risk. Please feed useful changes back to cpan@dave.sharnoff.org
.



If you want to change it locally to what you think is best before commiting
and ignore 0013 , I'm good with that.





> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
Thomas Petazzoni Aug. 20, 2018, 12:27 p.m. UTC | #3 
Hello,

On Mon, 20 Aug 2018 05:12:22 -0700, Christopher McCrory wrote:

> It looks like I missed putting this in the cover leter
> 0013-perl-time-parsedate-add-license.patch has
> 
> 
> -PERL_TIME_PARSEDATE_LICENSE = unknown
> +# https://fedoraproject.org/wiki/Licensing/TPDL
> +PERL_TIME_PARSEDATE_LICENSE = Public Domain

Why is this change part of a separate patch ? It should be inside the
patch adding the perl-time-parsedate package.

Also, the license is not public domain. Fedora calls it TPDL, which
stands for Time Parse Date License.

Thomas
Christopher McCrory Aug. 20, 2018, 12:41 p.m. UTC | #4 
On Mon, Aug 20, 2018 at 5:27 AM, Thomas Petazzoni <
thomas.petazzoni@bootlin.com> wrote:

> Hello,
>
> On Mon, 20 Aug 2018 05:12:22 -0700, Christopher McCrory wrote:
>
> > It looks like I missed putting this in the cover leter
> > 0013-perl-time-parsedate-add-license.patch has
> >
> >
> > -PERL_TIME_PARSEDATE_LICENSE = unknown
> > +# https://fedoraproject.org/wiki/Licensing/TPDL
> > +PERL_TIME_PARSEDATE_LICENSE = Public Domain
>
> Why is this change part of a separate patch ? It should be inside the
> patch adding the perl-time-parsedate package.
>

I wasn't sure what would be best.  It allows a followup patch to do the
right thing.



>
> Also, the license is not public domain. Fedora calls it TPDL, which
> stands for Time Parse Date License.
>
>
https://src.fedoraproject.org/rpms/perl-Time-ParseDate/blob/master/f/perl-Time-ParseDate.spec

Summary:        Perl modules for parsing dates and times
# See https://fedoraproject.org/wiki/Licensing/TPDL
License:        TPDL and Public Domain
URL:            https://metacpan.org/release/Time-ParseDate


Arg, that should have also been in the cover letter,  Somehow I missed it
during copy and paste.


Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
Thomas Petazzoni Sept. 12, 2018, 8:26 p.m. UTC | #5 
Hello,

On Mon, 20 Aug 2018 04:55:05 -0700, Christopher McCrory wrote:
> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
> ---
>  DEVELOPERS                                           |  1 +
>  package/Config.in                                    |  1 +
>  package/perl-time-parsedate/Config.in                |  6 ++++++
>  package/perl-time-parsedate/perl-time-parsedate.hash |  6 ++++++
>  package/perl-time-parsedate/perl-time-parsedate.mk   | 13 +++++++++++++
>  5 files changed, 27 insertions(+)
>  create mode 100644 package/perl-time-parsedate/Config.in
>  create mode 100644 package/perl-time-parsedate/perl-time-parsedate.hash
>  create mode 100644 package/perl-time-parsedate/perl-time-parsedate.mk

I have applied this patch, after fixing the license details, see below.


> +# computed by scancpan
> +sha256 a8f6d313ecc680934da33872f69e6f4fa64ad9840b016d4d4822e952e518a964 README

This README file contained nothing that is useful from a license point
of view.

> +PERL_TIME_PARSEDATE_LICENSE_FILES = README
> +PERL_TIME_PARSEDATE_LICENSE = unknown

I have changed this to:

+PERL_TIME_PARSEDATE_LICENSE = Time Parse Date License, Public Domain
+PERL_TIME_PARSEDATE_LICENSE_FILES = lib/Time/JulianDay.pm lib/Time/Timezone.pm

Indeed, most files are under the special "Time Parse Date License",
except Timezone.pm, which is in the public domain. I've updated
the .hash file to include the hashes of JulianDay.pm and Timezone.pm.

Thanks,

Thomas
diff mbox series

Patch

diff --git a/DEVELOPERS b/DEVELOPERS
index 023bddbce0..105fae199c 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -505,6 +505,7 @@  F:	package/perl-params-util/
 F:	package/perl-sub-install/
 F:	package/perl-sys-meminfo/
 F:	package/perl-sys-mmap/
+F:	package/perl-time-parsedate/
 
 N:	Clayton Shotwell <clayton.shotwell@rockwellcollins.com>
 F:	package/audit/
diff --git a/package/Config.in b/package/Config.in
index f412ff673b..7629cf6c46 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -732,6 +732,7 @@  menu "Perl libraries/modules"
 	source "package/perl-sys-meminfo/Config.in"
 	source "package/perl-sys-mmap/Config.in"
 	source "package/perl-time-hires/Config.in"
+	source "package/perl-time-parsedate/Config.in"
 	source "package/perl-timedate/Config.in"
 	source "package/perl-try-tiny/Config.in"
 	source "package/perl-uri/Config.in"
diff --git a/package/perl-time-parsedate/Config.in b/package/perl-time-parsedate/Config.in
new file mode 100644
index 0000000000..cea5d2941e
--- /dev/null
+++ b/package/perl-time-parsedate/Config.in
@@ -0,0 +1,6 @@ 
+config BR2_PACKAGE_PERL_TIME_PARSEDATE
+	bool "perl-time-parsedate"
+	help
+	  Parse and format time values
+
+	  https://metacpan.org/release/Time-ParseDate
diff --git a/package/perl-time-parsedate/perl-time-parsedate.hash b/package/perl-time-parsedate/perl-time-parsedate.hash
new file mode 100644
index 0000000000..97d0009850
--- /dev/null
+++ b/package/perl-time-parsedate/perl-time-parsedate.hash
@@ -0,0 +1,6 @@ 
+# retrieved by scancpan from http://cpan.metacpan.org/
+md5    9143d075278857d21c77467d26f1603b Time-ParseDate-2015.103.tar.gz
+sha256 2c1a06235bf811813caac9eaa9daa71af758667cdf7b082cb59863220fcaeed1 Time-ParseDate-2015.103.tar.gz
+
+# computed by scancpan
+sha256 a8f6d313ecc680934da33872f69e6f4fa64ad9840b016d4d4822e952e518a964 README
diff --git a/package/perl-time-parsedate/perl-time-parsedate.mk b/package/perl-time-parsedate/perl-time-parsedate.mk
new file mode 100644
index 0000000000..e866e0decc
--- /dev/null
+++ b/package/perl-time-parsedate/perl-time-parsedate.mk
@@ -0,0 +1,13 @@ 
+################################################################################
+#
+# perl-time-parsedate
+#
+################################################################################
+
+PERL_TIME_PARSEDATE_VERSION = 2015.103
+PERL_TIME_PARSEDATE_SOURCE = Time-ParseDate-$(PERL_TIME_PARSEDATE_VERSION).tar.gz
+PERL_TIME_PARSEDATE_SITE = $(BR2_CPAN_MIRROR)/authors/id/M/MU/MUIR/modules
+PERL_TIME_PARSEDATE_LICENSE_FILES = README
+PERL_TIME_PARSEDATE_LICENSE = unknown
+
+$(eval $(perl-package))