| Message ID | 1530691407-3991-1-git-send-email-hofrat@osadl.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d3e669f31ec35856f5e85df9224ede5bdbf1bc7b |
| Headers | show |
| Series | powerpc: icp-hv: fix missing of_node_put in success path | expand |
On Wed, 4 Jul 2018 10:03:27 +0200, Nicholas Mc Guire wrote: > Both of_find_compatible_node() and of_find_node_by_type() will > return a refcounted node on success - thus for the success path > the node must be explicitly released with a of_node_put(). Applied to powerpc/next. [1/1] powerpc/icp-hv: Fix missing of_node_put() in success path https://git.kernel.org/powerpc/c/d3e669f31ec35856f5e85df9224ede5bdbf1bc7b cheers
diff --git a/arch/powerpc/sysdev/xics/icp-hv.c b/arch/powerpc/sysdev/xics/icp-hv.c index bbc839a..003deaa 100644 --- a/arch/powerpc/sysdev/xics/icp-hv.c +++ b/arch/powerpc/sysdev/xics/icp-hv.c @@ -179,6 +179,7 @@ int icp_hv_init(void) icp_ops = &icp_hv_ops; + of_node_put(np); return 0; }
Both of_find_compatible_node() and of_find_node_by_type() will return a refcounted node on success - thus for the success path the node must be explicitly released with a of_node_put(). Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> Fixes: commit 0b05ac6e2480 ("powerpc/xics: Rewrite XICS driver") --- Problem found by experimental coccinelle script Patch was compiletested with: ppc64_defconfig (implies CONFIG_PPC_ICP_HV=y) with sparse warnings though not related to the proposed change Patch is against 4.18-rc3 (localversion-next is next-20180704) arch/powerpc/sysdev/xics/icp-hv.c | 1 + 1 file changed, 1 insertion(+)