| Message ID | 1529763008-20426-1-git-send-email-michael@amarulasolutions.com |
|---|---|
| State | Accepted |
| Commit | 4a72abcb71d9be773df438f237cc95c2ed399295 |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [U-Boot,1/2] imx: imx6: Add comment to gpr_init function | expand |
On Sat, Jun 23, 2018 at 7:40 PM, Michael Trimarchi <michael@amarulasolutions.com> wrote: > This function can be used only for some of the nxp SoC. Make > it explicit in the comment. This adjust a bit commit > 3aa4b703b483f165dd ("imx: imx6: Move gpr_init() function to soc.c") > > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> > --- > arch/arm/mach-imx/mx6/soc.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/mach-imx/mx6/soc.c b/arch/arm/mach-imx/mx6/soc.c > index e8b6f77..2c87c6e 100644 > --- a/arch/arm/mach-imx/mx6/soc.c > +++ b/arch/arm/mach-imx/mx6/soc.c > @@ -649,6 +649,11 @@ void imx_setup_hdmi(void) > } > #endif > > + > +/* > + * gpr_init() function is common for boards using MX6S, MX6DL, MX6D, > + * MX6Q and MX6QP processors > + */ > void gpr_init(void) > { > struct iomuxc *iomux = (struct iomuxc *)IOMUXC_BASE_ADDR; > -- May be adding ifdef !imx6ul on the code also make sense. Acked-by: Jagan Teki <jagan@amarulasolutions.com>
diff --git a/arch/arm/mach-imx/mx6/soc.c b/arch/arm/mach-imx/mx6/soc.c index e8b6f77..2c87c6e 100644 --- a/arch/arm/mach-imx/mx6/soc.c +++ b/arch/arm/mach-imx/mx6/soc.c @@ -649,6 +649,11 @@ void imx_setup_hdmi(void) } #endif + +/* + * gpr_init() function is common for boards using MX6S, MX6DL, MX6D, + * MX6Q and MX6QP processors + */ void gpr_init(void) { struct iomuxc *iomux = (struct iomuxc *)IOMUXC_BASE_ADDR;
This function can be used only for some of the nxp SoC. Make it explicit in the comment. This adjust a bit commit 3aa4b703b483f165dd ("imx: imx6: Move gpr_init() function to soc.c") Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> --- arch/arm/mach-imx/mx6/soc.c | 5 +++++ 1 file changed, 5 insertions(+)