| Message ID | 20180611190417.22898-1-afd@ti.com |
|---|---|
| State | Accepted |
| Commit | a1b73c18724eb8cb75f7a60d851578d933c78095 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot] arm: Do not clear LR on exception in SPL | expand |
On Mon, Jun 11, 2018 at 02:04:17PM -0500, Andrew F. Davis wrote: > When an exception or interrupt occurs the link register (LR) may > contain the source of the exception, although we do not print the > value it may still be extracted with a debugger. When in SPL we > loop on getting and exception, but use a linking branch, which > over-writes the LR value, use a regular branch instruction here. > > Signed-off-by: Andrew F. Davis <afd@ti.com> Applied to u-boot/master, thanks!
diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S index 79afc27e84..d629cb1dc2 100644 --- a/arch/arm/lib/vectors.S +++ b/arch/arm/lib/vectors.S @@ -133,7 +133,7 @@ not_used: irq: fiq: 1: - bl 1b /* hang and never return */ + b 1b /* hang and never return */ #else /* !CONFIG_SPL_BUILD */
When an exception or interrupt occurs the link register (LR) may contain the source of the exception, although we do not print the value it may still be extracted with a debugger. When in SPL we loop on getting and exception, but use a linking branch, which over-writes the LR value, use a regular branch instruction here. Signed-off-by: Andrew F. Davis <afd@ti.com> --- arch/arm/lib/vectors.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)