| Message ID | 20180605123611.21759-1-F.LaRoche@pilz.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/1] Use one call to mkdir to create needed directories. | expand |
Hello, On Tue, 5 Jun 2018 14:36:11 +0200, Florian La Roche wrote: > Reduce this to only call mkdir once to create the needed directories. > > > Signed-off-by: Florian La Roche <F.LaRoche@pilz.de> Thanks for all your patches. Generally they look good to me in terms of contents, but there are a few minor formatting issues that would make them better: - The commit title should include a prefix of the package being impacted. - The commit title should often be a bit shorter. - The commit log should contain only one empty line before the SoB line, not two empty lines. - A non empty commit log would be better, to give additional explanations when necessary. For this patch, a better commit log would for example be: busybox: reduce number of mkdir calls in inittab The default Busybox inittab does two separate mkdir calls to create /dev/pts and /dev/shm, which is not necessary. Let's refactor those two calls into a single one. Signed-off-by: ... Thomas
diff --git a/package/busybox/inittab b/package/busybox/inittab index ef58c32f0d..7cd203de0b 100644 --- a/package/busybox/inittab +++ b/package/busybox/inittab @@ -16,8 +16,7 @@ # Startup the system ::sysinit:/bin/mount -t proc proc /proc ::sysinit:/bin/mount -o remount,rw / -::sysinit:/bin/mkdir -p /dev/pts -::sysinit:/bin/mkdir -p /dev/shm +::sysinit:/bin/mkdir -p /dev/pts /dev/shm ::sysinit:/bin/mount -a null::sysinit:/bin/ln -sf /proc/self/fd /dev/fd null::sysinit:/bin/ln -sf /proc/self/fd/0 /dev/stdin
Reduce this to only call mkdir once to create the needed directories. Signed-off-by: Florian La Roche <F.LaRoche@pilz.de> --- package/busybox/inittab | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)