| Message ID | 20180530131457.20245-1-yousaf.kaukab@suse.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot] Makefile: build u-boot before running its generator | expand |
On 05/30/2018 03:14 PM, Mian Yousaf Kaukab wrote: > SPL_FIT_GENERATOR may need to access u-boot binaries for generating > u-boot.its file. For example arch/arm/mach-rockchip/make_fit_atf.py > requires u-boot elf. Add u-boot-nodtb.bin as dependency for > U_BOOT_ITS so that u-boot binaries are available when > SPL_FIT_GENERATOR is run with parallel make. > > Suggested-by: Petr Tesarik <ptesarik@suse.com> > Signed-off-by: Mian Yousaf Kaukab <yousaf.kaukab@suse.com> > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index d08fb6a54d..54557d62b8 100644 > --- a/Makefile > +++ b/Makefile > @@ -1060,7 +1060,7 @@ U_BOOT_ITS = $(subst ",,$(CONFIG_SPL_FIT_SOURCE)) > else > ifneq ($(CONFIG_SPL_FIT_GENERATOR),"") > U_BOOT_ITS := u-boot.its > -$(U_BOOT_ITS): FORCE > +$(U_BOOT_ITS): u-boot-nodtb.bin FORCE spl is not being built even after adding this. > $(srctree)/$(CONFIG_SPL_FIT_GENERATOR) \ > $(patsubst %,arch/$(ARCH)/dts/%.dtb,$(subst ",,$(CONFIG_OF_LIST))) > $@ > endif > BR, Yousaf
diff --git a/Makefile b/Makefile index d08fb6a54d..54557d62b8 100644 --- a/Makefile +++ b/Makefile @@ -1060,7 +1060,7 @@ U_BOOT_ITS = $(subst ",,$(CONFIG_SPL_FIT_SOURCE)) else ifneq ($(CONFIG_SPL_FIT_GENERATOR),"") U_BOOT_ITS := u-boot.its -$(U_BOOT_ITS): FORCE +$(U_BOOT_ITS): u-boot-nodtb.bin FORCE $(srctree)/$(CONFIG_SPL_FIT_GENERATOR) \ $(patsubst %,arch/$(ARCH)/dts/%.dtb,$(subst ",,$(CONFIG_OF_LIST))) > $@ endif
SPL_FIT_GENERATOR may need to access u-boot binaries for generating u-boot.its file. For example arch/arm/mach-rockchip/make_fit_atf.py requires u-boot elf. Add u-boot-nodtb.bin as dependency for U_BOOT_ITS so that u-boot binaries are available when SPL_FIT_GENERATOR is run with parallel make. Suggested-by: Petr Tesarik <ptesarik@suse.com> Signed-off-by: Mian Yousaf Kaukab <yousaf.kaukab@suse.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)