| Message ID | 20180519121355.18377-2-erosca@de.adit-jv.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,v3,1/6] kconfig: re-sync with Linux 4.17-rc4 | expand |
Hi Eugeniu, On 19.05.2018 14:13, Eugeniu Rosca wrote: > After importing linux v4.16-rc1 commit 2c37e08464a8 ("kconfig: Warn if > choice default is not in choice"), Kconfig complains: > > scripts/kconfig/conf --syncconfig Kconfig > board/eets/pdu001/Kconfig:22:warning: \ > choice default symbol 'PDU001_RUN_LED_RED' \ > is not contained in the choice > > This looks to be caused by a typo. Fix it. Indeed, thanks for the fix! Please make sure to cc maintainers (me in this case). I do not follow every post on the list ;-) > > Fixes: 85ab0452fefc ("arm: add support for PDU001") > Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com> > Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > v2->v3: > * No changes. > > v1->v2: > * Added: Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > board/eets/pdu001/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/eets/pdu001/Kconfig b/board/eets/pdu001/Kconfig > index f28ba6e7bff2..e64ae28875b1 100644 > --- a/board/eets/pdu001/Kconfig > +++ b/board/eets/pdu001/Kconfig > @@ -19,7 +19,7 @@ config SYS_CONFIG_NAME > > choice > prompt "State of Run LED" > - default PDU001_RUN_LED_RED > + default RUN_LED_RED > help > The PDU001 has a bi-color (red/green) LED labeled 'Run' which > can be used to indicate the operating state of the board. By > Reviewed-by: Felix Brack <fb@ltec.ch> Tested-by: Felix Brack <fb@ltec.ch> regards, Felix
Hi Felix, On Tue, May 22, 2018 at 10:07:58AM +0200, Felix Brack wrote: > Hi Eugeniu, > > On 19.05.2018 14:13, Eugeniu Rosca wrote: > > After importing linux v4.16-rc1 commit 2c37e08464a8 ("kconfig: Warn if > > choice default is not in choice"), Kconfig complains: > > > > scripts/kconfig/conf --syncconfig Kconfig > > board/eets/pdu001/Kconfig:22:warning: \ > > choice default symbol 'PDU001_RUN_LED_RED' \ > > is not contained in the choice > > > > This looks to be caused by a typo. Fix it. > > Indeed, thanks for the fix! > > Please make sure to cc maintainers (me in this case). I do not follow > every post on the list ;-) Sure. Normally I collect the relevant people like this: $ git log -- board/eets/pdu001/Kconfig | grep "\-by: " | \ sed 's/.*-by: //' | sort | uniq -c | sort -rn 2 Tom Rini <trini@konsulko.com> 1 Felix Brack <fb@ltec.ch> 1 Adam Ford <aford173@gmail.com> But omitted doing it on this specific patch. Will be more careful next time! > > > > Fixes: 85ab0452fefc ("arm: add support for PDU001") > > Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com> > > Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > --- > > > > v2->v3: > > * No changes. > > > > v1->v2: > > * Added: Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > > > board/eets/pdu001/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/board/eets/pdu001/Kconfig b/board/eets/pdu001/Kconfig > > index f28ba6e7bff2..e64ae28875b1 100644 > > --- a/board/eets/pdu001/Kconfig > > +++ b/board/eets/pdu001/Kconfig > > @@ -19,7 +19,7 @@ config SYS_CONFIG_NAME > > > > choice > > prompt "State of Run LED" > > - default PDU001_RUN_LED_RED > > + default RUN_LED_RED > > help > > The PDU001 has a bi-color (red/green) LED labeled 'Run' which > > can be used to indicate the operating state of the board. By > > > > Reviewed-by: Felix Brack <fb@ltec.ch> > Tested-by: Felix Brack <fb@ltec.ch> Thanks! Eugeniu. > > regards, Felix
On Sat, May 19, 2018 at 02:13:51PM +0200, Eugeniu Rosca wrote: > After importing linux v4.16-rc1 commit 2c37e08464a8 ("kconfig: Warn if > choice default is not in choice"), Kconfig complains: > > scripts/kconfig/conf --syncconfig Kconfig > board/eets/pdu001/Kconfig:22:warning: \ > choice default symbol 'PDU001_RUN_LED_RED' \ > is not contained in the choice > > This looks to be caused by a typo. Fix it. > > Fixes: 85ab0452fefc ("arm: add support for PDU001") > Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com> > Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com> > Reviewed-by: Felix Brack <fb@ltec.ch> > Tested-by: Felix Brack <fb@ltec.ch> Applied to u-boot/master, thanks!
diff --git a/board/eets/pdu001/Kconfig b/board/eets/pdu001/Kconfig index f28ba6e7bff2..e64ae28875b1 100644 --- a/board/eets/pdu001/Kconfig +++ b/board/eets/pdu001/Kconfig @@ -19,7 +19,7 @@ config SYS_CONFIG_NAME choice prompt "State of Run LED" - default PDU001_RUN_LED_RED + default RUN_LED_RED help The PDU001 has a bi-color (red/green) LED labeled 'Run' which can be used to indicate the operating state of the board. By
After importing linux v4.16-rc1 commit 2c37e08464a8 ("kconfig: Warn if choice default is not in choice"), Kconfig complains: scripts/kconfig/conf --syncconfig Kconfig board/eets/pdu001/Kconfig:22:warning: \ choice default symbol 'PDU001_RUN_LED_RED' \ is not contained in the choice This looks to be caused by a typo. Fix it. Fixes: 85ab0452fefc ("arm: add support for PDU001") Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com> Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- v2->v3: * No changes. v1->v2: * Added: Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com> board/eets/pdu001/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)