| Message ID | 20180517210333.26977-1-jakllsch@kollasch.net |
|---|---|
| State | Changes Requested |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | [U-Boot] arm: dts: sunxi: enable Ethernet on NanoPi Neo Plus2 | expand |
Hi, On Thu, May 17, 2018 at 04:03:33PM -0500, Jonathan A. Kollasch wrote: > Signed-off-by: Jonathan A. Kollasch <jakllsch@kollasch.net> > --- > > arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts b/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts > index f1406c224b..1dde153669 100644 > --- a/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts > +++ b/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts > @@ -104,3 +104,18 @@ > &usbphy { > status = "okay"; > }; > + > +&emac { > + pinctrl-names = "default"; > + pinctrl-0 = <&emac_rgmii_pins>; > + phy-mode = "rgmii"; > + phy-handle = <&ext_rgmii_phy>; > + status = "okay"; > +}; > + > +&external_mdio { > + ext_rgmii_phy: ethernet-phy@7 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <7>; > + }; > +}; We usually share our DT with Linux, and the node is already described there, so we should just sync the DT with the Linux one instead. Please provide the Linux commit ID you used to sync in your next iteration too. Thanks! Maxime
diff --git a/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts b/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts index f1406c224b..1dde153669 100644 --- a/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts +++ b/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts @@ -104,3 +104,18 @@ &usbphy { status = "okay"; }; + +&emac { + pinctrl-names = "default"; + pinctrl-0 = <&emac_rgmii_pins>; + phy-mode = "rgmii"; + phy-handle = <&ext_rgmii_phy>; + status = "okay"; +}; + +&external_mdio { + ext_rgmii_phy: ethernet-phy@7 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <7>; + }; +};
Signed-off-by: Jonathan A. Kollasch <jakllsch@kollasch.net> --- arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+)