diff mbox series

[U-Boot] Kconfig: Add dependency on HASH to verified boot

Message ID 1525255638-27694-1-git-send-email-keguang.zhang@gmail.com
State Accepted
Commit 535adee8692f89df3472f92ae68d6aa0efb883d7
Delegated to: Tom Rini
Headers show
Series [U-Boot] Kconfig: Add dependency on HASH to verified boot | expand

Commit Message

Keguang Zhang May 2, 2018, 10:07 a.m. UTC
Building with verified boot support requires hash, add that
dependency here. Otherwise the following build error will come out
without crc command.

      LD      u-boot
lib/built-in.o: In function `hash_calculate':
lib/rsa/rsa-checksum.c:29: undefined reference to
`hash_progressive_lookup_algo'
...
make[1]: *** [u-boot] Error 1

Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
---

 Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Joe Hershberger May 2, 2018, 9:56 p.m. UTC | #1
On Wed, May 2, 2018 at 5:07 AM, Kelvin Cheung <keguang.zhang@gmail.com> wrote:
> Building with verified boot support requires hash, add that
> dependency here. Otherwise the following build error will come out
> without crc command.
>
>       LD      u-boot
> lib/built-in.o: In function `hash_calculate':
> lib/rsa/rsa-checksum.c:29: undefined reference to
> `hash_progressive_lookup_algo'
> ...
> make[1]: *** [u-boot] Error 1
>
> Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>

Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
Tom Rini May 6, 2018, 9:12 p.m. UTC | #2
On Wed, May 02, 2018 at 06:07:18PM +0800, Kelvin Cheung wrote:

> Building with verified boot support requires hash, add that
> dependency here. Otherwise the following build error will come out
> without crc command.
> 
>       LD      u-boot
> lib/built-in.o: In function `hash_calculate':
> lib/rsa/rsa-checksum.c:29: undefined reference to
> `hash_progressive_lookup_algo'
> ...
> make[1]: *** [u-boot] Error 1
> 
> Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
> Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/Kconfig b/Kconfig
index 37331d2..9fd9de1 100644
--- a/Kconfig
+++ b/Kconfig
@@ -253,6 +253,7 @@  config FIT_SIGNATURE
 	bool "Enable signature verification of FIT uImages"
 	depends on DM
 	select RSA
+	select HASH
 	help
 	  This option enables signature verification of FIT uImages,
 	  using a hash signed and verified using RSA. If