| Message ID | 20180502071735.32352-3-idosch@mellanox.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | mlxsw: Reject unsupported FIB configurations | expand |
On 5/2/18 1:17 AM, Ido Schimmel wrote: > We currently do not perform accounting in the driver and thus can't > reject routes before resources are exceeded. > > However, in order to make users aware of the fact that routes are no > longer offloaded we can return an error for routes configured after the > abort mechanism was triggered. > > Signed-off-by: Ido Schimmel <idosch@mellanox.com> > --- > drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > index added380e344..8028d221aece 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > @@ -5928,6 +5928,13 @@ static int mlxsw_sp_router_fib_event(struct notifier_block *nb, > router->mlxsw_sp); > if (!err || info->extack) > return notifier_from_errno(err); > + break; > + case FIB_EVENT_ENTRY_ADD: > + if (router->aborted) { > + NL_SET_ERR_MSG_MOD(info->extack, "FIB offload was aborted. Not configuring route"); > + return notifier_from_errno(-EINVAL); > + } > + break; > } > > fib_work = kzalloc(sizeof(*fib_work), GFP_ATOMIC); > Reasonable next step. Acked-by: David Ahern <dsahern@gmail.com>
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c index added380e344..8028d221aece 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c @@ -5928,6 +5928,13 @@ static int mlxsw_sp_router_fib_event(struct notifier_block *nb, router->mlxsw_sp); if (!err || info->extack) return notifier_from_errno(err); + break; + case FIB_EVENT_ENTRY_ADD: + if (router->aborted) { + NL_SET_ERR_MSG_MOD(info->extack, "FIB offload was aborted. Not configuring route"); + return notifier_from_errno(-EINVAL); + } + break; } fib_work = kzalloc(sizeof(*fib_work), GFP_ATOMIC);
We currently do not perform accounting in the driver and thus can't reject routes before resources are exceeded. However, in order to make users aware of the fact that routes are no longer offloaded we can return an error for routes configured after the abort mechanism was triggered. Signed-off-by: Ido Schimmel <idosch@mellanox.com> --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 7 +++++++ 1 file changed, 7 insertions(+)