From patchwork Wed May 2 07:17:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 907349 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="xgV+o385"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40bV4h4KgXz9s0n for ; Wed, 2 May 2018 17:18:44 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751137AbeEBHSm (ORCPT ); Wed, 2 May 2018 03:18:42 -0400 Received: from mail-db5eur01on0058.outbound.protection.outlook.com ([104.47.2.58]:50544 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751069AbeEBHSf (ORCPT ); Wed, 2 May 2018 03:18:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=nRBUrmi6q8+wBKz1M4d4u6hmcAuAxSa/g+ETNjJFFSY=; b=xgV+o385tbtl2tn7dDYkB5L/sEKzZI5jx3ygOiIz4OGu/P05nVc4OvndyMA7xuDl3b8vftySOE9bDDMME/uTJ+0aDP5jwmbDYvYGpON1BSuql1DqqxFls+q+3nEJ/wRbyt/VzXcZX3O34yQc97FzhBYGfjsmdSZXgrzAVu1AFTU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; Received: from splinter.mtl.com (193.47.165.251) by VI1PR0501MB2336.eurprd05.prod.outlook.com (2603:10a6:800:2c::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.715.22; Wed, 2 May 2018 07:18:30 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, jiri@mellanox.com, dsahern@gmail.com, mlxsw@mellanox.com, Ido Schimmel Subject: [PATCH net-next v2 2/2] mlxsw: spectrum_router: Return an error for routes added after abort Date: Wed, 2 May 2018 10:17:35 +0300 Message-Id: <20180502071735.32352-3-idosch@mellanox.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180502071735.32352-1-idosch@mellanox.com> References: <20180502071735.32352-1-idosch@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: LNXP265CA0007.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::19) To VI1PR0501MB2336.eurprd05.prod.outlook.com (2603:10a6:800:2c::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2336; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2336; 3:ZjJJX8e63YeBbvqTDUSKlwJ2VqdWhAI00GT7qhBIpqdV76DVix1sLrrgb34MkJDSuCdHJtiBZIu58qt0XqwOwvr5uF0wxqOhlJq8NE4pU3Ru3c06NN8p45Kco7RNBA/f/kDamBKxuBQ56bcPdNJeLsGXf08sW4RWZi98oxU6oOUGPN1FTqU3UXsXQE7lUTOeIk3ZdYwx1+pyEQm/yZFFPJQLrq640ChOQjKLPS45f+ZDime4xxhpp2yTMzdG5t7N; 25:fT5/+jRvqMZdW2sX7xbsbbYshm26HZLDBc+U334nQ2auevZU8NSgZC7hFW69TOKbBk1UufXzkskOR2Oz+BOXAqCCKn+ICUaBQWcYosqRsJ/Z4uuqbmIpdQsuPnENcfzfVRL+fQEfJ9pUirYCyNvPtvVyihg7XGqjoI5w3cFa0yLMKtFXdWOrBLcrFEgzG9jpNFdfWKTePfZ9sAVEbWAhFJi/Ph1D/Y1zIGpM777zkVnBvSg+8TiDm9GOyOSOyZaQ5Gcl/1ozr6sc3kqXJJc5vqNb7aiLRMbZBIEK+HBDXfiCVC8qaj/QDUUMWb2xXodM7Sp/FHM5B8ThvrSJUfiq+Q==; 31:QLuQ/naQ0jVmfw89Okj0/n1iQVCKEEWXxYvXiUIhYnnPNjAqFP73TjnYk/kwSH9Cf0Hux4ulSBobmg5/4AgspHsz9e5uHlu2eXnISYkwmOotklg5tkAUAi4D/yAXfHuJo8h1zjJ7HmN2NIXJEuwACvsROQmj6bgYxgbVaxp0VnBfWzftWRaWDGfg5k6SK3JIae2naoq5ah7UTzYBmPKWR72IhD8HLRUllh+Yi1lGnuc= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2336: X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2336; 20:/TCUYjl0hAp+IUxF17fJd6fmMNnOArQb1Q2eAEyvIiCb8HBHQ4gWM5WIkvpFoonpxIGXov+rDdjSY3mVj6L8a/9KMVZ7j6CmT2e9HELrXii31nPmiG8JU+FgQGZiKgrV+GR/iUoUhSb1imy3OW/CZxlceqGizkKx/CPUWirCQd0nDB7lBx21MK1OAhTKuF3Nsaq/xA7IdsmFh21GVYr6bq9KClLkjBDWFjJPoqYNzi73cLc0LS8h0QsMPq4UZrsV2dDfcuqJce1bdVLlFM9QTmSTSub0/AFfCmvbZzSAz5NRs+uAD9TqKsVqgSsYevxD2ezOdkcHK0o2RAAzUE7FLELTeP23r39KBtnUoS4J5KDFyYx0rh84gMTBSGjmzOLb11781wg31lU5imYnVUxV9rTbfr7+oW0+mkOjHcxbeXEpWg6L5K7cpnlgNxs69tCWRvl+1hsDfgUecnBzmthluZivnXlNkp2sIQUwupRpeU+f/QYmNJK+pUFjj6ZGgaJI; 4:F/L4/ErZea2Vm6LeOG/Y+TDSfSxEAhEMO6p7DJcXAmftiSSNbANkqV3JAQSHIuwKTyTnRnJ9Yoz4cImXJU14UZb0qDLyOnZNkHlrw2aeobenbzrk2rBP4y27b+wB/TGYMLjS8Jd8zUBhAsbFNpAqUXRJmAOL47m29uIlYUCS32MdWcXD7x2cVVQK5h1TRq9jQWE3jxLJZeD8cvGgLsGnOMisRwgUsnztuqjC3yHBsq1W9ptkrFWeGfMep+y0SnD8Org6MZYQ3dTbHCgPfZxP4g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(6041310)(20161123558120)(20161123560045)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:VI1PR0501MB2336; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2336; X-Forefront-PRVS: 06607E485E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(396003)(366004)(39380400002)(39860400002)(189003)(199004)(53416004)(486006)(5660300001)(97736004)(105586002)(2361001)(68736007)(50466002)(16526019)(48376002)(476003)(11346002)(106356001)(2616005)(36756003)(25786009)(478600001)(66066001)(47776003)(305945005)(956004)(2351001)(446003)(316002)(16586007)(8676002)(26005)(6506007)(6486002)(7736002)(186003)(86362001)(6916009)(6512007)(52116002)(81156014)(107886003)(50226002)(76176011)(6116002)(59450400001)(39060400002)(3846002)(4326008)(386003)(53936002)(1076002)(8936002)(2906002)(81166006)(51416003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2336; H:splinter.mtl.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2336; 23:3SV02I2TBO6iEVgNqvb7ti8OfkUT5w78K0BQys6s1rCVgRqgBezCUtDzgbqy6zrTjKI+fbdlnypE20xnMCggBY/7UxXJ8NFcT1K48+ABtdLTT2z7afl2gymOc8ZtlTemeL/m4JZ/YwNzdPZ0OisITvrUAGmH9yC853pnNphsDYnvP/B8BjUawx5Ahsh4O1r+W6l909M2EiWXxNXdQmXqUjyzR7GLIz2ozH/76tBcjwx9B2j4AK4EDVclCeLCwpUwaKlzEqfb5Apa+EysiEZ2UcpXT/T9ZzkGZMCJq/KnUtWMT0cxWjYLIjq/wFxnB1r8Wm8c4aNf/zHsdgXfJi5E9e1ksEJs5DBvjAAFEjUV5qkKQeanxjtWDh/br5A4xAoj+fFenewFKZ+2ISPHLDfqXfogutRNF/2/Oqfzg5We+OrKL/PTZhO5Bw74Ytlb1gZvDF4GczkZgNOuC4Wr/Qxsz5mPyZXLV7nHTYoVC13Nr7E0ft27FyeQyrmZswY3wJ6dBepLioe9/FlH8UNIr0kZ3T7zANPU6ggaJYZytRs/tZEktOPvrFjWIProxzbLtBidKlzxZM8f1KB2Wba0SZObO0MbKINH1Xq+joY7hW/LpsBaVU6r6BTjQkzYYEKuROrSHZh4qujOX1bGrEk5a+0ZwywjSPruRKvLcOp/xaBv7PwsJcGM2gDFNIztodn5HkCEsez3DHOOlmfb6aSKvPXq0Mej8cjpiK11n8KHOxvmQ8sjAKrbQg1B4nfAXO35t7zOuUT/rRbi+jEaQgniHKOxbOBQo+yj4kxFUqVza96ADTmHSQcHQtCCtDKJnB2ol8fF9XtInK9PpKzJDCzRjfTTwkRB1Ty8R3rzQvnKIuaZzC0WRGE5l9obANnAe7tM3gq2Sip8+QSmkn6pX1s/kjBiLpovba3Y2gMbGyuxzE1uFdgN+tbbRoeORsC9uWz/4tyrMr2f3mXuRW1yB5z03ka6/FNwAt5AEsdw/q/PX0eYx+PSdSElVWNzDW8fYFRAsRVdEC4xBsUr3RvhIbSdKwCMBpnoX+gEIjLUzf4KE+0OOiK2DgtOMSetj3mx3gzBgCZP4o8H4h+VS+hcz/YMuinsiEVz0U78o78YM4WxTQDi/97FyiY2qURIjqfJeVgJzTkN7wr4KGEz+i09Zm8IDKxFbPCMEogUPqj1fGwGPEvANGAHp5DjEJ7YuDrsbFoWBDFuye368eoFFrhJozOwq2a94D2H9egU43QvbE8anKolQyiBx+ZJx0zMVNYGU0DDdONb5YBGjo++ROOXtNK4yFN1sw/3ElFVbjvn/mecBysZwPs= X-Microsoft-Antispam-Message-Info: D+KezrpFkeP0s1IElyiOBKhGZkJODkN+KJQo4wKpUnaevfEMU7CDoQjxCB/ARDi+H6mmb4Gd7013lDUX7ePTlvTwihn5aXkEufIjVwpxUJ1vPzcc3GS1WF4HoowpACYbcqNpm4ZT+cIVtBA9P6SDotL+Dlyf+fwVYQ2ic4gdVqFKL/dzrs0W2UNURyFirgc7 X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2336; 6:mVek4/mWGCB2e4YDlQ+pXQMH4DoJWtbKaGZb3ejftuWBMMwriLn+1TRNpzkqDm9pLsAo8L+slRTnEhg95m3OqqWNY/tBNzliibVwrxhOOePP65ELodbFTft6Lf4SKcTGOqV+QNaoE+Ki2tKXHYrD+GO5doFagC5ddgjkforxcdwZqokjwEU63kLxkNzH3lYSGVvpRjHHIlPKUhK1cZi3l1AEJaxHd8kortKs0C/419rHzPcdtQrHQDV/jnB6n6adCNjPofxanXTkezjlWVLSn0sYQrqlPcezgLi4ftFFpwBRDVBQS+iGI/dfQX+Pg1Mfpq65gj/sYvGXq7FNNteFLz57gEEbQW2H59oe1nMF9VgwUA/lu6TrcqvyiCL81iWvTZavXxC1p8nPNQdpOAuvpxS6u3DdPgRV2Y7OAzcprZ9XfWD2UUeNvd2ZV/+gDIZ0KPHNU41VTkzXEqfmftkgvw==; 5:1ZVFypPHGM9XZTLti8HzJXkiShUvZMrBR6QQOIIGl4R6U5evUl6eBGeIwec++8D+SZAVW744YZRUCfKSalU9ZIqNQMb0Dxl5we0KREQ3JObIb5X+eTP8wbTOC8zATKIEAORVYNwazC9V6h+PRuAsH7+2nSZjMxxSG8t1HNfvW+c=; 24:ybfpaeGYR8XYzYyZVDT3VpDsUsjO43xGUmvDOKGVxFtlVwb72UyL8YRIKdr6HI7ykneYuzKk58RYawCBnTkew8ml+cU2R0o1+65xBAhxQVo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2336; 7:IxZaUB/QlZW/trz/wrlk8A7d3kkNwFV5EgfGD/zBgyi6kWyiGfxh4zeJZYrgEzIybn0kv34GgczcctaVWye/W29zPnkLdXJE90yC7iHXuuMKe6X/VgEbe7/9MfcXfYDflaK6MOVR3OuTJe3CtkmuvwBxFFbjuSxnAgdOfzU83q7yE8iQGJqkq42470n7SS0KW6iEcJ5F1Q9no31xxD7dHOkV9Ci/M8oO0Ec1ZSeh4iJU5q6c2KtAvL9jvvUfc7fs X-MS-Office365-Filtering-Correlation-Id: 5add7d02-0065-4b2e-cf11-08d5affce84b X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2018 07:18:30.0132 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5add7d02-0065-4b2e-cf11-08d5affce84b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2336 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We currently do not perform accounting in the driver and thus can't reject routes before resources are exceeded. However, in order to make users aware of the fact that routes are no longer offloaded we can return an error for routes configured after the abort mechanism was triggered. Signed-off-by: Ido Schimmel Acked-by: David Ahern --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c index added380e344..8028d221aece 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c @@ -5928,6 +5928,13 @@ static int mlxsw_sp_router_fib_event(struct notifier_block *nb, router->mlxsw_sp); if (!err || info->extack) return notifier_from_errno(err); + break; + case FIB_EVENT_ENTRY_ADD: + if (router->aborted) { + NL_SET_ERR_MSG_MOD(info->extack, "FIB offload was aborted. Not configuring route"); + return notifier_from_errno(-EINVAL); + } + break; } fib_work = kzalloc(sizeof(*fib_work), GFP_ATOMIC);