| Message ID | 1524404868-28053-1-git-send-email-trini@konsulko.com |
|---|---|
| State | Accepted |
| Commit | 751641814c1db245695dd8f40e9c811320e69f79 |
| Delegated to: | Anatolij Gustschin |
| Headers | show |
| Series | [U-Boot] video-uclass: Fix logical-not-parentheses warning | expand |
On Sun, 22 Apr 2018 09:47:48 -0400 Tom Rini trini@konsulko.com wrote: > With clang-4.0 and later we see: > warning: logical not is only applied to the left hand side of this bitwise > operator [-Wlogical-not-parentheses] > if ((!gd->flags & GD_FLG_RELOC)) > ^ ~ > > And while the compiler suggests adding parenthesis around gd->flags, a > reading of the code says that we want to know when GD_FLG_RELOC is not > set and then return. > > Cc: Simon Glass <sjg@chromium.org> > Cc: Anatolij Gustschin <agust@denx.de> > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > drivers/video/video-uclass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-video/master, thanks! -- Anatolij
diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c index b5bb8e0efde5..93fdc6828b1e 100644 --- a/drivers/video/video-uclass.c +++ b/drivers/video/video-uclass.c @@ -272,7 +272,7 @@ static int video_post_bind(struct udevice *dev) ulong size; /* Before relocation there is nothing to do here */ - if ((!gd->flags & GD_FLG_RELOC)) + if (!(gd->flags & GD_FLG_RELOC)) return 0; size = alloc_fb(dev, &addr); if (addr < gd->video_bottom) {
With clang-4.0 and later we see: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses] if ((!gd->flags & GD_FLG_RELOC)) ^ ~ And while the compiler suggests adding parenthesis around gd->flags, a reading of the code says that we want to know when GD_FLG_RELOC is not set and then return. Cc: Simon Glass <sjg@chromium.org> Cc: Anatolij Gustschin <agust@denx.de> Signed-off-by: Tom Rini <trini@konsulko.com> --- drivers/video/video-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)