| Message ID | 1522963284-32258-1-git-send-email-joshua.henderson@microchip.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/2] configs/at91sam9g20dfc: add ubifs target filesystem | expand |
Hello, On Thu, 5 Apr 2018 14:21:23 -0700, Joshua Henderson wrote: > # Filesystem > BR2_TARGET_ROOTFS_TAR=y > +BR2_TARGET_ROOTFS_UBI=y > +BR2_TARGET_ROOTFS_UBIFS_MAXLEBCNT=2047 I guess these are the two options left after doing a "make savedefconfig". However, I would be more comfortable if you made explicit the other important options about UBI, like it is the case in other Atmel defconfigs: BR2_TARGET_ROOTFS_UBIFS=y BR2_TARGET_ROOTFS_UBIFS_LEBSIZE=0x3e000 BR2_TARGET_ROOTFS_UBIFS_MINIOSIZE=0x1000 BR2_TARGET_ROOTFS_UBIFS_MAXLEBCNT=2082 BR2_TARGET_ROOTFS_UBI=y BR2_TARGET_ROOTFS_UBI_PEBSIZE=0x40000 BR2_TARGET_ROOTFS_UBI_SUBSIZE=0 Thanks a lot! Thomas
On 04/06/2018 12:36 PM, Thomas Petazzoni wrote: > Hello, > > On Thu, 5 Apr 2018 14:21:23 -0700, Joshua Henderson wrote: > >> # Filesystem >> BR2_TARGET_ROOTFS_TAR=y >> +BR2_TARGET_ROOTFS_UBI=y >> +BR2_TARGET_ROOTFS_UBIFS_MAXLEBCNT=2047 > > I guess these are the two options left after doing a "make > savedefconfig". However, I would be more comfortable if you made > explicit the other important options about UBI, like it is the case in > other Atmel defconfigs: Yes, that's what's left after a savedefconfig. v2 patch sent with options added. Supports a good, known working defconfig after all. Hard to find consensus on this as the defconfigs are all over the place on whether or not to include these options. Josh > > BR2_TARGET_ROOTFS_UBIFS=y > BR2_TARGET_ROOTFS_UBIFS_LEBSIZE=0x3e000 > BR2_TARGET_ROOTFS_UBIFS_MINIOSIZE=0x1000 > BR2_TARGET_ROOTFS_UBIFS_MAXLEBCNT=2082 > BR2_TARGET_ROOTFS_UBI=y > BR2_TARGET_ROOTFS_UBI_PEBSIZE=0x40000 > BR2_TARGET_ROOTFS_UBI_SUBSIZE=0 > > Thanks a lot! > > Thomas >
diff --git a/configs/at91sam9g20dfc_defconfig b/configs/at91sam9g20dfc_defconfig index 0824868..f555b60 100644 --- a/configs/at91sam9g20dfc_defconfig +++ b/configs/at91sam9g20dfc_defconfig @@ -15,6 +15,8 @@ BR2_LINUX_KERNEL_INTREE_DTS_NAME="at91sam9g20ek" # Filesystem BR2_TARGET_ROOTFS_TAR=y +BR2_TARGET_ROOTFS_UBI=y +BR2_TARGET_ROOTFS_UBIFS_MAXLEBCNT=2047 # Bootloaders BR2_TARGET_AT91BOOTSTRAP3=y
This is a required component to complete the configuration. It also makes sense to add ubifs so that this board can be flashed with the board/atmel/flasher.sh script. Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com> --- configs/at91sam9g20dfc_defconfig | 2 ++ 1 file changed, 2 insertions(+)