diff mbox series

[01/23] support/config-fragments/autobuild: remove Blackfin configuration

Message ID 20180405195037.32641-2-thomas.petazzoni@bootlin.com
State Accepted
Headers show
Series Remove Blackfin architecture | expand

Commit Message

Thomas Petazzoni April 5, 2018, 7:50 p.m. UTC
In preparation for the removal of the Blackfin architecture, drop the
autobuilder toolchain configuration that was testing Blackfin.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 support/config-fragments/autobuild/br-bfin-full.config   | 12 ------------
 support/config-fragments/autobuild/toolchain-configs.csv |  3 ---
 utils/test-pkg                                           |  2 +-
 3 files changed, 1 insertion(+), 16 deletions(-)
 delete mode 100644 support/config-fragments/autobuild/br-bfin-full.config

Comments

Yann E. MORIN April 5, 2018, 8:29 p.m. UTC | #1
Thomas, All,

On 2018-04-05 21:50 +0200, Thomas Petazzoni spake thusly:
> In preparation for the removal of the Blackfin architecture, drop the
> autobuilder toolchain configuration that was testing Blackfin.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
[--SNIP--]
> diff --git a/support/config-fragments/autobuild/toolchain-configs.csv b/support/config-fragments/autobuild/toolchain-configs.csv
> index 1bce7ac577..64abfb3fd4 100644
> --- a/support/config-fragments/autobuild/toolchain-configs.csv
> +++ b/support/config-fragments/autobuild/toolchain-configs.csv
> @@ -15,9 +15,6 @@ support/config-fragments/autobuild/br-arm-cortex-m4-full.config,x86_64
>  # Test a musl toolchain
>  support/config-fragments/autobuild/br-x86-64-musl.config,x86_64
>  
> -# Test a noMMU toolchain with dynamic library support
> -support/config-fragments/autobuild/br-bfin-full.config,x86_64

Do we plan on adding back another noMMU target with dynamic library
support instead of that one?

>  # Test a MMU toolchain without dynamic library support
>  support/config-fragments/autobuild/br-arm-full-static.config,x86_64
>  
> diff --git a/utils/test-pkg b/utils/test-pkg
> index 2e069b6005..54951276fa 100755
> --- a/utils/test-pkg
> +++ b/utils/test-pkg
> @@ -75,7 +75,7 @@ main() {
>      # Default mode is to test the N first toolchains, which have been
>      # chosen to be a good selection of toolchains.
>      if [ ${mode} -eq 0 ] ; then
> -        number=7
> +        number=6

Otherwise, toolchain-configs.csv is only used in genrandconfig, and that
one does not care about the number of "default" toolchains.

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

>      elif [ ${mode} -gt 1 ] ; then
>          printf "error: --all, --number and --random are mutually exclusive\n" >&2; exit 1
>      fi
> -- 
> 2.14.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni April 5, 2018, 8:38 p.m. UTC | #2
Hello,

On Thu, 5 Apr 2018 22:29:33 +0200, Yann E. MORIN wrote:

> > -# Test a noMMU toolchain with dynamic library support
> > -support/config-fragments/autobuild/br-bfin-full.config,x86_64  
> 
> Do we plan on adding back another noMMU target with dynamic library
> support instead of that one?

We don't have any other noMMU target that supports dynamic library
support currently. FDPIC support on ARM is being worked on upstream,
but I don't think it's ready yet.

Otherwise, there is FDPIC support for SH2, but we don't have support
for this either.

Best regards,

Thomas
Yann E. MORIN April 5, 2018, 8:47 p.m. UTC | #3
Thomas, All,

On 2018-04-05 22:38 +0200, Thomas Petazzoni spake thusly:
> On Thu, 5 Apr 2018 22:29:33 +0200, Yann E. MORIN wrote:
> 
> > > -# Test a noMMU toolchain with dynamic library support
> > > -support/config-fragments/autobuild/br-bfin-full.config,x86_64  
> > 
> > Do we plan on adding back another noMMU target with dynamic library
> > support instead of that one?
> 
> We don't have any other noMMU target that supports dynamic library
> support currently. FDPIC support on ARM is being worked on upstream,
> but I don't think it's ready yet.

ACK.

> Otherwise, there is FDPIC support for SH2, but we don't have support
> for this either.

Do we really want to revive that? ;-)

Regards,
Yann E. MORIN.
diff mbox series

Patch

diff --git a/support/config-fragments/autobuild/br-bfin-full.config b/support/config-fragments/autobuild/br-bfin-full.config
deleted file mode 100644
index eeefcefbee..0000000000
--- a/support/config-fragments/autobuild/br-bfin-full.config
+++ /dev/null
@@ -1,12 +0,0 @@ 
-BR2_bfin=y
-BR2_bf512=y
-BR2_TOOLCHAIN_EXTERNAL=y
-BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
-BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
-BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.net/toolchains/tarballs/br-bfin-full-2017.11-rc1.tar.bz2"
-BR2_TOOLCHAIN_EXTERNAL_GCC_6=y
-BR2_TOOLCHAIN_EXTERNAL_HEADERS_4_13=y
-BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
-# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
-# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_NPTL is not set
-BR2_TOOLCHAIN_EXTERNAL_CXX=y
diff --git a/support/config-fragments/autobuild/toolchain-configs.csv b/support/config-fragments/autobuild/toolchain-configs.csv
index 1bce7ac577..64abfb3fd4 100644
--- a/support/config-fragments/autobuild/toolchain-configs.csv
+++ b/support/config-fragments/autobuild/toolchain-configs.csv
@@ -15,9 +15,6 @@  support/config-fragments/autobuild/br-arm-cortex-m4-full.config,x86_64
 # Test a musl toolchain
 support/config-fragments/autobuild/br-x86-64-musl.config,x86_64
 
-# Test a noMMU toolchain with dynamic library support
-support/config-fragments/autobuild/br-bfin-full.config,x86_64
-
 # Test a MMU toolchain without dynamic library support
 support/config-fragments/autobuild/br-arm-full-static.config,x86_64
 
diff --git a/utils/test-pkg b/utils/test-pkg
index 2e069b6005..54951276fa 100755
--- a/utils/test-pkg
+++ b/utils/test-pkg
@@ -75,7 +75,7 @@  main() {
     # Default mode is to test the N first toolchains, which have been
     # chosen to be a good selection of toolchains.
     if [ ${mode} -eq 0 ] ; then
-        number=7
+        number=6
     elif [ ${mode} -gt 1 ] ; then
         printf "error: --all, --number and --random are mutually exclusive\n" >&2; exit 1
     fi