diff mbox series

[v3,06/13] support/download: make sure the download folder is created

Message ID 20180331142407.9522-6-maxime.hadjinlian@gmail.com
State Superseded
Headers show
Series None | expand

Commit Message

Maxime Hadjinlian March 31, 2018, 2:24 p.m. UTC
At the moment, it means that we make sure that BR2_DL_DIR is created, in
the future, it will make sure that BR2_DL_DIR/PKG_NAME/ is created.

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 support/download/dl-wrapper | 1 +
 1 file changed, 1 insertion(+)

Comments

Yann E. MORIN April 1, 2018, 6:18 p.m. UTC | #1
Maxime, All,

On 2018-03-31 16:24 +0200, Maxime Hadjinlian spake thusly:
> At the moment, it means that we make sure that BR2_DL_DIR is created, in
> the future, it will make sure that BR2_DL_DIR/PKG_NAME/ is created.
> 
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
>  support/download/dl-wrapper | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/support/download/dl-wrapper b/support/download/dl-wrapper
> index 67e9742767..49caf3717b 100755
> --- a/support/download/dl-wrapper
> +++ b/support/download/dl-wrapper
> @@ -50,6 +50,7 @@ main() {
>      if [ -z "${output}" ]; then
>          error "no output specified, use -o\n"
>      fi
> +    mkdir -p "$(dirname "${output}")"

In a future oatch, when adding flock, you move that mkdir out of the
wrapper, upper to the DOWNLOAD macro. Why don't you do that right now,
instead?

Regards,
Yann E. MORIN.

>      # If the output file already exists and:
>      # - there's no .hash file: do not download it again and exit promptly
> -- 
> 2.16.2
>
diff mbox series

Patch

diff --git a/support/download/dl-wrapper b/support/download/dl-wrapper
index 67e9742767..49caf3717b 100755
--- a/support/download/dl-wrapper
+++ b/support/download/dl-wrapper
@@ -50,6 +50,7 @@  main() {
     if [ -z "${output}" ]; then
         error "no output specified, use -o\n"
     fi
+    mkdir -p "$(dirname "${output}")"
 
     # If the output file already exists and:
     # - there's no .hash file: do not download it again and exit promptly