diff mbox

[U-Boot] OSE support shouldnt be enabled by default

Message ID BANLkTik8fNz+M0ASdSXFfcahrNEAAjc7aw@mail.gmail.com
State Superseded
Delegated to: Wolfgang Denk
Headers show

Commit Message

Mike Frysinger April 1, 2011, 11:11 p.m. UTC
the commit below slipped in without me noticing ... could you please
revert the change to this header and only enable support for this OS
in whatever boards you're using ?  especially considering this OS only
works for specific setups (phones) and on few processors (ARM, PPC,
MIPS).
-mike

commit 3df61957938586c512c17e72d83551d190400981
Author: Torkel Lundgren <torkel.lundgren@enea.com>
Date:   Tue Sep 28 11:05:36 2010 +0200

    Add support for operating system OSE

    Add OSE as operating system for mkimage and bootm.

    Signed-off-by: Torkel Lundgren <torkel.lundgren@enea.com>

Comments

Wolfgang Denk May 12, 2011, 8:52 p.m. UTC | #1
Dear Torkel,

In message <BANLkTik8fNz+M0ASdSXFfcahrNEAAjc7aw@mail.gmail.com> Mike Frysinger wrote:
> the commit below slipped in without me noticing ... could you please
> revert the change to this header and only enable support for this OS
> in whatever boards you're using ?  especially considering this OS only
> works for specific setups (phones) and on few processors (ARM, PPC,
> MIPS).
> -mike
> 
> commit 3df61957938586c512c17e72d83551d190400981
> Author: Torkel Lundgren <torkel.lundgren@enea.com>
> Date:   Tue Sep 28 11:05:36 2010 +0200
> 
>     Add support for operating system OSE
> 
>     Add OSE as operating system for mkimage and bootm.
> 
>     Signed-off-by: Torkel Lundgren <torkel.lundgren@enea.com>
> 
> diff --git a/include/config_defaults.h b/include/config_defaults.h
> index 0337163..abdf3be 100644
> --- a/include/config_defaults.h
> +++ b/include/config_defaults.h
> @@ -12,6 +12,7 @@
>  /* Support bootm-ing different OSes */
>  #define CONFIG_BOOTM_LINUX 1
>  #define CONFIG_BOOTM_NETBSD 1
> +#define CONFIG_BOOTM_OSE 1
>  #define CONFIG_BOOTM_RTEMS 1
> 
>  #define CONFIG_GZIP 1


Please comment?

Best regards,

Wolfgang Denk
Mike Frysinger May 12, 2011, 9:39 p.m. UTC | #2
On Thursday, May 12, 2011 16:52:47 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > the commit below slipped in without me noticing ... could you please
> > revert the change to this header and only enable support for this OS
> > in whatever boards you're using ?  especially considering this OS only
> > works for specific setups (phones) and on few processors (ARM, PPC,
> > MIPS).
> > -mike
> > 
> > commit 3df61957938586c512c17e72d83551d190400981
> > Author: Torkel Lundgren <torkel.lundgren@enea.com>
> > Date:   Tue Sep 28 11:05:36 2010 +0200
> > 
> >     Add support for operating system OSE
> >     
> >     Add OSE as operating system for mkimage and bootm.
> >     
> >     Signed-off-by: Torkel Lundgren <torkel.lundgren@enea.com>
> > 
> > diff --git a/include/config_defaults.h b/include/config_defaults.h
> > index 0337163..abdf3be 100644
> > --- a/include/config_defaults.h
> > +++ b/include/config_defaults.h
> > @@ -12,6 +12,7 @@
> > 
> >  /* Support bootm-ing different OSes */
> >  #define CONFIG_BOOTM_LINUX 1
> >  #define CONFIG_BOOTM_NETBSD 1
> > 
> > +#define CONFIG_BOOTM_OSE 1
> > 
> >  #define CONFIG_BOOTM_RTEMS 1
> >  
> >  #define CONFIG_GZIP 1
> 
> Please comment?

i did send out an actual patch to revert this, and you picked it up.  Torkel 
didnt comment on that either though (he was cc-ed) ...

see commit 0aca983e058d6205962b3c09cb6ece520b6ea218
-mike
Wolfgang Denk May 12, 2011, 9:59 p.m. UTC | #3
Dear Mike Frysinger,

In message <201105121739.51157.vapier@gentoo.org> you wrote:
>
> i did send out an actual patch to revert this, and you picked it up.  Torkel 
> didnt comment on that either though (he was cc-ed) ...
>
> see commit 0aca983e058d6205962b3c09cb6ece520b6ea218

Ah, thanks.  Forgot to unmakr this, then.

Best regards,

Wolfgang Denk
diff mbox

Patch

diff --git a/include/config_defaults.h b/include/config_defaults.h
index 0337163..abdf3be 100644
--- a/include/config_defaults.h
+++ b/include/config_defaults.h
@@ -12,6 +12,7 @@ 
 /* Support bootm-ing different OSes */
 #define CONFIG_BOOTM_LINUX 1
 #define CONFIG_BOOTM_NETBSD 1
+#define CONFIG_BOOTM_OSE 1
 #define CONFIG_BOOTM_RTEMS 1

 #define CONFIG_GZIP 1