| Message ID | 20180318111055.10589-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Commit | 2ebc80e83c51d56d17708eec40aedbdf2904460c |
| Delegated to: | Philipp Tomsich |
| Headers | show |
| Series | [U-Boot,RFC,1/1] driver: ram: rockchip: rk3399: missing counter increment | expand |
> If we want to check the duration we need to increment the counter. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > I do not have the hardware for testing. But the current coding is > obviously flawed. > --- > drivers/ram/rockchip/sdram_rk3399.c | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> If we want to check the duration we need to increment the counter. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > I do not have the hardware for testing. But the current coding is > obviously flawed. > --- > drivers/ram/rockchip/sdram_rk3399.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> If we want to check the duration we need to increment the counter. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > --- > I do not have the hardware for testing. But the current coding is > obviously flawed. > --- > drivers/ram/rockchip/sdram_rk3399.c | 1 + > 1 file changed, 1 insertion(+) > Applied to u-boot-rockchip, thanks!
diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c index 76c1fe80a7..5cb470c209 100644 --- a/drivers/ram/rockchip/sdram_rk3399.c +++ b/drivers/ram/rockchip/sdram_rk3399.c @@ -1015,6 +1015,7 @@ static int switch_to_phy_index1(struct dram_info *dram, writel(RK_CLRSETBITS(1 << 1, 1 << 1), &dram->cic->cic_ctrl0); while (!(readl(&dram->cic->cic_status0) & (1 << 0))) { mdelay(10); + i++; if (i > 10) { debug("index1 frequency done overtime\n"); return -ETIME;
If we want to check the duration we need to increment the counter. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- I do not have the hardware for testing. But the current coding is obviously flawed. --- drivers/ram/rockchip/sdram_rk3399.c | 1 + 1 file changed, 1 insertion(+)