diff mbox series

[1/1] fbgrab: Fix some problems in the patch metadata

Message ID 1520505753-13884-1-git-send-email-timo.ketola@exertus.fi
State Accepted
Commit 1a0b4b2be2c76b836f4461fcf59f5e95dcd8549b
Headers show
Series [1/1] fbgrab: Fix some problems in the patch metadata | expand

Commit Message

Timo Ketola March 8, 2018, 10:42 a.m. UTC
The patch description was missing Upstream-Status tag. It was given in the
commit which added this patch but not in the patch itself as should be.

Signed-off-by tag accidentally didn't follow the usual format.

Signed-off-by: Timo Ketola <timo.ketola@exertus.fi>
---
 package/fbgrab/0100-fix-pixfmt-report.patch | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Adrian Perez de Castro March 8, 2018, 11:43 a.m. UTC | #1
On Thu,  8 Mar 2018 12:42:33 +0200, Timo Ketola <timo.ketola@exertus.fi> wrote:
> The patch description was missing Upstream-Status tag. It was given in the
> commit which added this patch but not in the patch itself as should be.
> 
> Signed-off-by tag accidentally didn't follow the usual format.
> 
> Signed-off-by: Timo Ketola <timo.ketola@exertus.fi>

Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>

> ---
>  package/fbgrab/0100-fix-pixfmt-report.patch | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/fbgrab/0100-fix-pixfmt-report.patch b/package/fbgrab/0100-fix-pixfmt-report.patch
> index 18bcf96..8cff7ef 100644
> --- a/package/fbgrab/0100-fix-pixfmt-report.patch
> +++ b/package/fbgrab/0100-fix-pixfmt-report.patch
> @@ -4,7 +4,9 @@ When fbgrab tells about the framebuffer pixel format, blue and green
>  are accidentally swapped in 'length' and 'msb_right' columns. Let's
>  order everything as RGB.
>  
> -Signed-off-by timo.ketola@exertus.fi
> +Upstream-Status: Submitted [Gunnar Monell <gmo@linux.nu>]
> +
> +Signed-off-by: Timo Ketola <timo.ketola@exertus.fi>
>  
>  diff -u a/fbgrab.c b/fbgrab.c
>  --- a/fbgrab.c	2018-03-07 11:42:04.739250433 +0200
> -- 
> 2.7.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
Peter Korsgaard March 9, 2018, 9:37 p.m. UTC | #2
>>>>> "Timo" == Timo Ketola <timo.ketola@exertus.fi> writes:

 > The patch description was missing Upstream-Status tag. It was given in the
 > commit which added this patch but not in the patch itself as should be.

 > Signed-off-by tag accidentally didn't follow the usual format.

 > Signed-off-by: Timo Ketola <timo.ketola@exertus.fi>

Committed, thanks.
Peter Korsgaard March 30, 2018, 9:23 p.m. UTC | #3
>>>>> "Timo" == Timo Ketola <timo.ketola@exertus.fi> writes:

 > The patch description was missing Upstream-Status tag. It was given in the
 > commit which added this patch but not in the patch itself as should be.

 > Signed-off-by tag accidentally didn't follow the usual format.

 > Signed-off-by: Timo Ketola <timo.ketola@exertus.fi>

Committed to 2018.02.x, thanks.
diff mbox series

Patch

diff --git a/package/fbgrab/0100-fix-pixfmt-report.patch b/package/fbgrab/0100-fix-pixfmt-report.patch
index 18bcf96..8cff7ef 100644
--- a/package/fbgrab/0100-fix-pixfmt-report.patch
+++ b/package/fbgrab/0100-fix-pixfmt-report.patch
@@ -4,7 +4,9 @@  When fbgrab tells about the framebuffer pixel format, blue and green
 are accidentally swapped in 'length' and 'msb_right' columns. Let's
 order everything as RGB.
 
-Signed-off-by timo.ketola@exertus.fi
+Upstream-Status: Submitted [Gunnar Monell <gmo@linux.nu>]
+
+Signed-off-by: Timo Ketola <timo.ketola@exertus.fi>
 
 diff -u a/fbgrab.c b/fbgrab.c
 --- a/fbgrab.c	2018-03-07 11:42:04.739250433 +0200