| Message ID | 20180215042900.16078-17-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | hw: use the BYTE-based definitions when useful | expand |
On 02/14/2018 10:28 PM, Philippe Mathieu-Daudé wrote: > It ease code review, unit is explicit. I noticed it here, then see it occurs throughout the series: s/ease/eases/ in the commit message. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/block/tc58128.c | 2 +- > hw/sh4/r2d.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >
On Thu, Feb 15, 2018 at 11:43 AM, Eric Blake <eblake@redhat.com> wrote: > On 02/14/2018 10:28 PM, Philippe Mathieu-Daudé wrote: >> >> It ease code review, unit is explicit. > > > I noticed it here, then see it occurs throughout the series: > s/ease/eases/ in the commit message. Oops, thanks Eric I'll fix in respin. >> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> --- >> hw/block/tc58128.c | 2 +- >> hw/sh4/r2d.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org
diff --git a/hw/block/tc58128.c b/hw/block/tc58128.c index 1d9f7ee000..3e658d509f 100644 --- a/hw/block/tc58128.c +++ b/hw/block/tc58128.c @@ -26,7 +26,7 @@ typedef struct { static tc58128_dev tc58128_devs[2]; -#define FLASH_SIZE (16*1024*1024) +#define FLASH_SIZE (16 * M_BYTE) static void init_dev(tc58128_dev * dev, const char *filename) { diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c index 458ed83297..720bd6ad04 100644 --- a/hw/sh4/r2d.c +++ b/hw/sh4/r2d.c @@ -292,7 +292,7 @@ static void r2d_init(MachineState *machine) dinfo = drive_get(IF_PFLASH, 0, 0); pflash_cfi02_register(0x0, NULL, "r2d.flash", FLASH_SIZE, dinfo ? blk_by_legacy_dinfo(dinfo) : NULL, - (16 * 1024), FLASH_SIZE >> 16, + 16 * K_BYTE, FLASH_SIZE >> 16, 1, 4, 0x0000, 0x0000, 0x0000, 0x0000, 0x555, 0x2aa, 0);
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/block/tc58128.c | 2 +- hw/sh4/r2d.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)