| Message ID | CABKM0pACrjZbxKh4a2U4=_75kwAKjsONLNujn6KWwRrhhcdqOw@mail.gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot] Make cmd_get_data_size() a dependency of setexpr | expand |
On Wed, Feb 07, 2018 at 03:31:02PM +0800, qlb1234 wrote: > This commit broke the command setexpr. > > http://git.denx.de/?p=u-boot.git;a=commit;h=6f62d7c4f7a2242a76e19b09dccca6f68776e788 > > setexpr uses cmd_get_data_size(). If none of I2C, ITEST or PCI is > chosen, setexpr will fail to be built. > > --- include/command.h > +++ include/command.h > @@ -80,13 +80,14 @@ > * void function (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]); > */ > > #if defined(CONFIG_CMD_MEMORY) || \ > defined(CONFIG_CMD_I2C) || \ > defined(CONFIG_CMD_ITEST) || \ > - defined(CONFIG_CMD_PCI) > + defined(CONFIG_CMD_PCI) || \ > + defined(CONFIG_CMD_SETEXPR) > #define CMD_DATA_SIZE > extern int cmd_get_data_size(char* arg, int default_size); > #endif This seems like a reasonable fix and patch, thanks. However, you need to repost this with your real name used as the author and a signed-off-by line, thanks!
Hi Tom, I added the sign-off-by line. Regards, Wesley From bf3d846d800ac45714b8c2f9a15964e9df650bc2 Mon Sep 17 00:00:00 2001 From: Wesley Chan <wesley.chan> Date: Wed, 2 May 2018 16:24:40 +0800 Subject: [PATCH] setexpr: This commit broke it: 6f62d7. Solution: Make cmd_get_data_size() a dependency of setexpr. Signed-off-by: Wesley Chan <wesley.chan> --- include/command.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/command.h b/include/command.h index 56499b8ad5..34c75af445 100644 --- a/include/command.h +++ b/include/command.h @@ -83,7 +83,8 @@ int cmd_process_error(cmd_tbl_t *cmdtp, int err); #if defined(CONFIG_CMD_MEMORY) || \ defined(CONFIG_CMD_I2C) || \ defined(CONFIG_CMD_ITEST) || \ - defined(CONFIG_CMD_PCI) + defined(CONFIG_CMD_PCI) || \ + defined(CONFIG_CMD_SETEXPR) #define CMD_DATA_SIZE extern int cmd_get_data_size(char* arg, int default_size); #endif
--- include/command.h +++ include/command.h @@ -80,13 +80,14 @@ * void function (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]); */ #if defined(CONFIG_CMD_MEMORY) || \ defined(CONFIG_CMD_I2C) || \ defined(CONFIG_CMD_ITEST) || \ - defined(CONFIG_CMD_PCI) + defined(CONFIG_CMD_PCI) || \ + defined(CONFIG_CMD_SETEXPR) #define CMD_DATA_SIZE extern int cmd_get_data_size(char* arg, int default_size); #endif #ifdef CONFIG_CMD_BOOTD extern int do_bootd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]);