diff mbox series

[v3,3/3] autobuilder: failure reason use build-time.log

Message ID 20180202205713.27191-5-matthew.weber@rockwellcollins.com
State Accepted
Headers show
Series autobuild: timeout and reporting cleanup | expand

Commit Message

Matt Weber Feb. 2, 2018, 8:57 p.m. UTC 
When the make output doesn't parse to provide a result and unknown
is assumed, check the build-time.log and see if the last line was
a <stamp>:start:<pkgname>.  IF so, use this pkgname instead
before declaring unknown.

This was tested against the ti-cgt-pru hang.
http://autobuild.buildroot.net/results/60e/60e11a3bb90b9f41259e4a970081b72d8b8d100b//

Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
---
 web/import.inc.php | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Thomas Petazzoni Feb. 6, 2018, 2:04 p.m. UTC | #1 
Hello,

On Fri,  2 Feb 2018 14:57:13 -0600, Matt Weber wrote:

> +	  exec("tail -1 " . $thisbuildfinaldir . "build-time.log | grep :start: | cut -d':' -f4", $tmp);
> +	  if (trim($tmp[0]))
> +	    print "Using build-time.log for reason[".trim($tmp[0])."]";
> +	    $reason = trim($tmp[0]);

Curly braces missing here. I've added a bunch more curly braces in this
piece of code, and applied to buildroot-test.

Thanks,

Thomas
diff mbox series

Patch

diff --git a/web/import.inc.php b/web/import.inc.php
index 8eb3066..081a1cb 100644
--- a/web/import.inc.php
+++ b/web/import.inc.php
@@ -235,7 +235,12 @@  function import_result($buildid, $filename)
 	if (trim($tmp[0]))
 	  $reason = $tmp[0];
 	else
-	  $reason = "unknown";
+	  exec("tail -1 " . $thisbuildfinaldir . "build-time.log | grep :start: | cut -d':' -f4", $tmp);
+	  if (trim($tmp[0]))
+	    print "Using build-time.log for reason[".trim($tmp[0])."]";
+	    $reason = trim($tmp[0]);
+	  else
+	    $reason = "unknown";
     }
 
     $db = new db();