| Message ID | 20180202122207.17104-1-rajat.srivastava@nxp.com |
|---|---|
| State | Accepted |
| Delegated to: | York Sun |
| Headers | show |
| Series | [U-Boot] ls1088a: qspi: Enable XIP mode above 16 MB addresses | expand |
On 02/02/2018 04:07 AM, Rajat Srivastava wrote: > Currently in LS1088A, XIP mode in QSPI works up to 16 MB > addresses. This patch enables QSPI support in XIP mode for > addresses above 16 MB as well. Can you write to QSPI above 16MB address? York
> -----Original Message----- > From: York Sun > Sent: Friday, February 02, 2018 9:29 PM > To: Rajat Srivastava <rajat.srivastava@nxp.com>; u-boot@lists.denx.de > Subject: Re: [PATCH] ls1088a: qspi: Enable XIP mode above 16 MB addresses > > On 02/02/2018 04:07 AM, Rajat Srivastava wrote: > > Currently in LS1088A, XIP mode in QSPI works up to 16 MB addresses. > > This patch enables QSPI support in XIP mode for addresses above 16 MB > > as well. > > Can you write to QSPI above 16MB address? No, I think execute in place (XIP) itself means we can only read. Please suggest if I shall change the patch description. Rajat
On 02/04/2018 09:37 PM, Rajat Srivastava wrote: > > >> -----Original Message----- >> From: York Sun >> Sent: Friday, February 02, 2018 9:29 PM >> To: Rajat Srivastava <rajat.srivastava@nxp.com>; u-boot@lists.denx.de >> Subject: Re: [PATCH] ls1088a: qspi: Enable XIP mode above 16 MB addresses >> >> On 02/02/2018 04:07 AM, Rajat Srivastava wrote: >>> Currently in LS1088A, XIP mode in QSPI works up to 16 MB addresses. >>> This patch enables QSPI support in XIP mode for addresses above 16 MB >>> as well. >> >> Can you write to QSPI above 16MB address? > > No, I think execute in place (XIP) itself means we can only read. > Please suggest if I shall change the patch description. > How do you put the image into it to begin with? Don't tell me you were using an external tool or a hacked version of older U-Boot. York
> -----Original Message----- > From: York Sun > Sent: Monday, February 05, 2018 10:20 PM > To: Rajat Srivastava <rajat.srivastava@nxp.com>; u-boot@lists.denx.de > Subject: Re: [PATCH] ls1088a: qspi: Enable XIP mode above 16 MB addresses > > On 02/04/2018 09:37 PM, Rajat Srivastava wrote: > > > > > >> -----Original Message----- > >> From: York Sun > >> Sent: Friday, February 02, 2018 9:29 PM > >> To: Rajat Srivastava <rajat.srivastava@nxp.com>; u-boot@lists.denx.de > >> Subject: Re: [PATCH] ls1088a: qspi: Enable XIP mode above 16 MB > >> addresses > >> > >> On 02/02/2018 04:07 AM, Rajat Srivastava wrote: > >>> Currently in LS1088A, XIP mode in QSPI works up to 16 MB addresses. > >>> This patch enables QSPI support in XIP mode for addresses above 16 > >>> MB as well. > >> > >> Can you write to QSPI above 16MB address? > > > > No, I think execute in place (XIP) itself means we can only read. > > Please suggest if I shall change the patch description. > > > > How do you put the image into it to begin with? Don't tell me you were using an > external tool or a hacked version of older U-Boot. > This patch enables data read above 16MB using AHB (on Uboot prompt) and does not involve our QSPI driver. It is equivalent to reading from DDR via cp or md commands. Whereas writing to flash is possible via IPS mode which involves our driver (using sf commands).
On 02/06/2018 02:59 AM, Rajat Srivastava wrote: > > <snip> >> How do you put the image into it to begin with? Don't tell me you were using an >> external tool or a hacked version of older U-Boot. >> > This patch enables data read above 16MB using AHB (on Uboot prompt) and does > not involve our QSPI driver. It is equivalent to reading from DDR via cp or md commands. > Whereas writing to flash is possible via IPS mode which involves our driver (using sf > commands). > OK. So we are still far away to have the full flash supported. York
> -----Original Message----- > From: York Sun > Sent: Tuesday, February 06, 2018 10:38 PM > To: Rajat Srivastava <rajat.srivastava@nxp.com>; u-boot@lists.denx.de > Subject: Re: [PATCH] ls1088a: qspi: Enable XIP mode above 16 MB addresses > > On 02/06/2018 02:59 AM, Rajat Srivastava wrote: > > > > > <snip> > > >> How do you put the image into it to begin with? Don't tell me you > >> were using an external tool or a hacked version of older U-Boot. > >> > > This patch enables data read above 16MB using AHB (on Uboot prompt) > > and does not involve our QSPI driver. It is equivalent to reading from DDR via > cp or md commands. > > Whereas writing to flash is possible via IPS mode which involves our > > driver (using sf commands). > > > OK. So we are still far away to have the full flash supported. > AHB Write is not supported by QSPI hardware. Rajat
On 02/02/2018 04:07 AM, Rajat Srivastava wrote: > Currently in LS1088A, XIP mode in QSPI works up to 16 MB > addresses. This patch enables QSPI support in XIP mode for > addresses above 16 MB as well. > > Signed-off-by: Rajat Srivastava <rajat.srivastava@nxp.com> > --- Applied to fsl-qoriq master, awaiting upstream. Thanks York
diff --git a/configs/ls1088aqds_qspi_SECURE_BOOT_defconfig b/configs/ls1088aqds_qspi_SECURE_BOOT_defconfig index 81cc2907c9..b128ae674b 100644 --- a/configs/ls1088aqds_qspi_SECURE_BOOT_defconfig +++ b/configs/ls1088aqds_qspi_SECURE_BOOT_defconfig @@ -23,6 +23,7 @@ CONFIG_E1000=y CONFIG_FIT_VERBOSE=y CONFIG_FSL_CAAM=y CONFIG_FSL_DSPI=y +CONFIG_QSPI_AHB_INIT=y CONFIG_FSL_LS_PPA=y CONFIG_HUSH_PARSER=y CONFIG_NETDEVICES=y diff --git a/configs/ls1088aqds_qspi_defconfig b/configs/ls1088aqds_qspi_defconfig index bd540f3efe..91abc547dd 100644 --- a/configs/ls1088aqds_qspi_defconfig +++ b/configs/ls1088aqds_qspi_defconfig @@ -36,6 +36,7 @@ CONFIG_PCIE_LAYERSCAPE=y CONFIG_SYS_NS16550=y CONFIG_DM_SPI=y CONFIG_FSL_DSPI=y +CONFIG_QSPI_AHB_INIT=y CONFIG_USB=y CONFIG_DM_USB=y CONFIG_USB_XHCI_HCD=y diff --git a/configs/ls1088ardb_qspi_SECURE_BOOT_defconfig b/configs/ls1088ardb_qspi_SECURE_BOOT_defconfig index 0843a693e4..66db72edd7 100644 --- a/configs/ls1088ardb_qspi_SECURE_BOOT_defconfig +++ b/configs/ls1088ardb_qspi_SECURE_BOOT_defconfig @@ -24,6 +24,7 @@ CONFIG_E1000=y CONFIG_FIT_VERBOSE=y CONFIG_FSL_CAAM=y CONFIG_FSL_DSPI=y +CONFIG_QSPI_AHB_INIT=y CONFIG_FSL_LS_PPA=y CONFIG_HUSH_PARSER=y CONFIG_NETDEVICES=y diff --git a/configs/ls1088ardb_qspi_defconfig b/configs/ls1088ardb_qspi_defconfig index be6fe8ca61..84130d0962 100644 --- a/configs/ls1088ardb_qspi_defconfig +++ b/configs/ls1088ardb_qspi_defconfig @@ -37,6 +37,7 @@ CONFIG_PCIE_LAYERSCAPE=y CONFIG_SYS_NS16550=y CONFIG_DM_SPI=y CONFIG_FSL_DSPI=y +CONFIG_QSPI_AHB_INIT=y CONFIG_USB=y CONFIG_DM_USB=y CONFIG_USB_XHCI_HCD=y
Currently in LS1088A, XIP mode in QSPI works up to 16 MB addresses. This patch enables QSPI support in XIP mode for addresses above 16 MB as well. Signed-off-by: Rajat Srivastava <rajat.srivastava@nxp.com> --- configs/ls1088aqds_qspi_SECURE_BOOT_defconfig | 1 + configs/ls1088aqds_qspi_defconfig | 1 + configs/ls1088ardb_qspi_SECURE_BOOT_defconfig | 1 + configs/ls1088ardb_qspi_defconfig | 1 + 4 files changed, 4 insertions(+)