| Message ID | 20180131152125.15176-1-marek.vasut+renesas@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Masahiro Yamada |
| Headers | show |
| Series | [U-Boot,01/10] mmc: uniphier-sd: Add compatible strings for RCar Gen2 | expand |
On 02/01/2018 12:21 AM, Marek Vasut wrote: > Add DT compatible strings for RCar Gen2 SoCs, so that this driver > can bind with them. Unlike Gen3, which uses 64bit FIFO, the Gen2 > uses 16bit FIFO. > > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > Cc: Jaehoon Chung <jh80.chung@samsung.com> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> Applied to u-boot-mmc. Thanks! Sorry for late. I have checked the previous version.. Best Regards, Jaehoon Chung > --- > drivers/mmc/uniphier-sd.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mmc/uniphier-sd.c b/drivers/mmc/uniphier-sd.c > index 741f9dfd9c..a080674c8a 100644 > --- a/drivers/mmc/uniphier-sd.c > +++ b/drivers/mmc/uniphier-sd.c > @@ -847,6 +847,11 @@ static int uniphier_sd_probe(struct udevice *dev) > } > > static const struct udevice_id uniphier_sd_match[] = { > + { .compatible = "renesas,sdhi-r8a7790", .data = 0 }, > + { .compatible = "renesas,sdhi-r8a7791", .data = 0 }, > + { .compatible = "renesas,sdhi-r8a7792", .data = 0 }, > + { .compatible = "renesas,sdhi-r8a7793", .data = 0 }, > + { .compatible = "renesas,sdhi-r8a7794", .data = 0 }, > { .compatible = "renesas,sdhi-r8a7795", .data = UNIPHIER_SD_CAP_64BIT }, > { .compatible = "renesas,sdhi-r8a7796", .data = UNIPHIER_SD_CAP_64BIT }, > { .compatible = "renesas,sdhi-r8a77970", .data = UNIPHIER_SD_CAP_64BIT }, >
On 02/19/2018 12:23 PM, Jaehoon Chung wrote: > On 02/01/2018 12:21 AM, Marek Vasut wrote: >> Add DT compatible strings for RCar Gen2 SoCs, so that this driver >> can bind with them. Unlike Gen3, which uses 64bit FIFO, the Gen2 >> uses 16bit FIFO. >> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >> Cc: Jaehoon Chung <jh80.chung@samsung.com> >> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> > > Applied to u-boot-mmc. Thanks! Sorry for late. > I have checked the previous version.. Yes, this is so late that it has to be scheduled for 2018.05 cycle. Another cycle missed, sigh.
On 02/20/2018 02:02 AM, Marek Vasut wrote: > On 02/19/2018 12:23 PM, Jaehoon Chung wrote: >> On 02/01/2018 12:21 AM, Marek Vasut wrote: >>> Add DT compatible strings for RCar Gen2 SoCs, so that this driver >>> can bind with them. Unlike Gen3, which uses 64bit FIFO, the Gen2 >>> uses 16bit FIFO. >>> >>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >>> Cc: Jaehoon Chung <jh80.chung@samsung.com> >>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> >> >> Applied to u-boot-mmc. Thanks! Sorry for late. >> I have checked the previous version.. > > Yes, this is so late that it has to be scheduled for 2018.05 cycle. > Another cycle missed, sigh. I will revert your patch on master. instead i will apply this patch on next branch. Is it ok? Best Regards, Jaehoon Chung >
On 02/20/2018 01:54 AM, Jaehoon Chung wrote: > On 02/20/2018 02:02 AM, Marek Vasut wrote: >> On 02/19/2018 12:23 PM, Jaehoon Chung wrote: >>> On 02/01/2018 12:21 AM, Marek Vasut wrote: >>>> Add DT compatible strings for RCar Gen2 SoCs, so that this driver >>>> can bind with them. Unlike Gen3, which uses 64bit FIFO, the Gen2 >>>> uses 16bit FIFO. >>>> >>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >>>> Cc: Jaehoon Chung <jh80.chung@samsung.com> >>>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> >>> >>> Applied to u-boot-mmc. Thanks! Sorry for late. >>> I have checked the previous version.. >> >> Yes, this is so late that it has to be scheduled for 2018.05 cycle. >> Another cycle missed, sigh. > > > I will revert your patch on master. instead i will apply this patch on next branch. > Is it ok? Why would you revert it ? Just drop it from the PR and resend the PR. And then apply it for -next branch, yes.
On 02/20/2018 01:31 PM, Marek Vasut wrote: > On 02/20/2018 01:54 AM, Jaehoon Chung wrote: >> On 02/20/2018 02:02 AM, Marek Vasut wrote: >>> On 02/19/2018 12:23 PM, Jaehoon Chung wrote: >>>> On 02/01/2018 12:21 AM, Marek Vasut wrote: >>>>> Add DT compatible strings for RCar Gen2 SoCs, so that this driver >>>>> can bind with them. Unlike Gen3, which uses 64bit FIFO, the Gen2 >>>>> uses 16bit FIFO. >>>>> >>>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >>>>> Cc: Jaehoon Chung <jh80.chung@samsung.com> >>>>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> >>>> >>>> Applied to u-boot-mmc. Thanks! Sorry for late. >>>> I have checked the previous version.. >>> >>> Yes, this is so late that it has to be scheduled for 2018.05 cycle. >>> Another cycle missed, sigh. >> >> >> I will revert your patch on master. instead i will apply this patch on next branch. >> Is it ok? > > Why would you revert it ? Just drop it from the PR and resend the PR. > > And then apply it for -next branch, yes. Which presumably never happened, since those patches are not in -rc1 ?
On 04/08/2018 06:41 PM, Marek Vasut wrote: > On 02/20/2018 01:31 PM, Marek Vasut wrote: >> On 02/20/2018 01:54 AM, Jaehoon Chung wrote: >>> On 02/20/2018 02:02 AM, Marek Vasut wrote: >>>> On 02/19/2018 12:23 PM, Jaehoon Chung wrote: >>>>> On 02/01/2018 12:21 AM, Marek Vasut wrote: >>>>>> Add DT compatible strings for RCar Gen2 SoCs, so that this driver >>>>>> can bind with them. Unlike Gen3, which uses 64bit FIFO, the Gen2 >>>>>> uses 16bit FIFO. >>>>>> >>>>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >>>>>> Cc: Jaehoon Chung <jh80.chung@samsung.com> >>>>>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> >>>>> >>>>> Applied to u-boot-mmc. Thanks! Sorry for late. >>>>> I have checked the previous version.. >>>> >>>> Yes, this is so late that it has to be scheduled for 2018.05 cycle. >>>> Another cycle missed, sigh. >>> >>> >>> I will revert your patch on master. instead i will apply this patch on next branch. >>> Is it ok? >> >> Why would you revert it ? Just drop it from the PR and resend the PR. >> >> And then apply it for -next branch, yes. > > Which presumably never happened, since those patches are not in -rc1 ? I will update the patchset and resubmit it, sigh ...
diff --git a/drivers/mmc/uniphier-sd.c b/drivers/mmc/uniphier-sd.c index 741f9dfd9c..a080674c8a 100644 --- a/drivers/mmc/uniphier-sd.c +++ b/drivers/mmc/uniphier-sd.c @@ -847,6 +847,11 @@ static int uniphier_sd_probe(struct udevice *dev) } static const struct udevice_id uniphier_sd_match[] = { + { .compatible = "renesas,sdhi-r8a7790", .data = 0 }, + { .compatible = "renesas,sdhi-r8a7791", .data = 0 }, + { .compatible = "renesas,sdhi-r8a7792", .data = 0 }, + { .compatible = "renesas,sdhi-r8a7793", .data = 0 }, + { .compatible = "renesas,sdhi-r8a7794", .data = 0 }, { .compatible = "renesas,sdhi-r8a7795", .data = UNIPHIER_SD_CAP_64BIT }, { .compatible = "renesas,sdhi-r8a7796", .data = UNIPHIER_SD_CAP_64BIT }, { .compatible = "renesas,sdhi-r8a77970", .data = UNIPHIER_SD_CAP_64BIT },
Add DT compatible strings for RCar Gen2 SoCs, so that this driver can bind with them. Unlike Gen3, which uses 64bit FIFO, the Gen2 uses 16bit FIFO. Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> Cc: Jaehoon Chung <jh80.chung@samsung.com> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/mmc/uniphier-sd.c | 5 +++++ 1 file changed, 5 insertions(+)