diff mbox series

[U-Boot,1/5] imx: mx7: change sdhc clk to 392M

Message ID 20180119090922.32320-1-peng.fan@nxp.com
State Changes Requested
Delegated to: Stefano Babic
Headers show
Series [U-Boot,1/5] imx: mx7: change sdhc clk to 392M | expand

Commit Message

Peng Fan Jan. 19, 2018, 9:09 a.m. UTC
Change sdhc clk to 392M.
Prepare support for SDR104 and HS200.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Jaehoon Chung <jh80.chung@samsung.com>
---
 arch/arm/mach-imx/mx7/clock.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Fabio Estevam Jan. 20, 2018, 8:06 p.m. UTC | #1
Hi Peng,

On Fri, Jan 19, 2018 at 7:09 AM, Peng Fan <peng.fan@nxp.com> wrote:
> Change sdhc clk to 392M.

392 MHz here and in the Subject, please.

> Prepare support for SDR104 and HS200.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> ---
>  arch/arm/mach-imx/mx7/clock.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-imx/mx7/clock.c b/arch/arm/mach-imx/mx7/clock.c
> index c11042d6f5..227037c53d 100644
> --- a/arch/arm/mach-imx/mx7/clock.c
> +++ b/arch/arm/mach-imx/mx7/clock.c
> @@ -561,17 +561,17 @@ static void init_clk_esdhc(void)
>         /* 196: 392/2 */

Please remove this line of comment as it is no longer true after this patch.
Peng Fan Jan. 21, 2018, 2:31 a.m. UTC | #2
Hi Fabio

> -----Original Message-----

> From: Fabio Estevam [mailto:festevam@gmail.com]

> Sent: Sunday, January 21, 2018 4:07 AM

> To: Peng Fan <peng.fan@nxp.com>

> Cc: Stefano Babic <sbabic@denx.de>; U-Boot-Denx <u-boot@lists.denx.de>;

> Fabio Estevam <fabio.estevam@nxp.com>

> Subject: Re: [U-Boot] [PATCH 1/5] imx: mx7: change sdhc clk to 392M

> 

> Hi Peng,

> 

> On Fri, Jan 19, 2018 at 7:09 AM, Peng Fan <peng.fan@nxp.com> wrote:

> > Change sdhc clk to 392M.

> 

> 392 MHz here and in the Subject, please.


Thanks for comments. In V2, I think this patch could be droped. 196MHz
is enough here.

Thanks,
Peng.

> 

> > Prepare support for SDR104 and HS200.

> >

> > Signed-off-by: Peng Fan <peng.fan@nxp.com>

> > Cc: Stefano Babic <sbabic@denx.de>

> > Cc: Fabio Estevam <fabio.estevam@nxp.com>

> > Cc: Jaehoon Chung <jh80.chung@samsung.com>

> > ---

> >  arch/arm/mach-imx/mx7/clock.c | 6 +++---

> >  1 file changed, 3 insertions(+), 3 deletions(-)

> >

> > diff --git a/arch/arm/mach-imx/mx7/clock.c

> > b/arch/arm/mach-imx/mx7/clock.c index c11042d6f5..227037c53d 100644

> > --- a/arch/arm/mach-imx/mx7/clock.c

> > +++ b/arch/arm/mach-imx/mx7/clock.c

> > @@ -561,17 +561,17 @@ static void init_clk_esdhc(void)

> >         /* 196: 392/2 */

> 

> Please remove this line of comment as it is no longer true after this patch.
diff mbox series

Patch

diff --git a/arch/arm/mach-imx/mx7/clock.c b/arch/arm/mach-imx/mx7/clock.c
index c11042d6f5..227037c53d 100644
--- a/arch/arm/mach-imx/mx7/clock.c
+++ b/arch/arm/mach-imx/mx7/clock.c
@@ -561,17 +561,17 @@  static void init_clk_esdhc(void)
 	/* 196: 392/2 */
 	target = CLK_ROOT_ON | USDHC1_CLK_ROOT_FROM_PLL_SYS_PFD0_392M_CLK |
 		 CLK_ROOT_PRE_DIV(CLK_ROOT_PRE_DIV1) |
-		 CLK_ROOT_POST_DIV(CLK_ROOT_POST_DIV2);
+		 CLK_ROOT_POST_DIV(CLK_ROOT_POST_DIV1);
 	clock_set_target_val(USDHC1_CLK_ROOT, target);
 
 	target = CLK_ROOT_ON | USDHC1_CLK_ROOT_FROM_PLL_SYS_PFD0_392M_CLK |
 		 CLK_ROOT_PRE_DIV(CLK_ROOT_PRE_DIV1) |
-		 CLK_ROOT_POST_DIV(CLK_ROOT_POST_DIV2);
+		 CLK_ROOT_POST_DIV(CLK_ROOT_POST_DIV1);
 	clock_set_target_val(USDHC2_CLK_ROOT, target);
 
 	target = CLK_ROOT_ON | USDHC1_CLK_ROOT_FROM_PLL_SYS_PFD0_392M_CLK |
 		 CLK_ROOT_PRE_DIV(CLK_ROOT_PRE_DIV1) |
-		 CLK_ROOT_POST_DIV(CLK_ROOT_POST_DIV2);
+		 CLK_ROOT_POST_DIV(CLK_ROOT_POST_DIV1);
 	clock_set_target_val(USDHC3_CLK_ROOT, target);
 
 	/* enable the clock gate */