diff mbox series

[U-Boot] arm: mach-omap2: Remove secure certificate name printing

Message ID 20180109203354.5944-1-afd@ti.com
State Accepted
Commit 6b3d4f3def34d364d71a2eb89a2e33f1b6bb0d30
Delegated to: Tom Rini
Headers show
Series [U-Boot] arm: mach-omap2: Remove secure certificate name printing | expand

Commit Message

Andrew Davis Jan. 9, 2018, 8:33 p.m. UTC
The signing certificate name is always 15 chars long, but need not be
null terminated. One solution is then to use printf precision modifiers
to only print this many chars ("%.15s"), but tiny printf does not support
this, so lets just drop printing the cert name for now.

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 arch/arm/mach-omap2/sec-common.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Tom Rini Jan. 19, 2018, 9:14 p.m. UTC | #1
On Tue, Jan 09, 2018 at 02:33:54PM -0600, Andrew F. Davis wrote:

> The signing certificate name is always 15 chars long, but need not be
> null terminated. One solution is then to use printf precision modifiers
> to only print this many chars ("%.15s"), but tiny printf does not support
> this, so lets just drop printing the cert name for now.
> 
> Signed-off-by: Andrew F. Davis <afd@ti.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/arch/arm/mach-omap2/sec-common.c b/arch/arm/mach-omap2/sec-common.c
index 2630e7d316..e52c8526c7 100644
--- a/arch/arm/mach-omap2/sec-common.c
+++ b/arch/arm/mach-omap2/sec-common.c
@@ -168,16 +168,16 @@  auth_exit:
 	}
 
 	/*
-	 * Output notification of successful authentication as well the name of
-	 * the signing certificate used to re-assure the user that the secure
-	 * code is being processed as expected. However suppress any such log
-	 * output in case of building for SPL and booting via YMODEM. This is
-	 * done to avoid disturbing the YMODEM serial protocol transactions.
+	 * Output notification of successful authentication to re-assure the
+	 * user that the secure code is being processed as expected. However
+	 * suppress any such log output in case of building for SPL and booting
+	 * via YMODEM. This is done to avoid disturbing the YMODEM serial
+	 * protocol transactions.
 	 */
 	if (!(IS_ENABLED(CONFIG_SPL_BUILD) &&
 	      IS_ENABLED(CONFIG_SPL_YMODEM_SUPPORT) &&
 	      spl_boot_device() == BOOT_DEVICE_UART))
-		printf("Authentication passed: %s\n", (char *)sig_addr);
+		printf("Authentication passed\n");
 
 	return result;
 }