diff mbox series

powerpc: Add aacraid and nvme to powernv_defconfig

Message ID 1513734660.2743.14.camel@kernel.crashing.org (mailing list archive)
State Accepted
Commit bba9bc89b9e72bcf26632877b4823a7e92009b02
Headers show
Series powerpc: Add aacraid and nvme to powernv_defconfig | expand

Commit Message

Benjamin Herrenschmidt Dec. 20, 2017, 1:51 a.m. UTC
These adapters can be found in a number of our systems, so let's
enable the corresponding drivers by default.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

Comments

Alexey Kardashevskiy Dec. 20, 2017, 1:59 a.m. UTC | #1
On 20/12/17 12:51, Benjamin Herrenschmidt wrote:
> These adapters can be found in a number of our systems, so let's
> enable the corresponding drivers by default.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> --- a/arch/powerpc/configs/powernv_defconfig	2017-12-19 18:37:24.803470591 -0600
> +++ b/arch/powerpc/configs/powernv_defconfig	2017-12-19 19:47:57.931952417 -0600
> @@ -97,6 +97,7 @@
>  CONFIG_BLK_DEV_RAM=y
>  CONFIG_BLK_DEV_RAM_SIZE=65536
>  CONFIG_VIRTIO_BLK=m
> +CONFIG_BLK_DEV_NVME=y
>  CONFIG_IDE=y
>  CONFIG_BLK_DEV_IDECD=y
>  CONFIG_BLK_DEV_GENERIC=y
> @@ -113,6 +114,7 @@
>  CONFIG_SCSI_CXGB4_ISCSI=m
>  CONFIG_SCSI_BNX2_ISCSI=m
>  CONFIG_BE2ISCSI=m
> +CONFIG_SCSI_AACRAID=y
>  CONFIG_SCSI_MPT2SAS=m
>  CONFIG_SCSI_SYM53C8XX_2=m
>  CONFIG_SCSI_SYM53C8XX_DMA_ADDRESSING_MODE=0
> 

"y", not "m"?
Benjamin Herrenschmidt Dec. 20, 2017, 2:14 a.m. UTC | #2
On Wed, 2017-12-20 at 12:59 +1100, Alexey Kardashevskiy wrote:
> On 20/12/17 12:51, Benjamin Herrenschmidt wrote:
> > These adapters can be found in a number of our systems, so let's
> > enable the corresponding drivers by default.
> > 
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > ---
> > --- a/arch/powerpc/configs/powernv_defconfig	2017-12-19 18:37:24.803470591 -0600
> > +++ b/arch/powerpc/configs/powernv_defconfig	2017-12-19 19:47:57.931952417 -0600
> > @@ -97,6 +97,7 @@
> >  CONFIG_BLK_DEV_RAM=y
> >  CONFIG_BLK_DEV_RAM_SIZE=65536
> >  CONFIG_VIRTIO_BLK=m
> > +CONFIG_BLK_DEV_NVME=y
> >  CONFIG_IDE=y
> >  CONFIG_BLK_DEV_IDECD=y
> >  CONFIG_BLK_DEV_GENERIC=y
> > @@ -113,6 +114,7 @@
> >  CONFIG_SCSI_CXGB4_ISCSI=m
> >  CONFIG_SCSI_BNX2_ISCSI=m
> >  CONFIG_BE2ISCSI=m
> > +CONFIG_SCSI_AACRAID=y
> >  CONFIG_SCSI_MPT2SAS=m
> >  CONFIG_SCSI_SYM53C8XX_2=m
> >  CONFIG_SCSI_SYM53C8XX_DMA_ADDRESSING_MODE=0
> > 
> 
> "y", not "m"?

Yes. I like my boot devices to be "y"

Cheers,
Ben.
Alexey Kardashevskiy Dec. 23, 2017, 12:40 a.m. UTC | #3
On 20/12/17 13:14, Benjamin Herrenschmidt wrote:
> On Wed, 2017-12-20 at 12:59 +1100, Alexey Kardashevskiy wrote:
>> On 20/12/17 12:51, Benjamin Herrenschmidt wrote:
>>> These adapters can be found in a number of our systems, so let's
>>> enable the corresponding drivers by default.
>>>
>>> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>>> ---
>>> --- a/arch/powerpc/configs/powernv_defconfig	2017-12-19 18:37:24.803470591 -0600
>>> +++ b/arch/powerpc/configs/powernv_defconfig	2017-12-19 19:47:57.931952417 -0600
>>> @@ -97,6 +97,7 @@
>>>  CONFIG_BLK_DEV_RAM=y
>>>  CONFIG_BLK_DEV_RAM_SIZE=65536
>>>  CONFIG_VIRTIO_BLK=m
>>> +CONFIG_BLK_DEV_NVME=y
>>>  CONFIG_IDE=y
>>>  CONFIG_BLK_DEV_IDECD=y
>>>  CONFIG_BLK_DEV_GENERIC=y
>>> @@ -113,6 +114,7 @@
>>>  CONFIG_SCSI_CXGB4_ISCSI=m
>>>  CONFIG_SCSI_BNX2_ISCSI=m
>>>  CONFIG_BE2ISCSI=m
>>> +CONFIG_SCSI_AACRAID=y
>>>  CONFIG_SCSI_MPT2SAS=m
>>>  CONFIG_SCSI_SYM53C8XX_2=m
>>>  CONFIG_SCSI_SYM53C8XX_DMA_ADDRESSING_MODE=0
>>>
>>
>> "y", not "m"?
> 
> Yes. I like my boot devices to be "y"


Then rename it to powernv_benh_defconfig :) Everything else seems to cope
well with "m" - just look above.
Benjamin Herrenschmidt Dec. 23, 2017, 5:08 a.m. UTC | #4
On Sat, 2017-12-23 at 11:40 +1100, Alexey Kardashevskiy wrote:
> On 20/12/17 13:14, Benjamin Herrenschmidt wrote:
> > On Wed, 2017-12-20 at 12:59 +1100, Alexey Kardashevskiy wrote:
> > > On 20/12/17 12:51, Benjamin Herrenschmidt wrote:
> > > > These adapters can be found in a number of our systems, so let's
> > > > enable the corresponding drivers by default.
> > > > 
> > > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > > ---
> > > > --- a/arch/powerpc/configs/powernv_defconfig	2017-12-19 18:37:24.803470591 -0600
> > > > +++ b/arch/powerpc/configs/powernv_defconfig	2017-12-19 19:47:57.931952417 -0600
> > > > @@ -97,6 +97,7 @@
> > > >  CONFIG_BLK_DEV_RAM=y
> > > >  CONFIG_BLK_DEV_RAM_SIZE=65536
> > > >  CONFIG_VIRTIO_BLK=m
> > > > +CONFIG_BLK_DEV_NVME=y
> > > >  CONFIG_IDE=y
> > > >  CONFIG_BLK_DEV_IDECD=y
> > > >  CONFIG_BLK_DEV_GENERIC=y
> > > > @@ -113,6 +114,7 @@
> > > >  CONFIG_SCSI_CXGB4_ISCSI=m
> > > >  CONFIG_SCSI_BNX2_ISCSI=m
> > > >  CONFIG_BE2ISCSI=m
> > > > +CONFIG_SCSI_AACRAID=y
> > > >  CONFIG_SCSI_MPT2SAS=m
> > > >  CONFIG_SCSI_SYM53C8XX_2=m
> > > >  CONFIG_SCSI_SYM53C8XX_DMA_ADDRESSING_MODE=0
> > > > 
> > > 
> > > "y", not "m"?
> > 
> > Yes. I like my boot devices to be "y"
> 
> 
> Then rename it to powernv_benh_defconfig :) Everything else seems to cope
> well with "m" - just look above.

No. Most of the above aren't needed as boot devices on powernv systems.

If you look at IPR for example, it's Y not N.

Cheers,
Ben.

> 
>
Michael Ellerman Jan. 17, 2018, 1:30 p.m. UTC | #5
On Wed, 2017-12-20 at 01:51:00 UTC, Benjamin Herrenschmidt wrote:
> These adapters can be found in a number of our systems, so let's
> enable the corresponding drivers by default.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/bba9bc89b9e72bcf26632877b4823a

cheers
diff mbox series

Patch

--- a/arch/powerpc/configs/powernv_defconfig	2017-12-19 18:37:24.803470591 -0600
+++ b/arch/powerpc/configs/powernv_defconfig	2017-12-19 19:47:57.931952417 -0600
@@ -97,6 +97,7 @@ 
 CONFIG_BLK_DEV_RAM=y
 CONFIG_BLK_DEV_RAM_SIZE=65536
 CONFIG_VIRTIO_BLK=m
+CONFIG_BLK_DEV_NVME=y
 CONFIG_IDE=y
 CONFIG_BLK_DEV_IDECD=y
 CONFIG_BLK_DEV_GENERIC=y
@@ -113,6 +114,7 @@ 
 CONFIG_SCSI_CXGB4_ISCSI=m
 CONFIG_SCSI_BNX2_ISCSI=m
 CONFIG_BE2ISCSI=m
+CONFIG_SCSI_AACRAID=y
 CONFIG_SCSI_MPT2SAS=m
 CONFIG_SCSI_SYM53C8XX_2=m
 CONFIG_SCSI_SYM53C8XX_DMA_ADDRESSING_MODE=0