Patchwork powerpc/macintosh: Fix __devexit annotation in rack-meter.c

login
register
mail settings
Submitter Grant Likely
Date Feb. 28, 2011, 7:59 p.m.
Message ID <20110228195931.2044.69345.stgit@localhost6.localdomain6>
Download mbox | patch
Permalink /patch/84863/
State Accepted, archived
Commit e1f4dea454c8e643644114757080680e1959d410
Delegated to: Benjamin Herrenschmidt
Headers show

Comments

Grant Likely - Feb. 28, 2011, 7:59 p.m.
The following warning was seen building rack-meter.c

WARNING: drivers/built-in.o(.text+0xac784): Section mismatch in reference from the function rackmeter_shutdown() to the function .devexit.text:rackmeter_stop_cpu_sniffer()
The function rackmeter_shutdown() references a function in an exit section.
Often the function rackmeter_stop_cpu_sniffer() has valid usage outside the exit section
and the fix is to remove the __devexit annotation of rackmeter_stop_cpu_sniffer.

This patch resolves the warning by removing the __devexit annotation from
rackmeter_stop_cpu_sniffer().

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@lists.ozlabs.org
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
 drivers/macintosh/rack-meter.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/drivers/macintosh/rack-meter.c b/drivers/macintosh/rack-meter.c
index 39f660b..2637c13 100644
--- a/drivers/macintosh/rack-meter.c
+++ b/drivers/macintosh/rack-meter.c
@@ -283,7 +283,7 @@  static void __devinit rackmeter_init_cpu_sniffer(struct rackmeter *rm)
 	}
 }
 
-static void __devexit rackmeter_stop_cpu_sniffer(struct rackmeter *rm)
+static void rackmeter_stop_cpu_sniffer(struct rackmeter *rm)
 {
 	cancel_delayed_work_sync(&rm->cpu[0].sniffer);
 	cancel_delayed_work_sync(&rm->cpu[1].sniffer);