diff mbox series

[U-Boot] sunxi: Fix UART console index for A33-OLinuXino

Message ID 20171205060007.11647-1-wens@csie.org
State Accepted
Commit 6af1a2eeee8b4eb50ea5f66c512c945927539975
Delegated to: Jagannadha Sutradharudu Teki
Headers show
Series [U-Boot] sunxi: Fix UART console index for A33-OLinuXino | expand

Commit Message

Chen-Yu Tsai Dec. 5, 2017, 6 a.m. UTC
The A33-OLinuXino defconfig was using the default CONS_INDEX value for
A33, which actually points to the R_UART, which is routed to the GPIO
header without proper pull-ups or diodes. The board has a separate
header for UART0, which are routed to pins PB0 and PB1. This header
is properly marked and is likely the first pins any user would try
to get a console.

Fix CONS_INDEX in the defconfig so the console appears on UART0.

Fixes: ca5c37026be4 ("sunxi: Add support for A33-OLinuXino board")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 configs/A33-OLinuXino_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Maxime Ripard Dec. 5, 2017, 9:41 a.m. UTC | #1
On Tue, Dec 05, 2017 at 02:00:07PM +0800, Chen-Yu Tsai wrote:
> The A33-OLinuXino defconfig was using the default CONS_INDEX value for
> A33, which actually points to the R_UART, which is routed to the GPIO
> header without proper pull-ups or diodes. The board has a separate
> header for UART0, which are routed to pins PB0 and PB1. This header
> is properly marked and is likely the first pins any user would try
> to get a console.
> 
> Fix CONS_INDEX in the defconfig so the console appears on UART0.
> 
> Fixes: ca5c37026be4 ("sunxi: Add support for A33-OLinuXino board")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Maxime
Jagan Teki Dec. 7, 2017, 5:38 a.m. UTC | #2
On Tue, Dec 5, 2017 at 3:11 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Tue, Dec 05, 2017 at 02:00:07PM +0800, Chen-Yu Tsai wrote:
>> The A33-OLinuXino defconfig was using the default CONS_INDEX value for
>> A33, which actually points to the R_UART, which is routed to the GPIO
>> header without proper pull-ups or diodes. The board has a separate
>> header for UART0, which are routed to pins PB0 and PB1. This header
>> is properly marked and is likely the first pins any user would try
>> to get a console.
>>
>> Fix CONS_INDEX in the defconfig so the console appears on UART0.
>>
>> Fixes: ca5c37026be4 ("sunxi: Add support for A33-OLinuXino board")
>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Applied to u-boot-sunxi/master
diff mbox series

Patch

diff --git a/configs/A33-OLinuXino_defconfig b/configs/A33-OLinuXino_defconfig
index c11991de7e5a..894bb19cf0bd 100644
--- a/configs/A33-OLinuXino_defconfig
+++ b/configs/A33-OLinuXino_defconfig
@@ -1,5 +1,6 @@ 
 CONFIG_ARM=y
 CONFIG_ARCH_SUNXI=y
+CONFIG_CONS_INDEX=1
 CONFIG_MACH_SUN8I_A33=y
 CONFIG_DRAM_CLK=432
 CONFIG_DRAM_ZQ=15291