| Message ID | 5a24209e.9b18c80a.d4b49.11cb@mx.google.com |
|---|---|
| State | Deferred |
| Delegated to: | Marek Vasut |
| Headers | show |
| Series | [U-Boot] arm socfpga: Revert "spi: cadence_qspi_apb: Support 32 bit AHB address" | expand |
On Sunday 03 December 2017 09:29 PM, Frank Mori Hess wrote: > This reverts commit dac3bf20fb2c9b03476be0d73db620f62ab3cee1. > > My u-boot spl crashes in a loop when I boot off a > cadence qspi flash. I narrowed it down to the changes from commit > dac3bf20fb2c9b03476be0d73db620f62ab3cee1 which removes > CQSPI_INDIRECTTRIGGER_ADDR_MASK. Restoring the mask allows the spl to > successfully load the main u-boot. My board is an Altera HPS cyclone > V socfpga. It has an ahb base address of 0xffa00000 and for some > reason, without the CQSPI_INDIRECTTRIGGER_ADDR_MASK the board reboots > when cadence_qspi_apb_indirect_read_execute tries to read from the ahb > base address. I'm was using version 2016.11 of u-boot. This breaks TI platforms where INDIRECTTRIGGER_ADDR is 32bit wide. Instead please try this patch series which adds cdns,trigger-address DT property: http://patchwork.ozlabs.org/patch/838589/ Regards Vignesh > > Signed-off-by: Frank Mori Hess <fmh6jj@gmail.com> > --- > drivers/spi/cadence_qspi_apb.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/cadence_qspi_apb.c b/drivers/spi/cadence_qspi_apb.c > index e02f2217f4..b300f36607 100644 > --- a/drivers/spi/cadence_qspi_apb.c > +++ b/drivers/spi/cadence_qspi_apb.c > @@ -47,6 +47,7 @@ > #define CQSPI_INST_TYPE_QUAD 2 > > #define CQSPI_STIG_DATA_LEN_MAX 8 > +#define CQSPI_INDIRECTTRIGGER_ADDR_MASK 0xFFFFF > > #define CQSPI_DUMMY_CLKS_PER_BYTE 8 > #define CQSPI_DUMMY_BYTES_MAX 4 > @@ -560,7 +561,7 @@ int cadence_qspi_apb_indirect_read_setup(struct cadence_spi_platdata *plat, > addr_bytes = cmdlen - 1; > > /* Setup the indirect trigger address */ > - writel((u32)plat->ahbbase, > + writel(((u32)plat->ahbbase & CQSPI_INDIRECTTRIGGER_ADDR_MASK), > plat->regbase + CQSPI_REG_INDIRECTTRIGGER); > > /* Configure the opcode */ > @@ -710,7 +711,7 @@ int cadence_qspi_apb_indirect_write_setup(struct cadence_spi_platdata *plat, > return -EINVAL; > } > /* Setup the indirect trigger address */ > - writel((u32)plat->ahbbase, > + writel(((u32)plat->ahbbase & CQSPI_INDIRECTTRIGGER_ADDR_MASK), > plat->regbase + CQSPI_REG_INDIRECTTRIGGER); > > /* Configure the opcode */ >
Since your commit broke my platform to fix yours, shouldn't it be reverted and TI platforms use your pending patch queue? On Dec 3, 2017 23:14, "Vignesh R" <vigneshr@ti.com> wrote: On Sunday 03 December 2017 09:29 PM, Frank Mori Hess wrote: > This reverts commit dac3bf20fb2c9b03476be0d73db620f62ab3cee1. > > My u-boot spl crashes in a loop when I boot off a > cadence qspi flash. I narrowed it down to the changes from commit > dac3bf20fb2c9b03476be0d73db620f62ab3cee1 which removes > CQSPI_INDIRECTTRIGGER_ADDR_MASK. Restoring the mask allows the spl to > successfully load the main u-boot. My board is an Altera HPS cyclone > V socfpga. It has an ahb base address of 0xffa00000 and for some > reason, without the CQSPI_INDIRECTTRIGGER_ADDR_MASK the board reboots > when cadence_qspi_apb_indirect_read_execute tries to read from the ahb > base address. I'm was using version 2016.11 of u-boot. This breaks TI platforms where INDIRECTTRIGGER_ADDR is 32bit wide. Instead please try this patch series which adds cdns,trigger-address DT property: http://patchwork.ozlabs.org/patch/838589/ Regards Vignesh > > Signed-off-by: Frank Mori Hess <fmh6jj@gmail.com> > --- > drivers/spi/cadence_qspi_apb.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/cadence_qspi_apb.c b/drivers/spi/cadence_qspi_apb .c > index e02f2217f4..b300f36607 100644 > --- a/drivers/spi/cadence_qspi_apb.c > +++ b/drivers/spi/cadence_qspi_apb.c > @@ -47,6 +47,7 @@ > #define CQSPI_INST_TYPE_QUAD 2 > > #define CQSPI_STIG_DATA_LEN_MAX 8 > +#define CQSPI_INDIRECTTRIGGER_ADDR_MASK 0xFFFFF > > #define CQSPI_DUMMY_CLKS_PER_BYTE 8 > #define CQSPI_DUMMY_BYTES_MAX 4 > @@ -560,7 +561,7 @@ int cadence_qspi_apb_indirect_read_setup(struct cadence_spi_platdata *plat, > addr_bytes = cmdlen - 1; > > /* Setup the indirect trigger address */ > - writel((u32)plat->ahbbase, > + writel(((u32)plat->ahbbase & CQSPI_INDIRECTTRIGGER_ADDR_MASK), > plat->regbase + CQSPI_REG_INDIRECTTRIGGER); > > /* Configure the opcode */ > @@ -710,7 +711,7 @@ int cadence_qspi_apb_indirect_write_setup(struct cadence_spi_platdata *plat, > return -EINVAL; > } > /* Setup the indirect trigger address */ > - writel((u32)plat->ahbbase, > + writel(((u32)plat->ahbbase & CQSPI_INDIRECTTRIGGER_ADDR_MASK), > plat->regbase + CQSPI_REG_INDIRECTTRIGGER); > > /* Configure the opcode */ >
Hi, On 04-Dec-17 6:41 PM, Frank Mori Hess wrote: > Since your commit broke my platform to fix yours, shouldn't it be > reverted and TI platforms use your pending patch queue? > Socfpga DT defined ahb base as 0xffa00000 while masked upper bits in the code, which was confusing. And seems that my patch did work on some socfgpa board looking at the original commit message. If the patch is reverted then, applying pending patches alone will not help because my patch would be needed anyway to make sure we don't mask 31-20 bits on TI platforms. Therefore instead of reverting and the re-applying, I would recommend to ping SPI maintainer to get http://patchwork.ozlabs.org/patch/838589/ merged as early as possible. > On Dec 3, 2017 23:14, "Vignesh R" <vigneshr@ti.com > <mailto:vigneshr@ti.com>> wrote: > > > > On Sunday 03 December 2017 09:29 PM, Frank Mori Hess wrote: > > This reverts commit dac3bf20fb2c9b03476be0d73db620f62ab3cee1. > > > > My u-boot spl crashes in a loop when I boot off a > > cadence qspi flash. I narrowed it down to the changes from commit > > dac3bf20fb2c9b03476be0d73db620f62ab3cee1 which removes > > CQSPI_INDIRECTTRIGGER_ADDR_MASK. Restoring the mask allows the spl to > > successfully load the main u-boot. My board is an Altera HPS cyclone > > V socfpga. It has an ahb base address of 0xffa00000 and for some > > reason, without the CQSPI_INDIRECTTRIGGER_ADDR_MASK the board reboots > > when cadence_qspi_apb_indirect_read_execute tries to read from the ahb > > base address. I'm was using version 2016.11 of u-boot. > > This breaks TI platforms where INDIRECTTRIGGER_ADDR is 32bit wide. > Instead please try this patch series which adds cdns,trigger-address DT > property: http://patchwork.ozlabs.org/patch/838589/ > <http://patchwork.ozlabs.org/patch/838589/> > > Regards > Vignesh > > > > > Signed-off-by: Frank Mori Hess <fmh6jj@gmail.com > <mailto:fmh6jj@gmail.com>> > > --- > > drivers/spi/cadence_qspi_apb.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/spi/cadence_qspi_apb.c > b/drivers/spi/cadence_qspi_apb.c > > index e02f2217f4..b300f36607 100644 > > --- a/drivers/spi/cadence_qspi_apb.c > > +++ b/drivers/spi/cadence_qspi_apb.c > > @@ -47,6 +47,7 @@ > > #define CQSPI_INST_TYPE_QUAD 2 > > > > #define CQSPI_STIG_DATA_LEN_MAX 8 > > +#define CQSPI_INDIRECTTRIGGER_ADDR_MASK 0xFFFFF > > > > #define CQSPI_DUMMY_CLKS_PER_BYTE 8 > > #define CQSPI_DUMMY_BYTES_MAX 4 > > @@ -560,7 +561,7 @@ int > cadence_qspi_apb_indirect_read_setup(struct cadence_spi_platdata *plat, > > addr_bytes = cmdlen - 1; > > > > /* Setup the indirect trigger address */ > > - writel((u32)plat->ahbbase, > > + writel(((u32)plat->ahbbase & CQSPI_INDIRECTTRIGGER_ADDR_MASK), > > plat->regbase + CQSPI_REG_INDIRECTTRIGGER); > > > > /* Configure the opcode */ > > @@ -710,7 +711,7 @@ int > cadence_qspi_apb_indirect_write_setup(struct cadence_spi_platdata *plat, > > return -EINVAL; > > } > > /* Setup the indirect trigger address */ > > - writel((u32)plat->ahbbase, > > + writel(((u32)plat->ahbbase & CQSPI_INDIRECTTRIGGER_ADDR_MASK), > > plat->regbase + CQSPI_REG_INDIRECTTRIGGER); > > > > /* Configure the opcode */ > > > >
On Mon, Dec 4, 2017 at 11:41 AM, Vignesh R <vigneshr@ti.com> wrote: > Hi, > > On 04-Dec-17 6:41 PM, Frank Mori Hess wrote: >> Since your commit broke my platform to fix yours, shouldn't it be >> reverted and TI platforms use your pending patch queue? >> > > Socfpga DT defined ahb base as 0xffa00000 while masked upper bits in the > code, which was confusing. And seems that my patch did work on some > socfgpa board looking at the original commit message. There is nothing in the original commit message that suggests it worked on any socfpga board, unless you mean "Since AHB address is passed from DT and read as u32 value, it anyway does not make sense to mask upper bits." which is simply wrong. > If the patch is reverted then, applying pending patches alone will not > help because my patch would be needed anyway to make sure we don't mask > 31-20 bits on TI platforms. No it won't needed, see http://patchwork.ozlabs.org/patch/838592/ that patch series writes plat->trigger_address instead of ahbbase (masked or not).
On 04-Dec-17 10:31 PM, Frank Mori Hess wrote: > On Mon, Dec 4, 2017 at 11:41 AM, Vignesh R <vigneshr@ti.com> wrote: >> Hi, >> >> On 04-Dec-17 6:41 PM, Frank Mori Hess wrote: >>> Since your commit broke my platform to fix yours, shouldn't it be >>> reverted and TI platforms use your pending patch queue? >>> >> >> Socfpga DT defined ahb base as 0xffa00000 while masked upper bits in the >> code, which was confusing. And seems that my patch did work on some >> socfgpa board looking at the original commit message. > > There is nothing in the original commit message that suggests it > worked on any socfpga board, unless you mean > > "Since AHB address is passed from DT > and read as u32 value, it anyway does not make sense to mask upper bits." > > which is simply wrong. > There is a "Tested-by:" tag in the commit as well as: https://patchwork.ozlabs.org/patch/609955/ >> If the patch is reverted then, applying pending patches alone will not >> help because my patch would be needed anyway to make sure we don't mask >> 31-20 bits on TI platforms. > > No it won't needed, see http://patchwork.ozlabs.org/patch/838592/ that > patch series writes plat->trigger_address instead of ahbbase (masked > or not). > Okay, but reverting this patch would mean Jason has to rebase above patch. Instead applying that patch would anyway fix the issue.
diff --git a/drivers/spi/cadence_qspi_apb.c b/drivers/spi/cadence_qspi_apb.c index e02f2217f4..b300f36607 100644 --- a/drivers/spi/cadence_qspi_apb.c +++ b/drivers/spi/cadence_qspi_apb.c @@ -47,6 +47,7 @@ #define CQSPI_INST_TYPE_QUAD 2 #define CQSPI_STIG_DATA_LEN_MAX 8 +#define CQSPI_INDIRECTTRIGGER_ADDR_MASK 0xFFFFF #define CQSPI_DUMMY_CLKS_PER_BYTE 8 #define CQSPI_DUMMY_BYTES_MAX 4 @@ -560,7 +561,7 @@ int cadence_qspi_apb_indirect_read_setup(struct cadence_spi_platdata *plat, addr_bytes = cmdlen - 1; /* Setup the indirect trigger address */ - writel((u32)plat->ahbbase, + writel(((u32)plat->ahbbase & CQSPI_INDIRECTTRIGGER_ADDR_MASK), plat->regbase + CQSPI_REG_INDIRECTTRIGGER); /* Configure the opcode */ @@ -710,7 +711,7 @@ int cadence_qspi_apb_indirect_write_setup(struct cadence_spi_platdata *plat, return -EINVAL; } /* Setup the indirect trigger address */ - writel((u32)plat->ahbbase, + writel(((u32)plat->ahbbase & CQSPI_INDIRECTTRIGGER_ADDR_MASK), plat->regbase + CQSPI_REG_INDIRECTTRIGGER); /* Configure the opcode */
This reverts commit dac3bf20fb2c9b03476be0d73db620f62ab3cee1. My u-boot spl crashes in a loop when I boot off a cadence qspi flash. I narrowed it down to the changes from commit dac3bf20fb2c9b03476be0d73db620f62ab3cee1 which removes CQSPI_INDIRECTTRIGGER_ADDR_MASK. Restoring the mask allows the spl to successfully load the main u-boot. My board is an Altera HPS cyclone V socfpga. It has an ahb base address of 0xffa00000 and for some reason, without the CQSPI_INDIRECTTRIGGER_ADDR_MASK the board reboots when cadence_qspi_apb_indirect_read_execute tries to read from the ahb base address. I'm was using version 2016.11 of u-boot. Signed-off-by: Frank Mori Hess <fmh6jj@gmail.com> --- drivers/spi/cadence_qspi_apb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)