| Message ID | 20171125135438.22385-1-daggs@gmx.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [RPC] package/libtirpc: fix compilation error | expand |
On 25-11-17 14:54, Dagg Stompler wrote: > fix rpc_parse.c's compilation failure When sending a fix like this which is not visible in the autobuilders, make sure to also send a defconfig that reproduces it, as well as the build error itself. I took a look and I think this is about rpc_parse.c which include rpc/types.h. I believe the tirpc code is correct however. rpcgen is a host tool, so it makes sense to me that it uses the host's headers, not its own headers. rpc/types.h should be part of your system's libc, so how do you get a compilation failure? Regards, Arnout > > Signed-off-by: Dagg Stompler <daggs@gmx.com> > --- > package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch b/package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch > index 1cf861417c..fee91d4adc 100644 > --- a/package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch > +++ b/package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch > @@ -83,8 +83,8 @@ index 0000000..2277b6f > --- /dev/null > +++ b/rpcgen/Makefile.am > @@ -0,0 +1,22 @@ > -+COMPILE = $(CC_FOR_BUILD) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) \ > -+ $(CPPFLAGS_FOR_BUILD) $(AM_CFLAGS) $(CFLAGS_FOR_BUILD) > ++COMPILE = $(CC_FOR_BUILD) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) -I$(top_builddir)/tirpc \ > ++ $(AM_CPPFLAGS) $(CPPFLAGS_FOR_BUILD) $(AM_CFLAGS) $(CFLAGS_FOR_BUILD) > +LINK = $(CC_FOR_BUILD) $(AM_CFLAGS) $(CFLAGS_FOR_BUILD) $(AM_LDFLAGS) $(LDFLAGS_FOR_BUILD) -o $@ > + > +noinst_PROGRAMS = rpcgen >
Greetings Arnout, > Sent: Saturday, November 25, 2017 at 7:00 PM > From: "Arnout Vandecappelle" <arnout@mind.be> > To: "Dagg Stompler" <daggs@gmx.com>, buildroot@buildroot.org > Subject: Re: [Buildroot] [RPC] package/libtirpc: fix compilation error > > > > On 25-11-17 14:54, Dagg Stompler wrote: > > fix rpc_parse.c's compilation failure > > When sending a fix like this which is not visible in the autobuilders, make > sure to also send a defconfig that reproduces it, as well as the build error itself. > > I took a look and I think this is about rpc_parse.c which include rpc/types.h. > I believe the tirpc code is correct however. rpcgen is a host tool, so it makes > sense to me that it uses the host's headers, not its own headers. > > rpc/types.h should be part of your system's libc, so how do you get a > compilation failure? > the issue is with libtirpc which isn't an host program, is it a lib used for rpc. the patch in question is a patch added by Thomas and Yann. to reproduce it, run make raspberrypi2_defconfig on latest git, run menuconfig and select libtirpc. Dagg.
diff --git a/package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch b/package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch index 1cf861417c..fee91d4adc 100644 --- a/package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch +++ b/package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch @@ -83,8 +83,8 @@ index 0000000..2277b6f --- /dev/null +++ b/rpcgen/Makefile.am @@ -0,0 +1,22 @@ -+COMPILE = $(CC_FOR_BUILD) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) \ -+ $(CPPFLAGS_FOR_BUILD) $(AM_CFLAGS) $(CFLAGS_FOR_BUILD) ++COMPILE = $(CC_FOR_BUILD) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) -I$(top_builddir)/tirpc \ ++ $(AM_CPPFLAGS) $(CPPFLAGS_FOR_BUILD) $(AM_CFLAGS) $(CFLAGS_FOR_BUILD) +LINK = $(CC_FOR_BUILD) $(AM_CFLAGS) $(CFLAGS_FOR_BUILD) $(AM_LDFLAGS) $(LDFLAGS_FOR_BUILD) -o $@ + +noinst_PROGRAMS = rpcgen
fix rpc_parse.c's compilation failure Signed-off-by: Dagg Stompler <daggs@gmx.com> --- package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)