[Zesty/Artful] UBUNTU: SAUCE: make sure ubuntu/xr-usb-serial builds for x86

Message ID 1511165657-16619-1-git-send-email-jesse.sung@canonical.com
State New
Headers show
Series
  • [Zesty/Artful] UBUNTU: SAUCE: make sure ubuntu/xr-usb-serial builds for x86
Related show

Commit Message

Wen-chien Jesse Sung Nov. 20, 2017, 8:14 a.m.
BugLink: https://launchpad.net/bugs/1733281

The ubuntu/xr-usb-serial is expected to be built for i386 and x86_64,
and in ubuntu/Makefile it says:

ifneq ($(filter $(ARCH), i386 x86_64),)
obj-y += xr-usb-serial/
endif

Since ARCH is x86 for both i386 and x86_64, this condition will never be
true thus the module will never get a chance to be built.

Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
---
 ubuntu/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Po-Hsu Lin Nov. 20, 2017, 8:22 a.m. | #1
As per jesse's comment on IRC, we don't need this patch for Xenial since the module are different:

<jesse> PHLin: no, the patch applied to Xenial and Zesty/Artful to enable the module are different....

So
Acked-by: Po-Hsu Lin <po-hsu.lin@canonical.com>

Patch

diff --git a/ubuntu/Makefile b/ubuntu/Makefile
index ef16668..2c1e696 100644
--- a/ubuntu/Makefile
+++ b/ubuntu/Makefile
@@ -25,7 +25,7 @@  obj-$(CONFIG_HIO)             += hio/
 ##
 ##
 ##
-ifneq ($(filter $(ARCH), i386 x86_64),)
+ifeq ($(ARCH),x86)
 obj-y				+= xr-usb-serial/
 endif
 ##