| Message ID | 20171116120959.17554-2-mlang@blind.guru |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/2] brltty: new package | expand |
Hi Mario, On Thu, Nov 16, 2017 at 01:09:59PM +0100, Mario Lang wrote: > Signed-off-by: Mario Lang <mlang@blind.guru> > --- > DEVELOPERS | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/DEVELOPERS b/DEVELOPERS > index c39348a0b2..190e2b2f60 100644 > --- a/DEVELOPERS > +++ b/DEVELOPERS > @@ -1008,6 +1008,9 @@ F: package/polkit/ > F: package/sg3_utils/ > F: package/udisks/ > > +N: Mario Lang <mlang@blind.guru> > +F: package/brltty/ This should be included in the previous patch. Thanks, baruch > + > N: Mario Rugiero <mrugiero@gmail.com> > F: package/ratpoison/
Baruch Siach <baruch@tkos.co.il> writes: > On Thu, Nov 16, 2017 at 01:09:59PM +0100, Mario Lang wrote: >> Signed-off-by: Mario Lang <mlang@blind.guru> >> --- >> DEVELOPERS | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/DEVELOPERS b/DEVELOPERS >> index c39348a0b2..190e2b2f60 100644 >> --- a/DEVELOPERS >> +++ b/DEVELOPERS >> @@ -1008,6 +1008,9 @@ F: package/polkit/ >> F: package/sg3_utils/ >> F: package/udisks/ >> >> +N: Mario Lang <mlang@blind.guru> >> +F: package/brltty/ > > This should be included in the previous patch. I would have done so, but the current documentation suggests otherwise: "If you are interested in getting notified of build failures and of further changes in the packages you added or modified, please add yourself to the DEVELOPERS file. This should be done in a separate patch of the series." Maybe the documentation needs updating? Thanks for your feedback, will send an updated version of that patch later.
Hi Mario, On Thu, Nov 16, 2017 at 07:04:56PM +0100, Mario Lang wrote: > Baruch Siach <baruch@tkos.co.il> writes: > > > On Thu, Nov 16, 2017 at 01:09:59PM +0100, Mario Lang wrote: > >> Signed-off-by: Mario Lang <mlang@blind.guru> > >> --- > >> DEVELOPERS | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/DEVELOPERS b/DEVELOPERS > >> index c39348a0b2..190e2b2f60 100644 > >> --- a/DEVELOPERS > >> +++ b/DEVELOPERS > >> @@ -1008,6 +1008,9 @@ F: package/polkit/ > >> F: package/sg3_utils/ > >> F: package/udisks/ > >> > >> +N: Mario Lang <mlang@blind.guru> > >> +F: package/brltty/ > > > > This should be included in the previous patch. > > I would have done so, but the current documentation suggests otherwise: > > "If you are interested in getting notified of build failures and of > further changes in the packages you added or modified, please add > yourself to the DEVELOPERS file. This should be done in a separate > patch of the series." > > Maybe the documentation needs updating? The documentation has been updated in commit 8209d72211a (docs: update DEVELOPERS modification process). baruch
diff --git a/DEVELOPERS b/DEVELOPERS index c39348a0b2..190e2b2f60 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -1008,6 +1008,9 @@ F: package/polkit/ F: package/sg3_utils/ F: package/udisks/ +N: Mario Lang <mlang@blind.guru> +F: package/brltty/ + N: Mario Rugiero <mrugiero@gmail.com> F: package/ratpoison/
Signed-off-by: Mario Lang <mlang@blind.guru> --- DEVELOPERS | 3 +++ 1 file changed, 3 insertions(+)