| Message ID | 1510759526-30346-5-git-send-email-ulrich.hecht+renesas@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | R-Car D3 (r8a77995) I2C integration | expand |
Hi Ulrich, On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht <ulrich.hecht+renesas@gmail.com> wrote: > Enables EEPROM on I2C0 on the Draak board. > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > @@ -67,6 +72,18 @@ > }; > }; > > +&i2c0 { > + pinctrl-0 = <&i2c0_pins>; > + pinctrl-names = "default"; > + status = "okay"; > + > + eeprom@50 { > + compatible = "atmel,24c01"; This is actually a ROHM Semiconductor BR24T01FVM-W, so it should be compatible = "rohm,br24t01", "atmel,24c01"; Please also submit a patch to add that compatible value to Documentation/devicetree/bindings/eeprom/eeprom.txt. With the above fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Thu, Nov 16, 2017 at 10:27:56AM +0100, Geert Uytterhoeven wrote: > Hi Ulrich, > > On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht > <ulrich.hecht+renesas@gmail.com> wrote: > > Enables EEPROM on I2C0 on the Draak board. > > > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> > > Thanks for your patch! > > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > @@ -67,6 +72,18 @@ > > }; > > }; > > > > +&i2c0 { > > + pinctrl-0 = <&i2c0_pins>; > > + pinctrl-names = "default"; > > + status = "okay"; > > + > > + eeprom@50 { > > + compatible = "atmel,24c01"; > > This is actually a ROHM Semiconductor BR24T01FVM-W, so it should be > > compatible = "rohm,br24t01", "atmel,24c01"; Applied with the above change. > Please also submit a patch to add that compatible value to > Documentation/devicetree/bindings/eeprom/eeprom.txt. Ulrich, please follow-up on this, thanks! > With the above fixed: > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >
On Fri, Nov 17, 2017 at 06:31:21AM -0800, Simon Horman wrote: > On Thu, Nov 16, 2017 at 10:27:56AM +0100, Geert Uytterhoeven wrote: > > Hi Ulrich, > > > > On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht > > <ulrich.hecht+renesas@gmail.com> wrote: > > > Enables EEPROM on I2C0 on the Draak board. > > > > > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> > > > > Thanks for your patch! > > > > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > > > @@ -67,6 +72,18 @@ > > > }; > > > }; > > > > > > +&i2c0 { > > > + pinctrl-0 = <&i2c0_pins>; > > > + pinctrl-names = "default"; > > > + status = "okay"; > > > + > > > + eeprom@50 { > > > + compatible = "atmel,24c01"; > > > > This is actually a ROHM Semiconductor BR24T01FVM-W, so it should be > > > > compatible = "rohm,br24t01", "atmel,24c01"; > > Applied with the above change. Sorry, I was a bit hasty there as this patch depends on a patch earlier in the series which I have not applied. I've dropped this patch for now and will wait a bit longer for the review to unfold. > > > Please also submit a patch to add that compatible value to > > Documentation/devicetree/bindings/eeprom/eeprom.txt. > > Ulrich, please follow-up on this, thanks! > > > With the above fixed: > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > Gr{oetje,eeting}s, > > > > Geert > > > > -- > > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > > > In personal conversations with technical people, I call myself a hacker. But > > when I'm talking to journalists I just say "programmer" or something like that. > > -- Linus Torvalds > > >
Hi Ulrich, On 17/11/17 16:39, Simon Horman wrote: > On Fri, Nov 17, 2017 at 06:31:21AM -0800, Simon Horman wrote: >> On Thu, Nov 16, 2017 at 10:27:56AM +0100, Geert Uytterhoeven wrote: >>> Hi Ulrich, >>> >>> On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht >>> <ulrich.hecht+renesas@gmail.com> wrote: >>>> Enables EEPROM on I2C0 on the Draak board. >>>> >>>> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> >>> >>> Thanks for your patch! >>> >>>> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts >>>> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts >>> >>>> @@ -67,6 +72,18 @@ >>>> }; >>>> }; >>>> >>>> +&i2c0 { >>>> + pinctrl-0 = <&i2c0_pins>; >>>> + pinctrl-names = "default"; >>>> + status = "okay"; >>>> + >>>> + eeprom@50 { >>>> + compatible = "atmel,24c01"; >>> >>> This is actually a ROHM Semiconductor BR24T01FVM-W, so it should be >>> >>> compatible = "rohm,br24t01", "atmel,24c01"; >> >> Applied with the above change. > > Sorry, I was a bit hasty there as this patch > depends on a patch earlier in the series which I have not applied. > > I've dropped this patch for now and will wait a bit longer for the review > to unfold. > I am dependant upon this patch for my Draak-D3 work. Would you be able to consider the comments mentioned to progress this patch please? -- Regards Kieran >> >>> Please also submit a patch to add that compatible value to >>> Documentation/devicetree/bindings/eeprom/eeprom.txt. >> >> Ulrich, please follow-up on this, thanks! >> >>> With the above fixed: >>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> >>> >>> Gr{oetje,eeting}s, >>> >>> Geert >>> >>> -- >>> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org >>> >>> In personal conversations with technical people, I call myself a hacker. But >>> when I'm talking to journalists I just say "programmer" or something like that. >>> -- Linus Torvalds >>> >>
diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index 09de73b..64a6339 100644 --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts @@ -46,6 +46,11 @@ }; }; + i2c0_pins: i2c0 { + groups = "i2c0"; + function = "i2c0"; + }; + pwm0_pins: pwm0 { groups = "pwm0_c"; function = "pwm0"; @@ -67,6 +72,18 @@ }; }; +&i2c0 { + pinctrl-0 = <&i2c0_pins>; + pinctrl-names = "default"; + status = "okay"; + + eeprom@50 { + compatible = "atmel,24c01"; + reg = <0x50>; + pagesize = <8>; + }; +}; + &ehci0 { status = "okay"; };
Enables EEPROM on I2C0 on the Draak board. Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> --- arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)