[U-Boot] atcpit100: timer: Remove arch dependency.

Message ID 1510714988-20135-1-git-send-email-uboot@andestech.com
State New
Delegated to: Andes
Headers show
Series
  • [U-Boot] atcpit100: timer: Remove arch dependency.
Related show

Commit Message

Andes Nov. 15, 2017, 3:03 a.m.
From: Rick Chen <rick@andestech.com>

ATCPIT100 is often used in AE3XX platform which is
based on NDS32 architecture recently. But in the future
Andestech will have AE250 platform which is embeded
ATCPIT100 timer based on RISCV architecture.

Signed-off-by: Rick Chen <rick@andestech.com>
---
 drivers/timer/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass Nov. 20, 2017, 3:40 p.m. | #1
On 14 November 2017 at 20:03, Andes <uboot@andestech.com> wrote:
> From: Rick Chen <rick@andestech.com>

How come the patch does not come from that email?

>
> ATCPIT100 is often used in AE3XX platform which is
> based on NDS32 architecture recently. But in the future
> Andestech will have AE250 platform which is embeded
> ATCPIT100 timer based on RISCV architecture.
>
> Signed-off-by: Rick Chen <rick@andestech.com>
> ---
>  drivers/timer/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
rick@andestech.com Nov. 21, 2017, 6:50 a.m. | #2
> -----Original Message-----

> From: sjg@google.com [mailto:sjg@google.com] On Behalf Of Simon Glass

> Sent: Monday, November 20, 2017 11:40 PM

> To: Open Source Project uboot

> Cc: U-Boot Mailing List; Wolfgang Denk; Detlev Zundel; Rick Jian-Zhi Chen(陳建

> 志)

> Subject: Re: [PATCH] atcpit100: timer: Remove arch dependency.

>

> On 14 November 2017 at 20:03, Andes <uboot@andestech.com> wrote:

> > From: Rick Chen <rick@andestech.com>

>

> How come the patch does not come from that email?

>


I do not know what patch do you mean ?
I want to remove NDS32 in the string of "depends on TIMER && NDS32" in the Kconfig
Do I miss something or do something wrong ?

> >

> > ATCPIT100 is often used in AE3XX platform which is based on NDS32

> > architecture recently. But in the future Andestech will have AE250

> > platform which is embeded

> > ATCPIT100 timer based on RISCV architecture.

> >

> > Signed-off-by: Rick Chen <rick@andestech.com>

> > ---

> >  drivers/timer/Kconfig |    2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

>

> Reviewed-by: Simon Glass <sjg@chromium.org>

CONFIDENTIALITY NOTICE:

This e-mail (and its attachments) may contain confidential and legally privileged information or information protected from disclosure. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein is strictly prohibited. In this case, please immediately notify the sender by return e-mail, delete the message (and any accompanying documents) and destroy all printed hard copies. Thank you for your cooperation.

Copyright ANDES TECHNOLOGY CORPORATION - All Rights Reserved.
Simon Glass Nov. 24, 2017, 10:36 p.m. | #3
Hi Rick,

On 20 November 2017 at 23:50,  <rick@andestech.com> wrote:
>> -----Original Message-----
>> From: sjg@google.com [mailto:sjg@google.com] On Behalf Of Simon Glass
>> Sent: Monday, November 20, 2017 11:40 PM
>> To: Open Source Project uboot
>> Cc: U-Boot Mailing List; Wolfgang Denk; Detlev Zundel; Rick Jian-Zhi Chen(陳建
>> 志)
>> Subject: Re: [PATCH] atcpit100: timer: Remove arch dependency.
>>
>> On 14 November 2017 at 20:03, Andes <uboot@andestech.com> wrote:
>> > From: Rick Chen <rick@andestech.com>
>>
>> How come the patch does not come from that email?

I was just confused by the need for the 'From' line. It seems like
your email is rick@andestech.com, and this reply has come from there,
so I wondered why the patch does not come from you as well. It seems
to come from uboot@andestech.com.

>>
>
> I do not know what patch do you mean ?
> I want to remove NDS32 in the string of "depends on TIMER && NDS32" in the Kconfig
> Do I miss something or do something wrong ?
>
>> >
>> > ATCPIT100 is often used in AE3XX platform which is based on NDS32
>> > architecture recently. But in the future Andestech will have AE250
>> > platform which is embeded
>> > ATCPIT100 timer based on RISCV architecture.
>> >
>> > Signed-off-by: Rick Chen <rick@andestech.com>
>> > ---
>> >  drivers/timer/Kconfig |    2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
> CONFIDENTIALITY NOTICE:
>
> This e-mail (and its attachments) may contain confidential and legally privileged information or information protected from disclosure. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein is strictly prohibited. In this case, please immediately notify the sender by return e-mail, delete the message (and any accompanying documents) and destroy all printed hard copies. Thank you for your cooperation.
>
> Copyright ANDES TECHNOLOGY CORPORATION - All Rights Reserved.

Also please can you drop this from mailing list posts?

Regards,
Simon

Patch

diff --git a/drivers/timer/Kconfig b/drivers/timer/Kconfig
index fcfdf4e..3a1f831 100644
--- a/drivers/timer/Kconfig
+++ b/drivers/timer/Kconfig
@@ -107,7 +107,7 @@  config AG101P_TIMER
 
 config ATCPIT100_TIMER
 	bool "ATCPIT100 timer support"
-	depends on TIMER && NDS32
+	depends on TIMER
 	help
 	  Select this to enable a ATCPIT100 timer which will be embeded
 		in AE3XX, AE250 boards.