| Message ID | 20171110175102.21746-1-anton@advancedtelematic.com |
|---|---|
| State | Superseded |
| Delegated to: | Bin Meng |
| Headers | show |
| Series | [U-Boot] Move Cache-As-RAM memory from area mapped to ROM in QEMU | expand |
On Fri, Nov 10, 2017 at 06:51:02PM +0100, Anton Gerasimov wrote: > ROM has been made read-only in qemu recently (namely commit > 208fa0e43645edd0b0d8f838857dfc79daff40a8), so this patch restores > compatibility between u-boot and qemu. It is still broken for me > unless I set CONFIG_SMP=n and disable lapic (i.e. revert patch > aaaa55751ab1e5a5cfa0962d604593a7e6f33ff6 in u-boot), but these are > separate issues > > Signed-off-by: Anton Gerasimov <anton@advancedtelematic.com> > --- > arch/x86/cpu/qemu/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/cpu/qemu/Kconfig b/arch/x86/cpu/qemu/Kconfig > index 6808c9a6b9..f4b9922a34 100644 > --- a/arch/x86/cpu/qemu/Kconfig > +++ b/arch/x86/cpu/qemu/Kconfig > @@ -11,7 +11,7 @@ if QEMU > > config SYS_CAR_ADDR > hex > - default 0xd0000 > + default 0x10000 > > config SYS_CAR_SIZE > hex Bin, are you happy with this? Do you want this in before release? Thanks!
On 11/10/2017 06:51 PM, Anton Gerasimov wrote: > ROM has been made read-only in qemu recently (namely commit > 208fa0e43645edd0b0d8f838857dfc79daff40a8), so this patch restores > compatibility between u-boot and qemu. It is still broken for me > unless I set CONFIG_SMP=n and disable lapic (i.e. revert patch > aaaa55751ab1e5a5cfa0962d604593a7e6f33ff6 in u-boot), but these are > separate issues I could not reproduce that reverting aaaa55751ab1 is necessary. Your patch and CONFIG_SMP=n was suffcient to start U-Boot with qemu-system-x86_64 version 2.10.1(Debian 1:2.10.0+dfsg-2) Tested-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > > Signed-off-by: Anton Gerasimov <anton@advancedtelematic.com> > --- > arch/x86/cpu/qemu/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/cpu/qemu/Kconfig b/arch/x86/cpu/qemu/Kconfig > index 6808c9a6b9..f4b9922a34 100644 > --- a/arch/x86/cpu/qemu/Kconfig > +++ b/arch/x86/cpu/qemu/Kconfig > @@ -11,7 +11,7 @@ if QEMU > > config SYS_CAR_ADDR > hex > - default 0xd0000 > + default 0x10000 > > config SYS_CAR_SIZE > hex >
Thank you Heinrich, I can confirm that current u-boot master works without reverting aaaa55751ab1. I had problems with u-boot v2017.11-rc2 apparently. Best regards, Anton Gerasimov On 11/11/2017 12:08 PM, Heinrich Schuchardt wrote: > On 11/10/2017 06:51 PM, Anton Gerasimov wrote: >> ROM has been made read-only in qemu recently (namely commit >> 208fa0e43645edd0b0d8f838857dfc79daff40a8), so this patch restores >> compatibility between u-boot and qemu. It is still broken for me >> unless I set CONFIG_SMP=n and disable lapic (i.e. revert patch >> aaaa55751ab1e5a5cfa0962d604593a7e6f33ff6 in u-boot), but these are >> separate issues > > I could not reproduce that reverting aaaa55751ab1 is necessary. > Your patch and CONFIG_SMP=n was suffcient to start U-Boot with > qemu-system-x86_64 version 2.10.1(Debian 1:2.10.0+dfsg-2) > > Tested-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > >> >> Signed-off-by: Anton Gerasimov <anton@advancedtelematic.com> >> --- >> arch/x86/cpu/qemu/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/x86/cpu/qemu/Kconfig b/arch/x86/cpu/qemu/Kconfig >> index 6808c9a6b9..f4b9922a34 100644 >> --- a/arch/x86/cpu/qemu/Kconfig >> +++ b/arch/x86/cpu/qemu/Kconfig >> @@ -11,7 +11,7 @@ if QEMU >> config SYS_CAR_ADDR >> hex >> - default 0xd0000 >> + default 0x10000 >> config SYS_CAR_SIZE >> hex >> >
On 11/13/2017 11:23 AM, Anton Gerasimov wrote: > Thank you Heinrich, I can confirm that current u-boot master works > without reverting aaaa55751ab1. I had problems with u-boot v2017.11-rc2 > apparently. Could you, please, resubmit the patch with an updated commit message. Regards Heinrich > > Best regards, > Anton Gerasimov > > On 11/11/2017 12:08 PM, Heinrich Schuchardt wrote: >> On 11/10/2017 06:51 PM, Anton Gerasimov wrote: >>> ROM has been made read-only in qemu recently (namely commit >>> 208fa0e43645edd0b0d8f838857dfc79daff40a8), so this patch restores >>> compatibility between u-boot and qemu. It is still broken for me >>> unless I set CONFIG_SMP=n and disable lapic (i.e. revert patch >>> aaaa55751ab1e5a5cfa0962d604593a7e6f33ff6 in u-boot), but these are >>> separate issues >> >> I could not reproduce that reverting aaaa55751ab1 is necessary. >> Your patch and CONFIG_SMP=n was suffcient to start U-Boot with >> qemu-system-x86_64 version 2.10.1(Debian 1:2.10.0+dfsg-2) >> >> Tested-by: Heinrich Schuchardt <xypron.glpk@gmx.de> >> >>> >>> Signed-off-by: Anton Gerasimov <anton@advancedtelematic.com> >>> --- >>> arch/x86/cpu/qemu/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/x86/cpu/qemu/Kconfig b/arch/x86/cpu/qemu/Kconfig >>> index 6808c9a6b9..f4b9922a34 100644 >>> --- a/arch/x86/cpu/qemu/Kconfig >>> +++ b/arch/x86/cpu/qemu/Kconfig >>> @@ -11,7 +11,7 @@ if QEMU >>> config SYS_CAR_ADDR >>> hex >>> - default 0xd0000 >>> + default 0x10000 >>> config SYS_CAR_SIZE >>> hex >>> >> >
diff --git a/arch/x86/cpu/qemu/Kconfig b/arch/x86/cpu/qemu/Kconfig index 6808c9a6b9..f4b9922a34 100644 --- a/arch/x86/cpu/qemu/Kconfig +++ b/arch/x86/cpu/qemu/Kconfig @@ -11,7 +11,7 @@ if QEMU config SYS_CAR_ADDR hex - default 0xd0000 + default 0x10000 config SYS_CAR_SIZE hex
ROM has been made read-only in qemu recently (namely commit 208fa0e43645edd0b0d8f838857dfc79daff40a8), so this patch restores compatibility between u-boot and qemu. It is still broken for me unless I set CONFIG_SMP=n and disable lapic (i.e. revert patch aaaa55751ab1e5a5cfa0962d604593a7e6f33ff6 in u-boot), but these are separate issues Signed-off-by: Anton Gerasimov <anton@advancedtelematic.com> --- arch/x86/cpu/qemu/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)