| Message ID | 1509621307-152457-1-git-send-email-weiyongjun1@huawei.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] cxgb4: fix error return code in cxgb4_set_hash_filter() | expand |
On Thursday, November 11/02/17, 2017 at 11:15:07 +0000, Wei Yongjun wrote: > Fix to return a negative error code from thecxgb4_alloc_atid() > error handling case instead of 0. > > Fixes: 12b276fbf6e0 ("cxgb4: add support to create hash filters") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c > index abab67d..5980f30 100644 > --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c > +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c > @@ -1110,8 +1110,10 @@ static int cxgb4_set_hash_filter(struct net_device *dev, > } > > atid = cxgb4_alloc_atid(t, f); > - if (atid < 0) > + if (atid < 0) { > + ret = atid; > goto free_smt; > + } > > iconf = adapter->params.tp.ingress_config; > if (iconf & VNIC_F) { > Thank you for the fix. Acked-By: Kumar Sanghvi <kumaras@chelsio.com>
From: Wei Yongjun <weiyongjun1@huawei.com> Date: Thu, 2 Nov 2017 11:15:07 +0000 > Fix to return a negative error code from thecxgb4_alloc_atid() > error handling case instead of 0. > > Fixes: 12b276fbf6e0 ("cxgb4: add support to create hash filters") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Applied.
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c index abab67d..5980f30 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c @@ -1110,8 +1110,10 @@ static int cxgb4_set_hash_filter(struct net_device *dev, } atid = cxgb4_alloc_atid(t, f); - if (atid < 0) + if (atid < 0) { + ret = atid; goto free_smt; + } iconf = adapter->params.tp.ingress_config; if (iconf & VNIC_F) {
Fix to return a negative error code from thecxgb4_alloc_atid() error handling case instead of 0. Fixes: 12b276fbf6e0 ("cxgb4: add support to create hash filters") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)