From patchwork Thu Nov 2 11:15:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 833305 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ySMqQ3MsVz9s9Y for ; Thu, 2 Nov 2017 22:12:02 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755789AbdKBLMA (ORCPT ); Thu, 2 Nov 2017 07:12:00 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:57706 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1755760AbdKBLL4 (ORCPT ); Thu, 2 Nov 2017 07:11:56 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 01064487F78DC; Thu, 2 Nov 2017 19:11:43 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.361.1; Thu, 2 Nov 2017 19:11:36 +0800 From: Wei Yongjun To: Ganesh Goudar , Kumar Sanghvi CC: Wei Yongjun , Subject: [PATCH net-next] cxgb4: fix error return code in cxgb4_set_hash_filter() Date: Thu, 2 Nov 2017 11:15:07 +0000 Message-ID: <1509621307-152457-1-git-send-email-weiyongjun1@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix to return a negative error code from thecxgb4_alloc_atid() error handling case instead of 0. Fixes: 12b276fbf6e0 ("cxgb4: add support to create hash filters") Signed-off-by: Wei Yongjun Acked-By: Kumar Sanghvi --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c index abab67d..5980f30 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c @@ -1110,8 +1110,10 @@ static int cxgb4_set_hash_filter(struct net_device *dev, } atid = cxgb4_alloc_atid(t, f); - if (atid < 0) + if (atid < 0) { + ret = atid; goto free_smt; + } iconf = adapter->params.tp.ingress_config; if (iconf & VNIC_F) {