diff mbox series

[U-Boot] rockchip: config: update part table

Message ID 1509439943-32213-1-git-send-email-kever.yang@rock-chips.com
State Accepted
Commit c5a4141343e601bac2789c137e8be665c074f898
Delegated to: Philipp Tomsich
Headers show
Series [U-Boot] rockchip: config: update part table | expand

Commit Message

Kever Yang Oct. 31, 2017, 8:52 a.m. UTC
User do not need to access the reserved part in system, remove them
from partition table.
Rename atf to trust as generic name for armv7 do not use ATF.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

 include/configs/rockchip-common.h | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Eddie Cai Nov. 1, 2017, 12:36 a.m. UTC | #1
Hi Kever
The reserved partition is not only for U-Boot but also for system.
There are customers using reserved partition in system now.

2017-10-31 16:52 GMT+08:00 Kever Yang <kever.yang@rock-chips.com>:
> User do not need to access the reserved part in system, remove them
> from partition table.
> Rename atf to trust as generic name for armv7 do not use ATF.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
>  include/configs/rockchip-common.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
> index 35d948a..4139a7b 100644
> --- a/include/configs/rockchip-common.h
> +++ b/include/configs/rockchip-common.h
> @@ -52,10 +52,8 @@
>  #define PARTS_DEFAULT \
>         "uuid_disk=${uuid_gpt_disk};" \
>         "name=loader1,start=32K,size=4000K,uuid=${uuid_gpt_loader1};" \
> -       "name=reserved1,size=64K,uuid=${uuid_gpt_reserved1};" \
> -       "name=reserved2,size=4M,uuid=${uuid_gpt_reserved2};" \
> -       "name=loader2,size=4MB,uuid=${uuid_gpt_loader2};" \
> -       "name=atf,size=4M,uuid=${uuid_gpt_atf};" \
> +       "name=loader2,start=8MB,size=4MB,uuid=${uuid_gpt_loader2};" \
> +       "name=trust,size=4M,uuid=${uuid_gpt_atf};" \
>         "name=boot,size=112M,bootable,uuid=${uuid_gpt_boot};" \
>         "name=rootfs,size=-,uuid="ROOT_UUID
>
> --
> 1.9.1
>
Jacob Chen Nov. 2, 2017, 1:09 a.m. UTC | #2
Hi,

2017-11-01 8:36 GMT+08:00 Eddie Cai <eddie.cai.linux@gmail.com>:
> Hi Kever
> The reserved partition is not only for U-Boot but also for system.
> There are customers using reserved partition in system now.
>


It's ok to hide them, since we just use offset, not partition index.


> 2017-10-31 16:52 GMT+08:00 Kever Yang <kever.yang@rock-chips.com>:
>> User do not need to access the reserved part in system, remove them
>> from partition table.
>> Rename atf to trust as generic name for armv7 do not use ATF.
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> ---
>>
>>  include/configs/rockchip-common.h | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
>> index 35d948a..4139a7b 100644
>> --- a/include/configs/rockchip-common.h
>> +++ b/include/configs/rockchip-common.h
>> @@ -52,10 +52,8 @@
>>  #define PARTS_DEFAULT \
>>         "uuid_disk=${uuid_gpt_disk};" \
>>         "name=loader1,start=32K,size=4000K,uuid=${uuid_gpt_loader1};" \
>> -       "name=reserved1,size=64K,uuid=${uuid_gpt_reserved1};" \
>> -       "name=reserved2,size=4M,uuid=${uuid_gpt_reserved2};" \
>> -       "name=loader2,size=4MB,uuid=${uuid_gpt_loader2};" \
>> -       "name=atf,size=4M,uuid=${uuid_gpt_atf};" \
>> +       "name=loader2,start=8MB,size=4MB,uuid=${uuid_gpt_loader2};" \
>> +       "name=trust,size=4M,uuid=${uuid_gpt_atf};" \
>>         "name=boot,size=112M,bootable,uuid=${uuid_gpt_boot};" \
>>         "name=rootfs,size=-,uuid="ROOT_UUID
>>
>> --
>> 1.9.1
>>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
Philipp Tomsich Nov. 20, 2017, 2:52 p.m. UTC | #3
On Tue, 31 Oct 2017, Kever Yang wrote:

> User do not need to access the reserved part in system, remove them
> from partition table.
> Rename atf to trust as generic name for armv7 do not use ATF.

Is this still something that is required following Jacob's comment?

Thanks,
Phil.

>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> include/configs/rockchip-common.h | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
> index 35d948a..4139a7b 100644
> --- a/include/configs/rockchip-common.h
> +++ b/include/configs/rockchip-common.h
> @@ -52,10 +52,8 @@
> #define PARTS_DEFAULT \
> 	"uuid_disk=${uuid_gpt_disk};" \
> 	"name=loader1,start=32K,size=4000K,uuid=${uuid_gpt_loader1};" \
> -	"name=reserved1,size=64K,uuid=${uuid_gpt_reserved1};" \
> -	"name=reserved2,size=4M,uuid=${uuid_gpt_reserved2};" \
> -	"name=loader2,size=4MB,uuid=${uuid_gpt_loader2};" \
> -	"name=atf,size=4M,uuid=${uuid_gpt_atf};" \
> +	"name=loader2,start=8MB,size=4MB,uuid=${uuid_gpt_loader2};" \
> +	"name=trust,size=4M,uuid=${uuid_gpt_atf};" \
> 	"name=boot,size=112M,bootable,uuid=${uuid_gpt_boot};" \
> 	"name=rootfs,size=-,uuid="ROOT_UUID
>
>
Kever Yang Dec. 15, 2017, 9:04 a.m. UTC | #4
Hi Philipp,

     Yes, this is required, we do not need to show the reserved 
partitions to users.


Thanks,
- Kever
On 11/20/2017 10:52 PM, Philipp Tomsich wrote:
>
>
> On Tue, 31 Oct 2017, Kever Yang wrote:
>
>> User do not need to access the reserved part in system, remove them
>> from partition table.
>> Rename atf to trust as generic name for armv7 do not use ATF.
>
> Is this still something that is required following Jacob's comment?
>
> Thanks,
> Phil.
>
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> ---
>>
>> include/configs/rockchip-common.h | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/include/configs/rockchip-common.h 
>> b/include/configs/rockchip-common.h
>> index 35d948a..4139a7b 100644
>> --- a/include/configs/rockchip-common.h
>> +++ b/include/configs/rockchip-common.h
>> @@ -52,10 +52,8 @@
>> #define PARTS_DEFAULT \
>>     "uuid_disk=${uuid_gpt_disk};" \
>>     "name=loader1,start=32K,size=4000K,uuid=${uuid_gpt_loader1};" \
>> -    "name=reserved1,size=64K,uuid=${uuid_gpt_reserved1};" \
>> -    "name=reserved2,size=4M,uuid=${uuid_gpt_reserved2};" \
>> -    "name=loader2,size=4MB,uuid=${uuid_gpt_loader2};" \
>> -    "name=atf,size=4M,uuid=${uuid_gpt_atf};" \
>> +    "name=loader2,start=8MB,size=4MB,uuid=${uuid_gpt_loader2};" \
>> +    "name=trust,size=4M,uuid=${uuid_gpt_atf};" \
>>     "name=boot,size=112M,bootable,uuid=${uuid_gpt_boot};" \
>>     "name=rootfs,size=-,uuid="ROOT_UUID
>>
>>
>
Philipp Tomsich Dec. 15, 2017, 9:12 a.m. UTC | #5
> User do not need to access the reserved part in system, remove them
> from partition table.
> Rename atf to trust as generic name for armv7 do not use ATF.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
>  include/configs/rockchip-common.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich Dec. 15, 2017, 3:58 p.m. UTC | #6
> User do not need to access the reserved part in system, remove them
> from partition table.
> Rename atf to trust as generic name for armv7 do not use ATF.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
>  include/configs/rockchip-common.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich Dec. 17, 2017, 4:04 p.m. UTC | #7
> User do not need to access the reserved part in system, remove them
> from partition table.
> Rename atf to trust as generic name for armv7 do not use ATF.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
>  include/configs/rockchip-common.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 

Applied to u-boot-rockchip, thanks!
Philipp Tomsich Dec. 18, 2017, 4:05 p.m. UTC | #8
> User do not need to access the reserved part in system, remove them
> from partition table.
> Rename atf to trust as generic name for armv7 do not use ATF.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
>  include/configs/rockchip-common.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
diff mbox series

Patch

diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
index 35d948a..4139a7b 100644
--- a/include/configs/rockchip-common.h
+++ b/include/configs/rockchip-common.h
@@ -52,10 +52,8 @@ 
 #define PARTS_DEFAULT \
 	"uuid_disk=${uuid_gpt_disk};" \
 	"name=loader1,start=32K,size=4000K,uuid=${uuid_gpt_loader1};" \
-	"name=reserved1,size=64K,uuid=${uuid_gpt_reserved1};" \
-	"name=reserved2,size=4M,uuid=${uuid_gpt_reserved2};" \
-	"name=loader2,size=4MB,uuid=${uuid_gpt_loader2};" \
-	"name=atf,size=4M,uuid=${uuid_gpt_atf};" \
+	"name=loader2,start=8MB,size=4MB,uuid=${uuid_gpt_loader2};" \
+	"name=trust,size=4M,uuid=${uuid_gpt_atf};" \
 	"name=boot,size=112M,bootable,uuid=${uuid_gpt_boot};" \
 	"name=rootfs,size=-,uuid="ROOT_UUID