| Message ID | 1509345661-10352-1-git-send-email-Ashish.Kumar@nxp.com |
|---|---|
| State | Superseded |
| Delegated to: | York Sun |
| Headers | show |
| Series | [U-Boot,V2,1/2] armv8: ls1088ardb: Add SCSI related configs in header file for RDB | expand |
On 10/29/2017 11:40 PM, Ashish Kumar wrote: > Signed-off-by: Amrita Kumari <amrita.kumari@nxp.com> > Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com> > --- Change log? > include/configs/ls1088ardb.h | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/include/configs/ls1088ardb.h b/include/configs/ls1088ardb.h > index 958d472..8fdc576 100644 > --- a/include/configs/ls1088ardb.h > +++ b/include/configs/ls1088ardb.h > @@ -293,6 +293,19 @@ > #define CONFIG_PHY_GIGE > #endif > > +/* SATA */ > +#define CONFIG_LIBATA > +#define CONFIG_SCSI_AHCI > +#define CONFIG_SCSI_AHCI_PLAT > +#define CONFIG_CMD_SCSI > +#define CONFIG_SCSI > +#define CONFIG_SYS_SATA1 AHCI_BASE_ADDR1 > + > +#define CONFIG_SYS_SCSI_MAX_SCSI_ID 1 > +#define CONFIG_SYS_SCSI_MAX_LUN 1 > +#define CONFIG_SYS_SCSI_MAX_DEVICE (CONFIG_SYS_SCSI_MAX_SCSI_ID * \ > + CONFIG_SYS_SCSI_MAX_LUN) > + > /* MMC */ > #ifdef CONFIG_MMC > #define CONFIG_FSL_ESDHC > Please check my comments to your first version. It still applied. York
On 10/30/2017 12:06 PM, York Sun wrote: > On 10/29/2017 11:40 PM, Ashish Kumar wrote: >> Signed-off-by: Amrita Kumari <amrita.kumari@nxp.com> >> Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com> >> --- > > Change log? > >> include/configs/ls1088ardb.h | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/include/configs/ls1088ardb.h b/include/configs/ls1088ardb.h >> index 958d472..8fdc576 100644 >> --- a/include/configs/ls1088ardb.h >> +++ b/include/configs/ls1088ardb.h >> @@ -293,6 +293,19 @@ >> #define CONFIG_PHY_GIGE >> #endif >> >> +/* SATA */ >> +#define CONFIG_LIBATA >> +#define CONFIG_SCSI_AHCI >> +#define CONFIG_SCSI_AHCI_PLAT >> +#define CONFIG_CMD_SCSI >> +#define CONFIG_SCSI >> +#define CONFIG_SYS_SATA1 AHCI_BASE_ADDR1 >> + >> +#define CONFIG_SYS_SCSI_MAX_SCSI_ID 1 >> +#define CONFIG_SYS_SCSI_MAX_LUN 1 >> +#define CONFIG_SYS_SCSI_MAX_DEVICE (CONFIG_SYS_SCSI_MAX_SCSI_ID * \ >> + CONFIG_SYS_SCSI_MAX_LUN) >> + >> /* MMC */ >> #ifdef CONFIG_MMC >> #define CONFIG_FSL_ESDHC >> > > Please check my comments to your first version. It still applied. Sorry, my bad. My comment was on the patch submitted by Andy Tang. You both changed the same. Please work together to update the patches. York
-----Original Message----- From: York Sun Sent: Tuesday, October 31, 2017 12:37 AM To: Ashish Kumar <ashish.kumar@nxp.com>; u-boot@lists.denx.de Cc: Amrita Kumari <amrita.kumari@nxp.com> Subject: Re: [Patch V2 1/2] armv8: ls1088ardb: Add SCSI related configs in header file for RDB On 10/30/2017 12:06 PM, York Sun wrote: > On 10/29/2017 11:40 PM, Ashish Kumar wrote: >> Signed-off-by: Amrita Kumari <amrita.kumari@nxp.com> >> Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com> >> --- > > Change log? > >> include/configs/ls1088ardb.h | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/include/configs/ls1088ardb.h >> b/include/configs/ls1088ardb.h index 958d472..8fdc576 100644 >> --- a/include/configs/ls1088ardb.h >> +++ b/include/configs/ls1088ardb.h >> @@ -293,6 +293,19 @@ >> #define CONFIG_PHY_GIGE >> #endif >> >> +/* SATA */ >> +#define CONFIG_LIBATA >> +#define CONFIG_SCSI_AHCI >> +#define CONFIG_SCSI_AHCI_PLAT >> +#define CONFIG_CMD_SCSI >> +#define CONFIG_SCSI >> +#define CONFIG_SYS_SATA1 AHCI_BASE_ADDR1 >> + >> +#define CONFIG_SYS_SCSI_MAX_SCSI_ID 1 >> +#define CONFIG_SYS_SCSI_MAX_LUN 1 >> +#define CONFIG_SYS_SCSI_MAX_DEVICE (CONFIG_SYS_SCSI_MAX_SCSI_ID * \ >> + CONFIG_SYS_SCSI_MAX_LUN) >> + >> /* MMC */ >> #ifdef CONFIG_MMC >> #define CONFIG_FSL_ESDHC >> > > Please check my comments to your first version. It still applied. Sorry, my bad. My comment was on the patch submitted by Andy Tang. You both changed the same. Please work together to update the patches. As discussed with Andy, I will send next version. Andy to supersede his patch set. Regards Ashish York
diff --git a/include/configs/ls1088ardb.h b/include/configs/ls1088ardb.h index 958d472..8fdc576 100644 --- a/include/configs/ls1088ardb.h +++ b/include/configs/ls1088ardb.h @@ -293,6 +293,19 @@ #define CONFIG_PHY_GIGE #endif +/* SATA */ +#define CONFIG_LIBATA +#define CONFIG_SCSI_AHCI +#define CONFIG_SCSI_AHCI_PLAT +#define CONFIG_CMD_SCSI +#define CONFIG_SCSI +#define CONFIG_SYS_SATA1 AHCI_BASE_ADDR1 + +#define CONFIG_SYS_SCSI_MAX_SCSI_ID 1 +#define CONFIG_SYS_SCSI_MAX_LUN 1 +#define CONFIG_SYS_SCSI_MAX_DEVICE (CONFIG_SYS_SCSI_MAX_SCSI_ID * \ + CONFIG_SYS_SCSI_MAX_LUN) + /* MMC */ #ifdef CONFIG_MMC #define CONFIG_FSL_ESDHC