Message ID | 1508343141-31835-1-git-send-email-pbonzini@redhat.com |
---|---|
State | New |
Headers | show |
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1508343141-31835-1-git-send-email-pbonzini@redhat.com Subject: [Qemu-devel] [PULL 00/29] Misc patches for 2017-10-18 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20171018170138.19078-1-dgilbert@redhat.com -> patchew/20171018170138.19078-1-dgilbert@redhat.com Switched to a new branch 'test' ddf5f0fd53 scsi: reject configurations with logical block size > physical block size d6c780ef4a qdev: defer DEVICE_DEL event until instance_finalize() 59877522d9 Revert "qdev: Free QemuOpts when the QOM path goes away" 262daf3cfb qdev: store DeviceState's canonical path to use when unparenting 7e71e1069a qemu-pr-helper: use new libmultipath API eb4c2f258b watch_mem_write: implement 8-byte accesses 1e543aec92 notdirty_mem_write: implement 8-byte accesses cfdda4621b memory: reuse section_from_flat_range() 49cfdcaf2f kvm: simplify kvm_align_section() 2436b118fd kvm: region_add and region_del is not called on updates 105a4b17f7 kvm: fix error message when failing to unregister slot ffbfafda7f kvm: tolerate non-existing slot for log_start/log_stop/log_sync f2e1adbc75 kvm: fix alignment of ram address c950b87b75 memory: call log_start after region_add b396744e40 target/i386: trap on instructions longer than >15 bytes 8ff591fc32 target/i386: introduce x86_ld*_code 005c3cd495 tco: add trace events 337d49e940 docs/devel/loads-stores.rst: Document our various load and store APIs 2afb7e8244 nios2: define tcg_env 14589aebe5 build: remove CONFIG_LIBDECNUMBER 52d6bdeec1 disas: Always initialize read_memory_inner_func properly 39d88c4a9e pc: make sure that plugged CPUs are of the same type aacc1d66c0 memory: fix off-by-one error in memory_region_notify_one() aa23b0ddd4 exec: simplify address_space_get_iotlb_entry de39bf7eee exec: add page_mask for flatview_do_translate 94a9bb400c char: don't skip client cleanup if 'connected' flag is unset eabec1e383 ide: support reporting of rotation rate dfbb026ca5 scsi-disk: support reporting of rotation rate f19f1e6276 checkpatch: refine mode selection === OUTPUT BEGIN === Checking PATCH 1/29: checkpatch: refine mode selection... Checking PATCH 2/29: scsi-disk: support reporting of rotation rate... Checking PATCH 3/29: ide: support reporting of rotation rate... Checking PATCH 4/29: char: don't skip client cleanup if 'connected' flag is unset... Checking PATCH 5/29: exec: add page_mask for flatview_do_translate... Checking PATCH 6/29: exec: simplify address_space_get_iotlb_entry... Checking PATCH 7/29: memory: fix off-by-one error in memory_region_notify_one()... Checking PATCH 8/29: pc: make sure that plugged CPUs are of the same type... ERROR: space required before the open parenthesis '(' #35: FILE: hw/i386/pc.c:1882: + if(!object_dynamic_cast(OBJECT(cpu), ms->cpu_type)) { total: 1 errors, 0 warnings, 15 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 9/29: disas: Always initialize read_memory_inner_func properly... Checking PATCH 10/29: build: remove CONFIG_LIBDECNUMBER... Checking PATCH 11/29: nios2: define tcg_env... Checking PATCH 12/29: docs/devel/loads-stores.rst: Document our various load and store APIs... Checking PATCH 13/29: tco: add trace events... Checking PATCH 14/29: target/i386: introduce x86_ld*_code... Checking PATCH 15/29: target/i386: trap on instructions longer than >15 bytes... ERROR: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #69: FILE: target/i386/translate.c:1881: + volatile uint8_t unused = total: 1 errors, 0 warnings, 53 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 16/29: memory: call log_start after region_add... Checking PATCH 17/29: kvm: fix alignment of ram address... Checking PATCH 18/29: kvm: tolerate non-existing slot for log_start/log_stop/log_sync... Checking PATCH 19/29: kvm: fix error message when failing to unregister slot... Checking PATCH 20/29: kvm: region_add and region_del is not called on updates... Checking PATCH 21/29: kvm: simplify kvm_align_section()... Checking PATCH 22/29: memory: reuse section_from_flat_range()... Checking PATCH 23/29: notdirty_mem_write: implement 8-byte accesses... Checking PATCH 24/29: watch_mem_write: implement 8-byte accesses... Checking PATCH 25/29: qemu-pr-helper: use new libmultipath API... ERROR: externs should be avoided in .c files #54: FILE: scsi/qemu-pr-helper.c:284: +extern struct config *get_multipath_config(void); ERROR: externs should be avoided in .c files #61: FILE: scsi/qemu-pr-helper.c:290: +extern void put_multipath_config(struct config *conf); total: 2 errors, 0 warnings, 48 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 26/29: qdev: store DeviceState's canonical path to use when unparenting... Checking PATCH 27/29: Revert "qdev: Free QemuOpts when the QOM path goes away"... Checking PATCH 28/29: qdev: defer DEVICE_DEL event until instance_finalize()... Checking PATCH 29/29: scsi: reject configurations with logical block size > physical block size... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org
On 18 October 2017 at 17:11, Paolo Bonzini <pbonzini@redhat.com> wrote: > The following changes since commit a0b261db8c030813e30a39eae47359ac2a37f7e2: > > Merge remote-tracking branch 'remotes/ehabkost/tags/python-next-pull-request' into staging (2017-10-12 10:02:09 +0100) > > are available in the git repository at: > > > git://github.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to 3da023b5827543ee4c022986ea2ad9d1274410b2: > > scsi: reject configurations with logical block size > physical block size (2017-10-18 11:56:14 +0200) > > ---------------------------------------------------------------- > * TCG 8-byte atomic accesses bugfix (Andrew) > * Report disk rotation rate (Daniel) > * Report invalid scsi-disk block size configuration (Mark) > * KVM and memory API MemoryListener fixes (David, Maxime, Peter Xu) > * x86 CPU hotplug crash fix (Igor) > * Load/store API documentation (Peter Maydell) > * Small fixes by myself and Thomas > * qdev DEVICE_DELETED deferral (Michael) > Applied, thanks. -- PMM