| Message ID | 1507906212-10076-6-git-send-email-madalin.bucur@nxp.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | adapt DPAA drivers for DSA | expand |
On 10/13/2017 07:50 AM, Madalin Bucur wrote: > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> You should provide a line or two to explain why are you making this change, it is to resolve modular build configurations? > --- > drivers/net/ethernet/freescale/fman/Makefile | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/fman/Makefile b/drivers/net/ethernet/freescale/fman/Makefile > index 2c38119..4ae524a 100644 > --- a/drivers/net/ethernet/freescale/fman/Makefile > +++ b/drivers/net/ethernet/freescale/fman/Makefile > @@ -1,9 +1,9 @@ > subdir-ccflags-y += -I$(srctree)/drivers/net/ethernet/freescale/fman > > -obj-$(CONFIG_FSL_FMAN) += fsl_fman.o > -obj-$(CONFIG_FSL_FMAN) += fsl_fman_port.o > -obj-$(CONFIG_FSL_FMAN) += fsl_mac.o > +obj-$(CONFIG_FSL_FMAN) += fsl_dpaa_fman.o > +obj-$(CONFIG_FSL_FMAN) += fsl_dpaa_fman_port.o > +obj-$(CONFIG_FSL_FMAN) += fsl_dpaa_mac.o > > -fsl_fman-objs := fman_muram.o fman.o fman_sp.o fman_keygen.o > -fsl_fman_port-objs := fman_port.o > -fsl_mac-objs:= mac.o fman_dtsec.o fman_memac.o fman_tgec.o > +fsl_dpaa_fman-objs := fman_muram.o fman.o fman_sp.o fman_keygen.o > +fsl_dpaa_fman_port-objs := fman_port.o > +fsl_dpaa_mac-objs:= mac.o fman_dtsec.o fman_memac.o fman_tgec.o >
> -----Original Message----- > From: Florian Fainelli [mailto:f.fainelli@gmail.com] > Sent: Friday, October 13, 2017 8:39 PM > To: Madalin-cristian Bucur <madalin.bucur@nxp.com>; > netdev@vger.kernel.org; davem@davemloft.net > Cc: andrew@lunn.ch; vivien.didelot@savoirfairelinux.com; > junote@outlook.com; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 5/5] fsl/fman: add dpaa in module names > > On 10/13/2017 07:50 AM, Madalin Bucur wrote: > > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> > > You should provide a line or two to explain why are you making this > change, it is to resolve modular build configurations? This change just renames the FMan driver modules, using a common prefix for the DPAA FMan and DPAA Ethernet drivers. Besides making the names more aligned, this allows writing udev rules that match on either driver name, if needed, using the fsl_dpaa_* prefix. The change of netdev dev required for the DSA probing makes the previous rules written using this prefix fail, this change makes them work again. > > --- > > drivers/net/ethernet/freescale/fman/Makefile | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/net/ethernet/freescale/fman/Makefile > b/drivers/net/ethernet/freescale/fman/Makefile > > index 2c38119..4ae524a 100644 > > --- a/drivers/net/ethernet/freescale/fman/Makefile > > +++ b/drivers/net/ethernet/freescale/fman/Makefile > > @@ -1,9 +1,9 @@ > > subdir-ccflags-y += -I$(srctree)/drivers/net/ethernet/freescale/fman > > > > -obj-$(CONFIG_FSL_FMAN) += fsl_fman.o > > -obj-$(CONFIG_FSL_FMAN) += fsl_fman_port.o > > -obj-$(CONFIG_FSL_FMAN) += fsl_mac.o > > +obj-$(CONFIG_FSL_FMAN) += fsl_dpaa_fman.o > > +obj-$(CONFIG_FSL_FMAN) += fsl_dpaa_fman_port.o > > +obj-$(CONFIG_FSL_FMAN) += fsl_dpaa_mac.o > > > > -fsl_fman-objs := fman_muram.o fman.o fman_sp.o fman_keygen.o > > -fsl_fman_port-objs := fman_port.o > > -fsl_mac-objs:= mac.o fman_dtsec.o fman_memac.o fman_tgec.o > > +fsl_dpaa_fman-objs := fman_muram.o fman.o fman_sp.o fman_keygen.o > > +fsl_dpaa_fman_port-objs := fman_port.o > > +fsl_dpaa_mac-objs:= mac.o fman_dtsec.o fman_memac.o fman_tgec.o > > > > > -- > Florian
diff --git a/drivers/net/ethernet/freescale/fman/Makefile b/drivers/net/ethernet/freescale/fman/Makefile index 2c38119..4ae524a 100644 --- a/drivers/net/ethernet/freescale/fman/Makefile +++ b/drivers/net/ethernet/freescale/fman/Makefile @@ -1,9 +1,9 @@ subdir-ccflags-y += -I$(srctree)/drivers/net/ethernet/freescale/fman -obj-$(CONFIG_FSL_FMAN) += fsl_fman.o -obj-$(CONFIG_FSL_FMAN) += fsl_fman_port.o -obj-$(CONFIG_FSL_FMAN) += fsl_mac.o +obj-$(CONFIG_FSL_FMAN) += fsl_dpaa_fman.o +obj-$(CONFIG_FSL_FMAN) += fsl_dpaa_fman_port.o +obj-$(CONFIG_FSL_FMAN) += fsl_dpaa_mac.o -fsl_fman-objs := fman_muram.o fman.o fman_sp.o fman_keygen.o -fsl_fman_port-objs := fman_port.o -fsl_mac-objs:= mac.o fman_dtsec.o fman_memac.o fman_tgec.o +fsl_dpaa_fman-objs := fman_muram.o fman.o fman_sp.o fman_keygen.o +fsl_dpaa_fman_port-objs := fman_port.o +fsl_dpaa_mac-objs:= mac.o fman_dtsec.o fman_memac.o fman_tgec.o
Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> --- drivers/net/ethernet/freescale/fman/Makefile | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)