Message ID | 1507906212-10076-2-git-send-email-madalin.bucur@nxp.com |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yD9fs5THxz9sRV for <patchwork-incoming@ozlabs.org>; Sat, 14 Oct 2017 01:52:21 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758251AbdJMOuY (ORCPT <rfc822;patchwork-incoming@ozlabs.org>); Fri, 13 Oct 2017 10:50:24 -0400 Received: from mail-sn1nam01on0064.outbound.protection.outlook.com ([104.47.32.64]:18124 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753533AbdJMOuU (ORCPT <rfc822;netdev@vger.kernel.org>); Fri, 13 Oct 2017 10:50:20 -0400 Received: from BN3PR03CA0112.namprd03.prod.outlook.com (10.174.66.30) by MWHPR03MB2701.namprd03.prod.outlook.com (10.168.207.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 13 Oct 2017 14:50:18 +0000 Received: from BY2FFO11FD022.protection.gbl (2a01:111:f400:7c0c::161) by BN3PR03CA0112.outlook.office365.com (2603:10b6:400:4::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7 via Frontend Transport; Fri, 13 Oct 2017 14:50:18 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD022.mail.protection.outlook.com (10.1.15.211) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Fri, 13 Oct 2017 14:50:17 +0000 Received: from fsr-fed2164-101.ea.freescale.net (fsr-fed2164-101.ea.freescale.net [10.171.73.197]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v9DEoCRw017555; Fri, 13 Oct 2017 07:50:15 -0700 From: Madalin Bucur <madalin.bucur@nxp.com> To: <netdev@vger.kernel.org>, <davem@davemloft.net> CC: <f.fainelli@gmail.com>, <andrew@lunn.ch>, <vivien.didelot@savoirfairelinux.com>, <junote@outlook.com>, <linux-kernel@vger.kernel.org> Subject: [PATCH v2 1/5] fsl/fman: remove of_node Date: Fri, 13 Oct 2017 17:50:08 +0300 Message-ID: <1507906212-10076-2-git-send-email-madalin.bucur@nxp.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1507906212-10076-1-git-send-email-madalin.bucur@nxp.com> References: <1507906212-10076-1-git-send-email-madalin.bucur@nxp.com> Reply-To: <madalin.bucur@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131523798180438952; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(376002)(346002)(39380400002)(39860400002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(5003940100001)(356003)(305945005)(2906002)(54906003)(2950100002)(85426001)(86362001)(3450700001)(6666003)(47776003)(110136005)(97736004)(68736007)(36756003)(50986999)(33646002)(106466001)(5660300001)(104016004)(189998001)(16586007)(8676002)(76176999)(316002)(81156014)(50466002)(81166006)(498600001)(50226002)(53936002)(43066003)(39060400002)(77096006)(4326008)(105606002)(48376002)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR03MB2701; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD022; 1:uLyWpMlqDTv86So0AXhYsy68xP/dMKdzT6EIQDMulueDy83LZWXGSpy18k3yRhZjBseA2tX+0XVjXbvROlvLD64100HiRLKnEc7yHjoQ60gib6LLFQY01DeVikrdE4xD MIME-Version: 1.0 Content-Type: text/plain X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1812374a-4d04-4f42-c247-08d51249b882 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:MWHPR03MB2701; X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2701; 3:tL4T9Hv+Q2ZXuMhmINfmxklktYMxSBSrPA4PNOf+bpluFhTaPstG26t8UuRwFAPhPJyRgbH5wB/9R31wkrZMqpbplIcQrnjW1eFpu+AebrZA7NtZ8j0CgRLLgYMNBTJ8a9lUWzjncrVgD45ZW86T6CcHKSIDvQhYiVbZ/kJHgRU291aS2N2oNDW9mfvkcngfP8CqCwmzXzeUpbvGG0sJk85MI08uzHGepN2THI6GnWI3xHGHyrOe7Aw+WYt3+ciw14a2TUlc3yBMF9N5/kwjpmUkYP4BlpX4A15z5THmp0Fh4of47v5KpYgJFb5Bo0KQ+Q01OD+6jty61v/19gvpV0FZo18oVqjNrgWYWMoYyf0=; 25:eAqyXnitYFDD2WpB7i/njj7ybKuo7A3XPhKywf/Jdn4+N4Fjhu7j1F+PdsqUaABhvWg9Y7/0m7FJYbp9uPQGl9XSX5sfEs8sVj0OVVZYl3PuicQINCwDNjZp9hfB7/O0Wh8Vrnrx+VPT9xs/k5ZAuO50z7Paq0FExRPdvyLt9QRmKPa1AQB5XIA6xT3JWbB0JRnwLy3D+KfO1ouIOjqzGAuovZzAqUTawWqxpSm16+U/yT7dD2575t8Hd2xdWoKerHxUVgc/iOXWxZ97gYyi7AqoqOE/fR8waNro4UXsTYCE0v16VJ+Ov/zUVsLWsGBxLGe/P7kitvbwT+i4zh7vTw== X-MS-TrafficTypeDiagnostic: MWHPR03MB2701: X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2701; 31:kRv2qOUguaUivz3BPFSJRvLcwjF91rYigJIZpJrteY/eIHJB65C+rHkXsXizJIzfjdp75xa5LyDhM39eAOsVBfmYa4HyOLSGHicpYrfnyVsFltUSSl11ya/36QbRe+ODrgSSlQdPzHAHjwgdByr8klmQMb0pFRUTLJbHigPQhattCMfC2wY4oKafqxnQ9tr6gbxMiCmQ9+rso4eqCcAyBBfwYNN94SMb4HAWnjuCuxw=; 4:6r7zWTnc2IqwydjT3LPrOF8WCZx2jH4XsMNVuCabEbYk1wnjne98N6LCoGhPcyE+sTbzzqgwTHig0lFFpUP4O9T6pnFWEZtfJgwPXdc9LfHlY03u2g11VtmooPC41mFwnLRcUMpyjOHEAwm4WlT0oNwcA+UmU3nx3QtKibKeJe1QcvTJqP3p5yLf4SuUsiCzncUj3Blct2pPStfWvs7NvdEIIGSydgwoPjgIeDYionDLQcebmZbqSSsuFXia4J55r1R42vVbLjREQuviughdK6Jy1GIC0dx3tF9Icbz3iBY= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: <MWHPR03MB2701060040FD3EF4BF6A7437EC480@MWHPR03MB2701.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6096035)(20161123565025)(20161123556025)(20161123561025)(20161123559100)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123563025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHPR03MB2701; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHPR03MB2701; X-Forefront-PRVS: 04599F3534 X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2701; 23:NoBGkc48T/5eiU8WrnyVEDBDEACb2riRD2+U7dMNRDb4W3/r3Ng4jnwPkNpfjzmV36RBXuZ7lFeYd3Xr9TBoagBTmvo6ci+IBIX+0baiaN8oddEO7Whdg6RM0KxBj9/+ngf/OzGlr5fwxKUDPx/HzCs87+hLxqX9YbiaGhlnCOxPP/B0dh8VFsTZ5YPfx4NjL7caDK0keyQ9jeW4DHEoAQLeJl6kuK+OkGS3qStCjej1QY9rxuRp8aov1BarQjtagQgt0W29VERVdMZtbJk95G1O8QFEh5d31bfXZzUbaSMEAX8VhoQAKFtMnJRSkzaaJHQrLMTEFuogARz0axs0qveZz6ylL4wz41JoyE8Re97sp2/jSyN2YI7WyuW4JwYdA5lwmwrAqtUwp0N2zm48DrZ0AxpoK4mi3wjM74Q8pm//xHtIpW2td3wtg55HVVmbuw1X06OiU3Wq9cMwrAQAYBGxMjymSVRj0l2F1vDYUU/8MAKkWYieG7KSWuUSvMDhELs1K+wUNsv2vw5IrFiEh2yW72Ik/Be+VlePgnrvM4OIlQeFzRErkCZd3wYKNcjHLAYKLkY0i4k57zw0DXN3HHoXGrl0hWCyfG0kSOso9GzuF1ouXVQo9c+9NJEh82CTjCn+HPR9aYH8cI9qjfW98u/Q4L8/0UWNn0uHfLNj0z79jruWFJO5olQnIB4W9DB1PusAqqvrE/FX3rHeylPe2xjcyKeipB0PB0AyCNKnDZ3n4H9Nq+tY6Ey8zKweJJlTK3Cfrl4tE/qgPWkPJKCkrZQKJPQtcRJ8PhAm6RbYsB1KA/z45Ge47QG3YLWOdbmkOIfVYkDjg4zJzO5b0fNkIvoXMmHOKVRWM+QKoEoHY5QqFiqS01e5lAzHDz9aeCuw7tQtk1PiPOJ8mY78baKVUVU35ULhAqSMfYPQnOZzF5wdEpN+hAn8Y5rldsSUB4zzrGE0GLB2N7o9sB5K0p6tQrGm1x7RA1OkeFhABfhvbLIitbfEGoz82HnOer424VneIFUQtELX797Vf9uW8d2NsDKt33kG5e+/eJFVikfzfpSCHG9awTRjKzLqUC1mZV3khSDMhF/wAROWiZnWIo1djdFsOKRncoXCz6ZDu6EErF+4kwuyIqVoYMrFYtZ5Yfv4PKmmW1uouxM0eB0Rc4kcgU4u92V5XtEJC+MyTA7UG9XLIueGbHGaRUm79ZwDNNg5 X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2701; 6:bM6mEOX2tPOMOI55R48unFJ7/EdK02vZWvtz7245TnvdkoyvUgwNh4ZfwG8HZ9gco4gZZKVn1jEIS1kZBZW8wX7uKlmkkUP8SAsSE+U2BbHgGAl8rI8BjLe2aP2SyQ7BnnkSjL4Lz8+mUFJ3OjqaQkg2ElNAVkaG828eR7S/goanY61HK7mV5RUg40DOs15+e5cT7plmO9nsdjU8/aEYrNZQJzBqeSx7VgeC0/ygEPFBIZmLe7l5AIZIKdFhSZ4NVCtV/gYJjrBVt72I3k9gHISHvgtgavlHQaBQfGuysmnojzlSVEAR3KgqmVeXEPtINbt+KlcefHZySCZ147FZqw==; 5:D/1iPK1c6jGw8PPH30cIaGUk4q7ntf+kj76sMFuAtblQTtDhBzl5Jctn5GA1YfeXDghxYLSaZKlNpFVHLwJjZqJMmtFklxio8k1x4x3QCOY6AfWo5gbE/76laOP+uf6TvNKGmJaRao29PKmLUbL31Q==; 24:ndxmWF3yrmGOgudBgxJYhA/MTbqmgxLXwyts6cQso/SPreQHVzMnK53UAxvuXLbmzUUU1y5AglGKwrjsILPAU6YHE4+btihWrGycppEhD2M=; 7:pq1Ig6f62Bo3sa4cGyxeyoGyfmLOuJ3zQW4RcElxJtYqxML2H0UHeYcnhmEBNHEe5i93+b7JdKmqYun/o+3p4tCyChbHBnBjHBIY0k3+ukyAnQDV2rVkNs9uuTqa34oMD3ePSj5yuR9L3NmQ7KkQgnSZ47yUESWUJefd5WDVLrmq80cS2cUnYNqdB6gkHeBamRLyJi7uH+ctUX3hXV/9Lx0H+0CWou7HD/pzGxM6Cw4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2017 14:50:17.8410 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2701 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
Series | adapt DPAA drivers for DSA | expand |
diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c index 387eb4a..9a265f8 100644 --- a/drivers/net/ethernet/freescale/fman/mac.c +++ b/drivers/net/ethernet/freescale/fman/mac.c @@ -623,7 +623,6 @@ static struct platform_device *dpaa_eth_add_device(int fman_id, goto no_mem; } - pdev->dev.of_node = node; pdev->dev.parent = priv->dev; set_dma_ops(&pdev->dev, get_dma_ops(priv->dev));
The FMan MAC driver allocates a platform device for the Ethernet driver to probe on. Setting pdev->dev.of_node with the MAC node triggers the MAC driver probing of the new platform device. While this fails quickly and does not affect the functionality of the drivers, it is incorrect and must be removed. This was added to address a report that DSA code using of_find_net_device_by_node() is unable to use the DPAA interfaces. Error message seen before this fix: fsl_mac dpaa-ethernet.0: __devm_request_mem_region(mac) failed fsl_mac: probe of dpaa-ethernet.0 failed with error -16 Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> --- drivers/net/ethernet/freescale/fman/mac.c | 1 - 1 file changed, 1 deletion(-)